From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 317A92949E5; Fri, 18 Jul 2025 09:12:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752829952; cv=none; b=YxLBhQPmjkKsr/WfQnVvtwl3GZTH8rebqQIO3xl9Ep2TTS/LK94P2M0BjCpWfCXk/0I1N3638g1QOfg4nv1eMHTkXipC5Et9QydvGjFVVVDKKxZg7uOon6gh1QiIZ27mMaDaJDUWHUe95VTIJSJVjSDiEmBt+tfDBP/JJDtKxMs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752829952; c=relaxed/simple; bh=mwlHdCo5VQ4Al2nKOWOqc5TpeVdGnVMZSc73zjxOe1A=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=saD69wWLPOB2vnTaB05PRgfEgsCpLJx29h7wucRE59AAOuLAMhF/Uz/YwIjOtx6HB1kB+sUJFmYunDDFmsHlnIbz+X4MjoXi7O/e5mw777Uc4L2Lx62kzuzPrgDQI1q+XOUrygsY94SxENuxT5aUK3jKI5mlxt5VGLN4z3OAkO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=eITdS1Wj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="eITdS1Wj" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56I7cZFw022401; Fri, 18 Jul 2025 09:12:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cc6uhBZa+QEXX/Qb71ytouO88dLtvjhvhRyBBx7gsWs=; b=eITdS1Wjo6OiS+PL qFdwJJ08m5RUcrnn3sKT+gEzNsa0IvNxUcif2/mduaLVijVQQYhmRDds36iHSbsK QOlao7IwzEOXQoSRlsNBvUiwmtQoVfzIfFCPU5ot7ILFpzxY/81HQ/hprvhgHNMf Bzbr/FXp0qnk5yT/OvtdIpEUkXMCautSRJRPSoCZ+IlqbXRjOfCdL3Ayv/T+Rf/H Ufxlb4vgMLTtWXLvzl7eeTYaCWELf5dWkmbt9qtaaBRh5ZDEoOlX84F86ayGRJt0 yVYg/zg4wmHshzyNjhW/Ea5no6bq1dzORkUSnkFDaSyvKW/1Rgw+YzK1LP5MjDpQ 7/VjwA== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47wqsyavtr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Jul 2025 09:12:16 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 56I9CG8q013258 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Jul 2025 09:12:16 GMT Received: from [10.253.76.178] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Fri, 18 Jul 2025 02:12:10 -0700 Message-ID: <2f37c7e7-b07b-47c7-904b-5756c4cf5887@quicinc.com> Date: Fri, 18 Jul 2025 17:12:08 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/10] dt-bindings: clock: ipq9574: Rename NSS CC source clocks to drop rate To: Konrad Dybcio , Rob Herring CC: Georgi Djakov , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Michael Turquette , "Stephen Boyd" , Anusha Rao , Konrad Dybcio , Philipp Zabel , "Richard Cochran" , Catalin Marinas , Will Deacon , , , , , , , , , , , , References: <20250710-qcom_ipq5424_nsscc-v3-0-f149dc461212@quicinc.com> <20250710-qcom_ipq5424_nsscc-v3-5-f149dc461212@quicinc.com> <20250710225412.GA25762-robh@kernel.org> <93082ccd-40d2-4a6b-a526-c118c1730a45@oss.qualcomm.com> Content-Language: en-US From: Luo Jie In-Reply-To: <93082ccd-40d2-4a6b-a526-c118c1730a45@oss.qualcomm.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE4MDA3MiBTYWx0ZWRfX3JmeaI0LT5FI uz7mN8D8nDtHvumEG58B81P67eV3jDqu6eiC/Yo44PdVN36nakuDbvpzmZtCnx3i6e6SRBzJGaB r3kz3pXYqLNA9GuMZ1NUFZqtID5asWmUiF06pqtA/grTBJMzdlkhXDOk5fDyxn8GbyicRpHXctH zB8JqLHq05+COqiwuguKyV3L5trkjwh8OwIDTzEPsDXvemeCq5HGRVVNYznKLOHaO5XU8uVRJvu zkB/GuayFK2tBG426DNkg1JYZC4A+yjL3f0oyX1YrDuiJCUgcZseQ3rJzsNaWNJWsqZoY8mdZly /HnG9HSVA3LD3uQ9+qTdLRRbLnYgVem6hdNXtzQ+kkv9KBXQedjVGydmks1hdlHhbyfj0Vvyqj0 hSGC0X5RHK9I6lECV6WdvfwmlgL1nwl6fElWVJKsghAxwpmOC352jTS7OK8LYmTw0Te9rMN5 X-Proofpoint-GUID: CIAh2fAIHPX-nVhQkxfBjm0Ybtf69cNn X-Proofpoint-ORIG-GUID: CIAh2fAIHPX-nVhQkxfBjm0Ybtf69cNn X-Authority-Analysis: v=2.4 cv=McZsu4/f c=1 sm=1 tr=0 ts=687a0ff0 cx=c_pps a=JYp8KDb2vCoCEuGobkYCKw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=1Pu0kYrAtJ1scJCjQtgA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-18_02,2025-07-17_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxlogscore=999 impostorscore=0 mlxscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 suspectscore=0 spamscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507180072 On 7/11/2025 8:15 PM, Konrad Dybcio wrote: > On 7/11/25 12:54 AM, Rob Herring wrote: >> On Thu, Jul 10, 2025 at 08:28:13PM +0800, Luo Jie wrote: >>> Drop the clock rate suffix from the NSS Clock Controller clock names for >>> PPE and NSS clocks. A generic name allows for easier extension of support >>> to additional SoCs that utilize same hardware design. >> >> This is an ABI change. You must state that here and provide a reason the >> change is okay (assuming it is). Otherwise, you are stuck with the name >> even if not optimal. > > The reason here seems to be simplifying the YAML.. which is not a good > reason really.. > > I would instead suggest keeping the clocks list as-is for ipq9574 (this > existing case), whereas improving it for any new additions > > Konrad Thanks Rob and Konrad for the comments. "nss_1200" and "nss" refer to the same clock pin on different SoC. As per Krzystof's previous comment on V2, including the frequency as a suffix in the clock name is not required, since only the frequencies vary across different IPQ SoCs, while the source clock pins for 'PPE' and 'NSS' clocks are the same. Hence this ABI change was deemed necessary. By removing the frequency suffix, the device tree bindings becomes more flexible and easier to extend for supporting new hardware variants in the future. Impact due to this ABI change: The NSS clock controller node is only enabled for the IPQ9574 DTS. In this patch series, the corresponding DTS changes for IPQ9574 are also included to align with this ABI change. Please let me know if further clarification or adjustments are needed.