From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B4A521B9FD for ; Tue, 3 Feb 2026 09:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770109901; cv=none; b=qU4ZjrPM56QtVQ7NYIubT5X4r2oV6UaAaSK5NeOHLBBCf8TM9LFAypGojLxcKcvmKRVdl+nlIfvOVGShHlye44IHm9QVMHbPyBI04CrY7/oE9HKpTNhg/N4UAsGlNnXyEryQ4wp59gcp1M+7p4gth6VJUA/zvVO4iuL6fDseUJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770109901; c=relaxed/simple; bh=cVfXsmh4g5Jnpr+qx6yCihE26g/+bryyh8mxmPKssz4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GYSKuQ73TNi6mSeP16n/y0gram5MGPvY0636TK/94libvecXY6Q6vI30XyH8KMLvWd7DyfJjtoVW10dDJ0jg5PHAeX84JleQhQHDeQDTNpmZu7IIqj4GlVtFdwrTDihMCnrezgWySaVJYVmgBZLK4eY16ca1Q9GG8tVgnLCtuUc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KTyiFKKP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FBlG3VFr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KTyiFKKP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FBlG3VFr" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6137AZ5p2884360 for ; Tue, 3 Feb 2026 09:11:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 51y+zk9oPwAHrTNnzHu+UYWMQfDx1dP+m7ewZ/BKyNE=; b=KTyiFKKPCKB1Ho4W 7KcUorL7euNmrvAP60siFRIOO7488FdIial7MpL8gDwuXQeNSLhgt7PI8EvaKrzC ALs1h+qnRrUznx7rmRIAViCMbSAuHouLcuSr/h2Hv39ZiJVSms9OXE+nppmzO4w/ uoLaeax0DRCUo1XiCdQwKKsGiVWf6fDVd7kV/PUn2XLlki06u0alOudMIKLqL/xr BTMPRb7HcX5OrbQlyZUUtLaaA1Nx0e6h8eDmw/0s5zoZxla93X9wYeE0SZbxY4ge zy2T6udHFbsObvYaNHQkeGbn7OqNmsT8hC2aoZchF8YW7extMH+rnMEbnSnb1bBT i/iJ2w== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c2uu3kg7j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Feb 2026 09:11:39 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2a0a4b748a0so115697245ad.1 for ; Tue, 03 Feb 2026 01:11:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770109899; x=1770714699; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=51y+zk9oPwAHrTNnzHu+UYWMQfDx1dP+m7ewZ/BKyNE=; b=FBlG3VFrWUa8bMWwBg52DyYACOxWWKhw4LRmvHuLmKF3etpgtFLJ0xb2Ttth1RtzO6 iKMgbTU9wkNDEjuhJNWN14vevOvCuXMMRflr+GxqDG3c5dwSR9v9Cw2T9BTdzjar9cnD T2tm3SRy6HkGVOBnXsASJ1xpngwAzNzi3ApzTpZch+eyfzJH4jM+xjJZ7wQPA6RJ1+2B c0gm6/AJGIH/m5wjg660xHBfs77S1zKw8DnbmD0Ym+yOV4nT70/Q812MU+J6z06IXjwq kmS5gwsxpygXUh+mPI11RcYnrD9muyzpj0wRXfbNYD+HaoKb33H6wNPjEei/iT1Lcdw9 9AtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770109899; x=1770714699; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=51y+zk9oPwAHrTNnzHu+UYWMQfDx1dP+m7ewZ/BKyNE=; b=nkaoGzHWJz+RZ43OULl7JonLxPaspm5OXVKFOphevo3Edy2td83WkI59c/xYxrX4jE Py6MAU8JZSYo8koRrc2B7duBcsESqG7b8B71astmZsCLK7wb5D7YiEkUx66Q/F/rUVH2 2e0pmR5dU6BdFbomOt2VovzWmw7wNWjWJVEMCuNrx2i4lw5RqVgyV2fJi3xb86ljhzdk TKBr8xYVjsU5vS0GvlSs9VA9mn31/Lc1gJ/VMlfKJfLidZyOYHxXpBFywDvDdUJEYgAl pMdjkL0H8ruNl77eaQCbqshjFQj9zT/GX0SVp30R3wjDBJoDhoBqZLsNHu+d9Bz2lvrw RM2A== X-Forwarded-Encrypted: i=1; AJvYcCX8TXCFC+uQj0VKAsDITa8T046SCWiNoW/dDTI9HkywqQrp/8dkA+mTcpM6//4ffngcyA1VFUqw+CIGB8w=@vger.kernel.org X-Gm-Message-State: AOJu0YzqBotGPu/mrDPM64KcoB8vM6Jm062mqquAp+YhrvkDETPbA1KN R115yxIrBfbp1VBEDIATfiTmLOIVhMl4NwjK9dJqiEVCJ/n20rvtSEKvIssKJINCFDjOa19mYs/ bs7ZaeqaCPwh3n1nrIiOrtzYs5DgHrdj2NhOzO4fiwRb1r6F1RfqjeZAdcDoqw8QdCXw= X-Gm-Gg: AZuq6aJUumbw9k2Fyvb/fzqE0CLESsNVFsyWwyf3PdPrFNO9QA0ccrZnA/63J9afoNT D2dLU/e4P5i+4VO9GtztXdrU0Yw5mYT7yIki2UnlcDOVaABD5l+JzzshPLMPikKKEwOx1DkabpP dxiZDTRtxuv5mLMQPDZklyg2qVZSGlI888l5JlUCaERDjqyklkv5JczoWeGq6g9uVjTfbzCivFz Y2ZuOknIdTui04meQIq9M1Df06aTWBFh962v6X2H5CFeqb5yVlSKOUeZwvl/wxwIEmRcDRI+/PY M+DJFwfoHhU5xjhjgk4uc+w5uB35zG9ZKQFlwuKYSHat6lyadPi5ucKsjixmZDwlgFLtYlK/GHs VWp+uKQg9dx3MIz+7cTeiY6MgrbEESjViMtWFPhefWsP8 X-Received: by 2002:a17:903:2f91:b0:2a8:d9ea:8b59 with SMTP id d9443c01a7336-2a8d9ea8ce0mr151911215ad.7.1770109899107; Tue, 03 Feb 2026 01:11:39 -0800 (PST) X-Received: by 2002:a17:903:2f91:b0:2a8:d9ea:8b59 with SMTP id d9443c01a7336-2a8d9ea8ce0mr151910935ad.7.1770109898539; Tue, 03 Feb 2026 01:11:38 -0800 (PST) Received: from [10.206.109.90] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b3eecc5sm178047315ad.17.2026.02.03.01.11.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 01:11:38 -0800 (PST) Message-ID: <2f387069-f7e7-e3e5-f66c-c0d9e7fa92a6@oss.qualcomm.com> Date: Tue, 3 Feb 2026 14:41:27 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 4/8] media: iris: scale MMCX power domain on SM8250 Content-Language: en-US To: Dmitry Baryshkov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Jonathan Marek , Ulf Hansson , "Rafael J. Wysocki" , Bryan O'Donoghue , Vikash Garodia , Mauro Carvalho Chehab , Stanimir Varbanov , Abhinav Kumar , Hans Verkuil , Stefan Schmidt , Konrad Dybcio , Bryan O'Donoghue , Dikshita Agarwal Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab References: <20260201-iris-venus-fix-sm8250-v2-0-6f40d2605c89@oss.qualcomm.com> <20260201-iris-venus-fix-sm8250-v2-4-6f40d2605c89@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260201-iris-venus-fix-sm8250-v2-4-6f40d2605c89@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: pBsxsrE1bdkMT2vacwV2_pDfWQQ7Q3Hf X-Authority-Analysis: v=2.4 cv=OrRCCi/t c=1 sm=1 tr=0 ts=6981bbcb cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=R0B0fMNruX7Akzlv-IwA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: pBsxsrE1bdkMT2vacwV2_pDfWQQ7Q3Hf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDA3MyBTYWx0ZWRfX3C4VSywYb1Om gIFDZT0RWY+JFKUsitqW0lWHoNVD6dxgPCPQ3ZOLjzKx8G2cwBiZmMMjl/jb78HbzU1QH1aIArn 9n0hQs3lhX34mhkxjVnCJ1LK+Z/0lvsfizNncIlP0G7IF4+SZpTb9iPjUhQIYjTC2siQOI7cX54 fn1LzNCc/cHmgk2vqFs3gWL772361y3blZFqZFwbUlCLwXSuGLfG4oLGCb+nhXWbTJKtavnKw7W 2258PxcpnVenZUc+CwThYhOjlHFSm+Ny8ungJzbAJz/+bcFCeX4k7RGPjR7sIesiarDsDj5w2pK RJGkxsRTivcGlDL8kOXKj8FOgITrF18mU2GHdAtiuNjdvsEsedU6yLq9MKhzFzCX4MYS/D77PJe eYUXyYdusHHLk7kb8dyKvNo2i8UZuDOZlVG4mBI9HesLBF0IlyNybzWOpZukH8iTCPRZ3BoET0w 4punHl6Kt/lMuc8FmmA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_02,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 adultscore=0 malwarescore=0 phishscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602030073 On 2/1/2026 4:19 PM, Dmitry Baryshkov wrote: > On SM8250 most of the video clocks are powered by the MMCX domain, while > the PLL it powered on by the MX domain. Extend the driver to support Nit: s/it/is/ > scaling both power domains, while keeping compatibitility with the Nit: s/compatibitility/compatibility/ > existing DTs, which define only the MX domain. > > Fixes: 79865252acb6 ("media: iris: enable video driver probe of SM8250 SoC") > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_platform_gen1.c | 2 +- > drivers/media/platform/qcom/iris/iris_probe.c | 7 +++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/drivers/media/platform/qcom/iris/iris_platform_gen1.c > index df8e6bf9430e..aa71f7f53ee3 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c > @@ -281,7 +281,7 @@ static const struct bw_info sm8250_bw_table_dec[] = { > > static const char * const sm8250_pmdomain_table[] = { "venus", "vcodec0" }; > > -static const char * const sm8250_opp_pd_table[] = { "mx" }; > +static const char * const sm8250_opp_pd_table[] = { "mx", "mmcx" }; > > static const struct platform_clk_data sm8250_clk_table[] = { > {IRIS_AXI_CLK, "iface" }, > diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c > index 7b612ad37e4f..74ec81e3d622 100644 > --- a/drivers/media/platform/qcom/iris/iris_probe.c > +++ b/drivers/media/platform/qcom/iris/iris_probe.c > @@ -64,6 +64,13 @@ static int iris_init_power_domains(struct iris_core *core) > return ret; > > ret = devm_pm_domain_attach_list(core->dev, &iris_opp_pd_data, &core->opp_pmdomain_tbl); > + /* backwards compatibility for incomplete ABI SM8250 */ > + if (ret == -ENODEV && > + of_device_is_compatible(core->dev->of_node, "qcom,sm8250-venus")) { > + iris_opp_pd_data.num_pd_names--; > + ret = devm_pm_domain_attach_list(core->dev, &iris_opp_pd_data, > + &core->opp_pmdomain_tbl); > + } > if (ret < 0) > return ret; > > Once above nits are fixed. Reviewed-by: Dikshita Agarwal Thanks, Dikshita