From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4320BC433DF for ; Fri, 9 Oct 2020 15:56:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 105B022284 for ; Fri, 9 Oct 2020 15:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602258987; bh=xrj/rdbqDnIrotHIzTU7kZhn04yZMTt84v6W5yHA8s4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=SqX5G/ZdP+L1n9ydYgtGxaOJ5UJrqjASX3X/MnX4W5PiJMjt3IerOME/3URWc0lR7 J2SISLdd87cCVcLo0YswaRzw8NJktGUhN8MK/hqQI9BhvshmN0xupEK0xmKX6jGpSn d+sD+dOM8QeQXwzsXVfOdhYKlLog0h8DJzMLZfMA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389538AbgJIP40 (ORCPT ); Fri, 9 Oct 2020 11:56:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389511AbgJIP4V (ORCPT ); Fri, 9 Oct 2020 11:56:21 -0400 Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 372D9C0613DD for ; Fri, 9 Oct 2020 08:56:18 -0700 (PDT) Received: by mail-ot1-x344.google.com with SMTP id 60so9430242otw.3 for ; Fri, 09 Oct 2020 08:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nxGBD0NCi/MzhF6RzJGO1Op3qiNabAYCN4C/VOLMVMg=; b=Pv8X98rQrxmQmC3AYgeqGl/3Wk9jEr2z3r1AsjjBWItQarSnLt+hACI/K+54PmcGqB a6eccMthV+9Z0NohOHwemKNP3iAKtcfB871irTEsCjdu6VJjkKtzuC0TCZ+38LgwYXqy 22DWwqfvNOxEp+4/pcAGi+dbraAvqO0gRaIDs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nxGBD0NCi/MzhF6RzJGO1Op3qiNabAYCN4C/VOLMVMg=; b=AQcxPXjSVzlQfTwYY7NF6hUnT/f4lhEgHULlapbBJCTlqsOkl6IgN9cbxA1n07Es1B OHdbf8Nihmwrbuyq467Nl0MOCngUi1qdqZsrV+6bsFfrJLL4tkQeOtNT2DcK4/bQuYhE qe1Pcrwzcp8bRKpKKXdBpTogphYqdxQLxC44FYsth2iASgdsoYBorzfP65IorUKhzMyW 5pLvJNe1X1MLfxwOsZFLAGF+Tcp079ev225dy5odg8+q1SDldZ36qgvtiOo3lK2VKB9Z uzf8sk0MqhG0onB8reAXO6EPHm4pcQ0JxtQLLwJSB58cDtIjiJBUzqrTr820zAIpooxk ObKQ== X-Gm-Message-State: AOAM531AwPaPV4dbd8aQOnHH/bme+2Y5SsbgKskOJms/s2rplL6n7Rjn Ul3GP+JzFVQwTDyKmaGNyYi1Ng== X-Google-Smtp-Source: ABdhPJwbBZCHnPwAt1monb6rS8Y1Exeh2/LVfsjInRAkUPpEXOu1zrSNDvtpFRcJNjRoSW4w4ceTAQ== X-Received: by 2002:a9d:224b:: with SMTP id o69mr8748064ota.358.1602258977631; Fri, 09 Oct 2020 08:56:17 -0700 (PDT) Received: from shuah-t480s.internal (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id e7sm7347246oia.9.2020.10.09.08.56.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2020 08:56:17 -0700 (PDT) From: Shuah Khan To: rafael@kernel.org, james.morse@arm.com, tony.luck@intel.com, bp@alien8.de, gregkh@linuxfoundation.org, keescook@chromium.org Cc: Shuah Khan , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov Subject: [PATCH v3 06/11] drivers/acpi/apei: convert seqno counter_atomic32 Date: Fri, 9 Oct 2020 09:56:01 -0600 Message-Id: <2f39e13e92b587ac48b7c11a17854b6426cfb745.1602209970.git.skhan@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org counter_atomic* is introduced to be used when a variable is used as a simple counter and doesn't guard object lifetimes. This clearly differentiates atomic_t usages that guard object lifetimes. counter_atomic* variables wrap around to INT_MIN when it overflows and should not be used to guard resource lifetimes, device usage and open counts that control state changes, and pm states. seqno is a sequence number counter for logging. This counter gets incremented. Unsure if there is a chance of this overflowing. It doesn't look like overflowing causes any problems since it is used to tag the log messages and nothing more. Convert it to use counter_atomic32. This conversion doesn't change the overflow wrap around behavior. Acked-by: Rafael J. Wysocki Acked-by: Borislav Petkov Reviewed-by: Kees Cook Signed-off-by: Shuah Khan --- drivers/acpi/apei/ghes.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index 81bf71b10d44..92169436be18 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -41,6 +41,7 @@ #include #include #include +#include #include #include @@ -562,7 +563,7 @@ static void __ghes_print_estatus(const char *pfx, const struct acpi_hest_generic *generic, const struct acpi_hest_generic_status *estatus) { - static atomic_t seqno; + static struct counter_atomic32 seqno = COUNTER_ATOMIC_INIT(0); unsigned int curr_seqno; char pfx_seq[64]; @@ -573,7 +574,7 @@ static void __ghes_print_estatus(const char *pfx, else pfx = KERN_ERR; } - curr_seqno = atomic_inc_return(&seqno); + curr_seqno = counter_atomic32_inc_return(&seqno); snprintf(pfx_seq, sizeof(pfx_seq), "%s{%u}" HW_ERR, pfx, curr_seqno); printk("%s""Hardware error from APEI Generic Hardware Error Source: %d\n", pfx_seq, generic->header.source_id); -- 2.25.1