From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FC96C43334 for ; Fri, 10 Jun 2022 11:14:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346701AbiFJLOQ (ORCPT ); Fri, 10 Jun 2022 07:14:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344989AbiFJLOO (ORCPT ); Fri, 10 Jun 2022 07:14:14 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C1FCA6A402 for ; Fri, 10 Jun 2022 04:14:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654859651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w51nJtA+PEQulTzssZ7Zqb9+Ta6ksQQtTLDRht+NgLE=; b=Y1YJ1iGfk9TQ1szzQuAfbvT1fNDzwZcLYSYal9w54ZDs7pHJdQ978rZS087TVNFu1JsOlV 6LEiKUjXkIo+GqXBkJEwmuTIGfbd8/yu7SDrgCGae+i387pFiipu6ddgpntFO+2cE1IroW NQs7zH9AWFsW/jXFsKwasHrqntuHQOs= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-646-QF-22dnYNOitOLOP90iM-g-1; Fri, 10 Jun 2022 07:14:10 -0400 X-MC-Unique: QF-22dnYNOitOLOP90iM-g-1 Received: by mail-ej1-f71.google.com with SMTP id k7-20020a1709062a4700b006fe92440164so12421179eje.23 for ; Fri, 10 Jun 2022 04:14:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=w51nJtA+PEQulTzssZ7Zqb9+Ta6ksQQtTLDRht+NgLE=; b=qbi+gX07p9Nc+qTn1jk+pBnde9kKpZ3DJ+OpmQJSsDHXKL/hS8IYhMB7sdFyW4GV28 Iq/6jhBioy18Ovvb0k2lfXAIVfv/VqXM6fFJUzaCc4K2GGWgkTrRmYnCscFi60ZTrYcO 6yTqM9jT1UtcdI26lj7Ec7oQYaMT+MMEHhBH4zyRS2hcssvUrNtb7cvcTJAzTkoueivU HQuf8BxdJJHJbPqbUkqF+Ue86pvw0LmyXjzWlJgvMuSFI0sAeC5f7U8dAAZCTheZxhZc pf2yUhQ32zDNBlOC+VJ5lYWO7qCpso+uRoTdNuqqM6yZ69QAh9azP7VtxM1bj6jGDwT6 OE9w== X-Gm-Message-State: AOAM531a5yMZzmDCzZeztbxI3Ls3fLvnkRtEFiQFoJbUuTG3BIuLoLzo 1RF+Z0AvnU3wq7bOtDUSg1v/zRHZ2yJSLuy4L6CQy1H77JZG6jwoyDWSyknConOt8ik16tpw/+a KCWPNOtDx4Gjidsrbgfvj10db X-Received: by 2002:a05:6402:51d4:b0:42f:b38d:dbb9 with SMTP id r20-20020a05640251d400b0042fb38ddbb9mr39351378edd.255.1654859649461; Fri, 10 Jun 2022 04:14:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrrmyaZEw0oRtI29tcTzt8FyPnbqcDOdKb5aOJSDIKllrLhDC3D72FyTSmusXp1CMT1Z5YZQ== X-Received: by 2002:a05:6402:51d4:b0:42f:b38d:dbb9 with SMTP id r20-20020a05640251d400b0042fb38ddbb9mr39351362edd.255.1654859649221; Fri, 10 Jun 2022 04:14:09 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id jo13-20020a170906f6cd00b006febc86b8besm11856829ejb.117.2022.06.10.04.14.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 04:14:08 -0700 (PDT) Message-ID: <2f3b38fa-8180-a749-a590-2f758f3a479a@redhat.com> Date: Fri, 10 Jun 2022 13:14:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [bugzilla-daemon@kernel.org: [Bug 216109] New: Steam Deck fails to boot when E820 entries clipped out of _CRS] Content-Language: en-US To: Bjorn Helgaas , linux-pci@vger.kernel.org Cc: "Guilherme G. Piccoli" , Thorsten Leemhuis , linux-kernel@vger.kernel.org References: <20220609224339.GA543225@bhelgaas> From: Hans de Goede In-Reply-To: <20220609224339.GA543225@bhelgaas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 6/10/22 00:43, Bjorn Helgaas wrote: > New regression in v5.19-rc1. > > ----- Forwarded message from bugzilla-daemon@kernel.org ----- > > Subject: [Bug 216109] New: Steam Deck fails to boot when E820 entries clipped > out of _CRS > > https://bugzilla.kernel.org/show_bug.cgi?id=216109 > > Summary: Steam Deck fails to boot when E820 entries clipped out > of _CRS > Kernel Version: v5.19 > > Guilherme G. Piccoli reported that v5.18 boots fine on Steam Deck, but > v5.19-rc1 does not. He bisected it to 4c5e242d3e93 ("x86/PCI: Clip only host > bridge windows for E820 regions") [1]. > > A quirk similar to [2] that disables E820 clipping makes v5.19-rc1 work again. > > The reason why v5.18 (which always does E820 clipping by default) works, while > v5.19-rc1 (which also does E820 clipping on this platform) does not has not > been explained yet. > > [1] https://git.kernel.org/linus/4c5e242d3e93 > [2] https://git.kernel.org/linus/d341838d776a > > ----- End forwarded message ----- I've added some analysis of the logs to the bug. Summary: I think we may need to revert 4c5e242d3e93, this will be a non trivial revert moving the pci_use_e820 check added in later commits to arch_remove_reservations(). See the bug for details and lets discuss this further in the bug. In case we do eventually decide to go with a revert, I'll prepare a revert later today and push it to: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note I do NOT plan to merge this through the pdx86 tree, the reason to put it there is to get the builders to play with it, since in the past: https://lore.kernel.org/linux-pci/20211014183943.27717-2-hdegoede@redhat.com/ we had some build issues with the check inside arch_remove_reservations(). Regards, Hans