From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42FA01CCB2E for ; Tue, 19 Nov 2024 13:26:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732022811; cv=none; b=EYLJTJuMPbsMOEbdTWo967fg3ECsf/BVCzzSeqNVaZbcNzzH1tqrwIm5ObeEEB/tTBGPr6JXbf52NYNSnsT4RctEfBmzpWlAwI4ajjOo6da5w5uiVNSldMjDEeCapU8OhgnzUKd+j/3Xcxlc/V8sqmBFfTR1jvpiN1iX5WT8knY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732022811; c=relaxed/simple; bh=dHzqkeXyGZxoyEER89dgFvalpys9/u2EZB4Kf1NdMAM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JsulVEL1BXSA7VQnuu8uHq2HLaIlzf9pjWwHCzucWxBo9uk91QbzKNT6IheqnMlSajIX41WIr3hN3Jh9cLSup1haJKujvHoDPplLqWkWgQw3IOKTJ0VEe3rQscW5TSB8cJvr+nrpqMNn/ScsQranzLNg5ODb6D04zTv7pHEJ77U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iCcv8bqB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iCcv8bqB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732022809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o6U12McX0gLRso4X1EBn+6q4cTylPrsJWbZXzRtzWis=; b=iCcv8bqBGJRkdwX1/z9V1ZOkSswn1YwbQKoLn+gGouSoO+efkwxm2hwbwYfbALK0hykwpQ sP9IhHAgy7UjxdM4wXZvQigrJ1pUXxYP0Nju0JtHj4a4r5WMEdt4uVCuUWmwx8285fuMVl UKWWOsjvf8n3oM5ixXALFp5LsPj2zv4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-hfHNTMSVOA-3sSHaA9hurQ-1; Tue, 19 Nov 2024 08:26:48 -0500 X-MC-Unique: hfHNTMSVOA-3sSHaA9hurQ-1 X-Mimecast-MFC-AGG-ID: hfHNTMSVOA-3sSHaA9hurQ Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4314f1e0f2bso23421595e9.1 for ; Tue, 19 Nov 2024 05:26:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732022807; x=1732627607; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o6U12McX0gLRso4X1EBn+6q4cTylPrsJWbZXzRtzWis=; b=UALuA5kKKPaxKFefNQ1MJ6ifqE4KZ4v7G99/jI8f4TJqvhn4O11d1V2qVhBmbJRNRh c/fQcCBruD6ieunWfapcXBhr/XKtyLmfCstnJ/nU/z/P0TdX2w1C88BNbYki0x4GV8cb Miu6r1eDd4IfsVXZLMF7lt8NBCHYvw3x7Qyy5rQXC+uTCMGYth6yLMrlLOSdfwqeRgmo oZGA5sgIR32tCKRBB0WopqW4o51EvUbQnczDGd0g/PjYi9J+0Gf9VTvfWzY6SQsPUC3Z kGHyFbCJyIRcSQPjsU6JTWjPttnQlMIAs4gChqlmeqRUh3h/J+IReEP7r2M32ZjRFoCd 6m8g== X-Forwarded-Encrypted: i=1; AJvYcCU/RBaykydvhGWyIbVcrBZlJoIUdj6MMzcy9SjRCq6Ib1bog7bXTAavLRKRuplBgl/eqy2aoPNojj6QAJA=@vger.kernel.org X-Gm-Message-State: AOJu0YzwLjimJ7HUPGmgcynLxkexSmWtj9Zj/qmrmEUeJeK+kFWN+e4U K9sZnJsxxr5gde3oabjZap7kHFNIKkjC2E8FIzzpAN01JpX0bql7EALmmtgqYKt4N3hP/yGe56O QgTWjFHZ+gNA5Dv2DlrhevL/OBppOm9O9gyYK/g+ijMOGFJq0ADfrMFdfW0wd8w== X-Received: by 2002:a05:600c:a06:b0:431:44fe:fd9a with SMTP id 5b1f17b1804b1-432df74ebdcmr137446335e9.19.1732022806942; Tue, 19 Nov 2024 05:26:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/k+jIPt/dDGdVaALFmmUrMT+C/DcK08Oar0xgRAdR68ilXIx+aM6j48Xg3ytlxudYqX9m+w== X-Received: by 2002:a05:600c:a06:b0:431:44fe:fd9a with SMTP id 5b1f17b1804b1-432df74ebdcmr137446145e9.19.1732022806610; Tue, 19 Nov 2024 05:26:46 -0800 (PST) Received: from [192.168.1.14] (host-79-55-200-170.retail.telecomitalia.it. [79.55.200.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432dab7220asm191372055e9.6.2024.11.19.05.26.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Nov 2024 05:26:46 -0800 (PST) Message-ID: <2f3ccc2c-6cb1-46c5-a462-9489e1c4471b@redhat.com> Date: Tue, 19 Nov 2024 14:26:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 3/4] net: ipv6: seg6_iptunnel: mitigate 2-realloc issue To: Justin Iurman , netdev@vger.kernel.org Cc: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, kuba@kernel.org, horms@kernel.org, linux-kernel@vger.kernel.org, David Lebrun References: <20241118131502.10077-1-justin.iurman@uliege.be> <20241118131502.10077-4-justin.iurman@uliege.be> <1bc6fbd9-aa04-4bed-b435-262edd8f2d37@redhat.com> <5dfc336e-d7e0-4219-af1e-6284facbdd94@uliege.be> Content-Language: en-US From: Paolo Abeni In-Reply-To: <5dfc336e-d7e0-4219-af1e-6284facbdd94@uliege.be> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/19/24 14:07, Justin Iurman wrote: > On 11/19/24 11:47, Paolo Abeni wrote: >> Also the code would probably be more readable with: >> >> struct dst_entry *old_dst = skb_dst(skb); >> >> and using 'old_dst' instead of 'skb_dst(skb)' > > Ack. How about "dst" instead of "old_dst" (since it's the current > dst_entry), and "cache_dst" instead of "dst"? Fine by me. I guess such option should also give a smaller diff, which would be a nice plus. Thanks! Paolo