From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32725C433E0 for ; Thu, 9 Jul 2020 07:11:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12C7920674 for ; Thu, 9 Jul 2020 07:11:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726477AbgGIHLJ (ORCPT ); Thu, 9 Jul 2020 03:11:09 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:7279 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726193AbgGIHLI (ORCPT ); Thu, 9 Jul 2020 03:11:08 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 837BFB140773F287219E; Thu, 9 Jul 2020 15:11:04 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.214) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 9 Jul 2020 15:11:00 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: don't skip writeback of quota data To: Jaegeuk Kim , , , References: <20200709053027.351974-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <2f4207db-57d1-5b66-f1ee-3532feba5d1f@huawei.com> Date: Thu, 9 Jul 2020 15:10:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200709053027.351974-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/7/9 13:30, Jaegeuk Kim wrote: > It doesn't need to bypass flushing quota data in background. The condition is used to flush quota data in batch to avoid random small-sized udpate, did you hit any problem here? Thanks, > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 44645f4f914b6..72e8b50e588c1 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -3148,7 +3148,7 @@ static int __f2fs_write_data_pages(struct address_space *mapping, > if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING))) > goto skip_write; > > - if ((S_ISDIR(inode->i_mode) || IS_NOQUOTA(inode)) && > + if (S_ISDIR(inode->i_mode) && > wbc->sync_mode == WB_SYNC_NONE && > get_dirty_pages(inode) < nr_pages_to_skip(sbi, DATA) && > f2fs_available_free_memory(sbi, DIRTY_DENTS)) >