mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jinjie Ruan <ruanjinjie@huawei.com>
To: Marc Zyngier <maz@kernel.org>, Zenghui Yu <zenghui.yu@linux.dev>
Cc: <tglx@kernel.org>, <radu@rendec.net>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] irqchip/gic-v3-its: Size the collection table for all possible CPUs
Date: Thu, 19 Nov 2026 15:53:31 +0800	[thread overview]
Message-ID: <2f42e904-c295-4243-a714-d0767477819b@huawei.com> (raw)
In-Reply-To: <861p8i12gr.wl-maz@kernel.org>



在 2026/11/19 1:20, Marc Zyngier 写道:
> On Wed, 18 Nov 2026 16:44:11 +0000,
> Zenghui Yu <zenghui.yu@linux.dev> wrote:
>>
>> On 11/18/26 10:51 AM, Jinjie Ruan wrote:
>>> The collection table is currently sized at a single ITS page size,
>>> and the driver's allocation policy is to allocate a single collection
>>> per CPU. On systems with more CPUs that the ITS can fit in a single
>>> page, no LPI can be routed to the CPUs that don't have an allocated
>>> collection, and the system grinds to a halt.
>>
>> The issue on the reported hardware ("384-CPU HiSilicon HIP12 system", as
>> described in v1) is fixed by allocating 2 pages for the flat collection
>> table. That is fine.
>>
>>>
>>> Change the allocation policy to allow two-level tables, similarly to
>>> the other tables.
>>
>> But I'm afraid that the two-level CT is still not supported: nothing in the
>> driver allocates the level-2 CTs.
> 
> Hmmm. You're are absolutely right.
> 
> It should only be a matter of plugging its_alloc_table_entry() in
> its_alloc_collections() and getting the error handling right (which
> is, I reckon, the hardest part).
>

OK,I Will fix this issue and the AI review issue.

> Thanks,
> 
> 	M.
> 


      reply	other threads:[~2026-11-19  7:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  2:51 Jinjie Ruan
2026-11-18 16:44 ` Zenghui Yu
2026-11-18 17:20   ` Marc Zyngier
2026-11-19  7:53     ` Jinjie Ruan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f42e904-c295-4243-a714-d0767477819b@huawei.com \
    --to=ruanjinjie@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=radu@rendec.net \
    --cc=tglx@kernel.org \
    --cc=zenghui.yu@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®