From: <Arun.Ramadoss@microchip.com>
To: <vtpieter@gmail.com>
Cc: <Tristram.Ha@microchip.com>, <andrew@lunn.ch>,
<linux@armlinux.org.uk>, <olteanv@gmail.com>,
<davem@davemloft.net>, <Woojung.Huh@microchip.com>,
<linux-kernel@vger.kernel.org>, <pieter.van.trappen@cern.ch>,
<f.fainelli@gmail.com>, <kuba@kernel.org>,
<UNGLinuxDriver@microchip.com>, <edumazet@google.com>,
<o.rempel@pengutronix.de>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>
Subject: Re: [PATCH net-next v2 1/3] net: dsa: microchip: rename ksz8 series files
Date: Mon, 2 Sep 2024 14:30:35 +0000 [thread overview]
Message-ID: <2f4884ff683c2ba7510f562f1a0f1c86ce6a0518.camel@microchip.com> (raw)
In-Reply-To: <CAHvy4ApAq6dvvAJhU9LSvxRD7eH76vL5KycVk-tg85tVWZ5gvQ@mail.gmail.com>
Hi Pieter,
On Mon, 2024-09-02 at 12:08 +0200, Pieter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> Hi Arun,
>
> > > - This driver adds support for Microchip KSZ9477 series
> > > switch and
> > > - KSZ8795/KSZ88x3 switch chips.
> > > + This driver adds support for Microchip KSZ9477 series,
> > > + LAN937X series and KSZ8 series switch chips, being
> > > + KSZ9477/9896/9897/9893/9563/9567,
> >
> > You missed KSZ8567 and KSZ8563. Also it could be in order as
> > suggested
> > by Tristram,
> > - KSZ8863/8873, KSZ8895/8864, KSZ8794/8795/8765
> > - KSZ9477/9897/9896/9567/8567
> > - KSZ9893/9563/8563
> > - LAN9370/9371/9372/9373/9374
>
> OK will do.
>
> > > + * It supports the following switches:
> > > + * - KSZ8863, KSZ8873 aka KSZ88X3
> > > + * - KSZ8895, KSZ8864 aka KSZ8895 family
> >
> > You can remove 'family' here, so as to be consistent.
>
> Well I'd rather keep it so it's consistent with the ksz_common.h
> ksz_is_8895_family(), do you agree?
OK. LGTM.
next prev parent reply other threads:[~2024-09-02 14:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 14:12 [PATCH net-next v2 0/3] net: dsa: microchip: rename and clean " vtpieter
2024-08-30 14:12 ` [PATCH net-next v2 1/3] net: dsa: microchip: rename " vtpieter
2024-09-02 2:56 ` Arun.Ramadoss
2024-09-02 10:08 ` Pieter
2024-09-02 14:30 ` Arun.Ramadoss [this message]
2024-08-30 14:12 ` [PATCH net-next v2 2/3] net: dsa: microchip: clean up ksz8_reg definition macros vtpieter
2024-09-02 3:25 ` Arun.Ramadoss
2024-08-30 14:12 ` [PATCH net-next v2 3/3] net: dsa: microchip: replace unclear KSZ8830 strings vtpieter
2024-09-02 3:32 ` Arun.Ramadoss
2024-09-02 10:14 ` Pieter
2024-09-02 14:48 ` Arun.Ramadoss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f4884ff683c2ba7510f562f1a0f1c86ce6a0518.camel@microchip.com \
--to=arun.ramadoss@microchip.com \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pieter.van.trappen@cern.ch \
--cc=vtpieter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®