From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752014AbdECIGE (ORCPT ); Wed, 3 May 2017 04:06:04 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:36025 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461AbdECIFz (ORCPT ); Wed, 3 May 2017 04:05:55 -0400 Subject: Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer To: Xie Qirong , Franky Lin , Hante Meuleman , Kalle Valo Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Piotr Haber References: <20170503073555.3922-1-cheerx1994@gmail.com> From: Arend van Spriel Message-ID: <2f49e699-b9f7-b55f-0afc-7ac03631de28@broadcom.com> Date: Wed, 3 May 2017 10:05:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <20170503073555.3922-1-cheerx1994@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/3/2017 9:35 AM, Xie Qirong wrote: > Signed-off-by: Xie Qirong > --- > > setup_timer.cocci suggested the following improvement: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:383:1-11: Use > setup_timer function for function on line 384. Move the text above before your sign-off so it will end up in the git commit message. When done you may also add my acknowledgement, ie.: Acked-by: Arend van Spriel Regards, Arend