mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dean Luick <dean.luick@cornelisnetworks.com>
To: Leon Romanovsky <leon@kernel.org>,
	Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Justin Stitt <justinstitt@google.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH] IB/hfi1: replace deprecated strncpy
Date: Fri, 22 Sep 2023 09:25:39 -0500	[thread overview]
Message-ID: <2f4bd46c-664e-4253-8d57-16bd46dd3be8@cornelisnetworks.com> (raw)
In-Reply-To: <169537858725.3339131.15264681410291677148.b4-ty@kernel.org>

On 9/22/2023 5:29 AM, Leon Romanovsky wrote:
>
> On Thu, 21 Sep 2023 07:17:47 +0000, Justin Stitt wrote:
>> `strncpy` is deprecated for use on NUL-terminated destination strings
>> [1] and as such we should prefer more robust and less ambiguous string
>> interfaces.
>>
>> We see that `buf` is expected to be NUL-terminated based on it's use
>> within a trace event wherein `is_misc_err_name` and `is_various_name`
>> map to `is_name` through `is_table`:
>> | TRACE_EVENT(hfi1_interrupt,
>> |        TP_PROTO(struct hfi1_devdata *dd, const struct is_table *is_entry,
>> |                 int src),
>> |        TP_ARGS(dd, is_entry, src),
>> |        TP_STRUCT__entry(DD_DEV_ENTRY(dd)
>> |                         __array(char, buf, 64)
>> |                         __field(int, src)
>> |                         ),
>> |        TP_fast_assign(DD_DEV_ASSIGN(dd);
>> |                       is_entry->is_name(__entry->buf, 64,
>> |                                         src - is_entry->start);
>> |                       __entry->src = src;
>> |                       ),
>> |        TP_printk("[%s] source: %s [%d]", __get_str(dev), __entry->buf,
>> |                  __entry->src)
>> | );
>>
>> [...]
>
> Applied, thanks!

It is unfortunate that this and the qib patch was accepted so quickly.  The replacement is functionally correct.  However, I was going to suggest using strscpy() since the return value is never looked at and all use cases only require a NUL-terminated string.  Padding is not needed.

>
> [1/1] IB/hfi1: replace deprecated strncpy
>       https://git.kernel.org/rdma/rdma/c/c2d0c5b28a77d5
>
> Best regards,

External recipient

  reply	other threads:[~2023-09-22 14:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21  7:17 Justin Stitt
2023-09-22 10:29 ` Leon Romanovsky
2023-09-22 14:25   ` Dean Luick [this message]
2023-09-24  3:20     ` Kees Cook
2023-09-26 12:56       ` Dean Luick
2023-09-29 19:56         ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f4bd46c-664e-4253-8d57-16bd46dd3be8@cornelisnetworks.com \
    --to=dean.luick@cornelisnetworks.com \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=jgg@ziepe.ca \
    --cc=justinstitt@google.com \
    --cc=leon@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®