From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A14B2EB64D7 for ; Mon, 26 Jun 2023 16:12:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231819AbjFZQML (ORCPT ); Mon, 26 Jun 2023 12:12:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231733AbjFZQMA (ORCPT ); Mon, 26 Jun 2023 12:12:00 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76C1110F6 for ; Mon, 26 Jun 2023 09:11:50 -0700 (PDT) Received: from [192.168.2.254] (109-252-154-132.dynamic.spd-mgts.ru [109.252.154.132]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 7E6D566003AC; Mon, 26 Jun 2023 17:11:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1687795908; bh=9EZs0izTC9fT3uhYtjpxEXL0MLcsJc+fn/xx7LDWC30=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eW9yYPq6r+yhdEvGBX0mFerL6rT+zA/f5p+Aq+i+1Gvz7TmqJ3PZZCbxm5O9mxC0q +wsB3qZtEg6L+HAx2svRPhQWQW+uAjqweSzb5ZVPE96+wB2K6lfsiabzOX2s7HHEth vT+clsYUfkiTRmR+8m1P4NMY6iBMVAYZemw2KTMwYfdrud9xHPfIVtghLSrypMxSO1 8mOxPCsDdm7DtudciYaTh1sRBkpx6H0zjiINaLQPalZvz59ETD2dSxQ2K4Us+qd8Nh f7DDiZEqwu3PHqtmtAnUgJaeZtg1Q1W4U9OfbF43uyvrvIQEhg5lpm2KKMvk1lAeW6 7hsT1XtYiMYOA== Message-ID: <2f4d3e96-1e10-3662-bfc5-8c361a4c1366@collabora.com> Date: Mon, 26 Jun 2023 19:11:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.1 Subject: Re: [PATCH v6 3/3] drm/virtio: Support sync objects Content-Language: en-US To: Geert Uytterhoeven Cc: David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Rob Clark , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Pierre-Eric Pelloux-Prayer , Emil Velikov , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, virtualization@lists.linux-foundation.org References: <20230416115237.798604-1-dmitry.osipenko@collabora.com> <20230416115237.798604-4-dmitry.osipenko@collabora.com> <0ca8034d-0377-26b9-51c8-8caff6c4174a@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/25/23 18:36, Geert Uytterhoeven wrote: > Hi Dmitry, > > On Sun, Jun 25, 2023 at 2:41 PM Dmitry Osipenko > wrote: >> On 6/25/23 11:47, Geert Uytterhoeven wrote: >>> On Sun, Apr 16, 2023 at 1:55 PM Dmitry Osipenko >>> wrote: >>>> Add sync object DRM UAPI support to VirtIO-GPU driver. Sync objects >>>> support is needed by native context VirtIO-GPU Mesa drivers, it also will >>>> be used by Venus and Virgl contexts. >>>> >>>> Reviewed-by; Emil Velikov >>>> Signed-off-by: Dmitry Osipenko >>> >>> Thanks for your patch! >>> >>>> --- a/drivers/gpu/drm/virtio/virtgpu_submit.c >>>> +++ b/drivers/gpu/drm/virtio/virtgpu_submit.c >>> >>>> +static int >>>> +virtio_gpu_parse_deps(struct virtio_gpu_submit *submit) >>>> +{ >>>> + struct drm_virtgpu_execbuffer *exbuf = submit->exbuf; >>>> + struct drm_virtgpu_execbuffer_syncobj syncobj_desc; >>>> + size_t syncobj_stride = exbuf->syncobj_stride; >>>> + u32 num_in_syncobjs = exbuf->num_in_syncobjs; >>>> + struct drm_syncobj **syncobjs; >>>> + int ret = 0, i; >>>> + >>>> + if (!num_in_syncobjs) >>>> + return 0; >>>> + >>>> + /* >>>> + * kvalloc at first tries to allocate memory using kmalloc and >>>> + * falls back to vmalloc only on failure. It also uses GFP_NOWARN >>> >>> GFP_NOWARN does not exist. >> >> https://elixir.bootlin.com/linux/v6.4-rc7/source/include/linux/gfp_types.h#L38 > > That line defines "__GFP_NOWARN", not "GFP_NOWARN". > C is case- and underscore-sensitive. as is "git grep -w" ;-) The removal of underscores was done intentionally for improving readability of the comment -- Best regards, Dmitry