From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753706AbdKGWaI (ORCPT ); Tue, 7 Nov 2017 17:30:08 -0500 Received: from mail-qk0-f195.google.com ([209.85.220.195]:43128 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbdKGWaG (ORCPT ); Tue, 7 Nov 2017 17:30:06 -0500 X-Google-Smtp-Source: ABhQp+RpXamNJ+CfKD7eVWIjHb8hO5OvNXSPlgMJcBXTtRDbgRpobDJg52NBTT+/HTFpyrv+OYBlTg== Subject: Re: [PATCH 2/2] ARM: dts: NSP: Fix PPI interrupt types To: bcm-kernel-feedback-list@broadcom.com Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, jon.mason@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, linux@armlinux.org.uk, mark.rutland@arm.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org References: <20171107222812.17267-1-f.fainelli@gmail.com> <20171107222812.17267-3-f.fainelli@gmail.com> From: Florian Fainelli Message-ID: <2f4dfba2-923a-840a-7dc9-5761380b28c5@gmail.com> Date: Tue, 7 Nov 2017 14:30:01 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171107222812.17267-3-f.fainelli@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/2017 02:28 PM, Florian Fainelli wrote: > Booting a kernel results in the kernel warning us about the following > PPI interrupts configuration: > [ 0.105127] smp: Bringing up secondary CPUs ... > [ 0.110545] GIC: PPI11 is secure or misconfigured > [ 0.110551] GIC: PPI13 is secure or misconfigured > > Fix this by using the appropriate edge configuration for PPI11 and > PPI13, this is similar to what was fixed for Northstar (BCM5301X) in > commit 0e34079cd1f6 ("ARM: dts: BCM5301X: Correct GIC_PPI interrupt > flags"). > > Fixes: 1a9d53cabaf4 ("ARM: dts: NSP: Add TWD Support to DT") this should have been Fixes: 7b2e987de207 ("ARM: NSP: add minimal Northstar Plus device tree"), I can fix that up while applying unless there are other comments. > Fixes: 1a9d53cabaf4 ("ARM: dts: NSP: Add TWD Support to DT") > Signed-off-by: Florian Fainelli > --- > arch/arm/boot/dts/bcm-nsp.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi > index dff66974feed..d5f5e92e7488 100644 > --- a/arch/arm/boot/dts/bcm-nsp.dtsi > +++ b/arch/arm/boot/dts/bcm-nsp.dtsi > @@ -85,7 +85,7 @@ > timer@20200 { > compatible = "arm,cortex-a9-global-timer"; > reg = <0x20200 0x100>; > - interrupts = ; > + interrupts = ; > clocks = <&periph_clk>; > }; > > @@ -93,7 +93,7 @@ > compatible = "arm,cortex-a9-twd-timer"; > reg = <0x20600 0x20>; > interrupts = - IRQ_TYPE_LEVEL_HIGH)>; > + IRQ_TYPE_EDGE_RISING)>; > clocks = <&periph_clk>; > }; > > -- Florian