From: "Koenig, Christian" <Christian.Koenig@amd.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will.deacon@arm.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: Confusing lockdep message
Date: Mon, 20 May 2019 11:38:07 +0000 [thread overview]
Message-ID: <2f4fb196-e66e-bb0e-c5b2-d9072561f648@amd.com> (raw)
In-Reply-To: <386d7978-18fd-318e-ddc9-784266b75d9e@amd.com>
Please ignore this mail,
I've fixed the double unlock and lockdep is still complaining about the
nested locking, so I'm actually facing multiple issues here.
Sorry to waste your time,
Christian.
Am 20.05.19 um 13:19 schrieb Christian König:
> Hi guys,
>
> writing the usual suspects about locking/lockdep stuff and also Daniel
> in CC because he might have stumbled over this as well.
>
> It took me a while to figuring out what the heck lockdep was
> complaining about. The relevant dmesg was the following:
>> [ 145.623005] ==================================
>> [ 145.623094] WARNING: Nested lock was not taken
>> [ 145.623184] 5.0.0-rc1+ #144 Not tainted
>> [ 145.623261] ----------------------------------
>> [ 145.623351] amdgpu_test/1411 is trying to lock:
>> [ 145.623442] 0000000098a1c4d3 (reservation_ww_class_mutex){+.+.},
>> at: ttm_eu_reserve_buffers+0x46e/0x910 [ttm]
>> [ 145.623651]
>> but this task is not holding:
>> [ 145.623758] reservation_ww_class_acquire
>> [ 145.623836]
>> stack backtrace:
>> [ 145.623924] CPU: 4 PID: 1411 Comm: amdgpu_test Not tainted
>> 5.0.0-rc1+ #144
>> [ 145.624058] Hardware name: System manufacturer System Product
>> Name/PRIME X399-A, BIOS 0808 10/12/2018
>> [ 145.624234] Call Trace:
>> ...
>
> The problem is now that the message is very confusion because the
> issue was *not* that I tried to acquire a lock, but rather that I
> accidentally released a lock twice.
>
> Now releasing a lock twice is a rather common mistake and I'm really
> surprised that I didn't get that pointed out by lockdep immediately.
>
> Additional to that I'm pretty sure that this used to work correctly
> sometimes in the past, so I'm either hitting a rare corner case or
> this broke just recently.
>
> Anyway can somebody take a look? I can try to provide a test case if
> required.
>
> Thanks in advance,
> Christian.
next prev parent reply other threads:[~2019-05-20 11:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 11:19 Koenig, Christian
2019-05-20 11:38 ` Koenig, Christian [this message]
2019-05-20 15:50 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f4fb196-e66e-bb0e-c5b2-d9072561f648@amd.com \
--to=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome