From: Eugen Hristev <ehristev@kernel.org>
To: Balakrishnan Sambath <balakrishnan.s@microchip.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Hans Verkuil <hverkuil@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 06/10] media: microchip-isc: store the unshifted PFE_CFG0 BPS value
Date: Fri, 17 Jul 2026 08:32:35 +0300 [thread overview]
Message-ID: <2f4fdfc1-c5b9-41ee-a588-48d4d44e0105@kernel.org> (raw)
In-Reply-To: <20260629-balki-isc-prefix-fixes-v1-v2-6-3b120cc3742f@microchip.com>
On 6/29/26 14:09, Balakrishnan Sambath wrote:
> pfe_cfg0_bps held a pre-shifted BPS value (ISC_PFE_CFG0_BPS_EIGHT was
> 0x4 << 28) ORed straight into the register. The other format selectors
> like cfa_baycfg store the bare field value and position it at the write,
> so this one was inconsistent.
>
> Store the bare BPS value and apply it with FIELD_PREP() at the PFE_CFG0
> write, and fix the pfe_cfg0_bps comment to match. No functional change.
>
> Suggested-by: Eugen Hristev <ehristev@kernel.org>
> Signed-off-by: Balakrishnan Sambath <balakrishnan.s@microchip.com>
> ---
> drivers/media/platform/microchip/microchip-isc-base.c | 4 +++-
> drivers/media/platform/microchip/microchip-isc-regs.h | 10 +++++-----
> drivers/media/platform/microchip/microchip-isc.h | 4 +++-
> 3 files changed, 11 insertions(+), 7 deletions(-)
>
Reviewed-by: Eugen Hristev <ehristev@kernel.org>
next prev parent reply other threads:[~2026-07-17 5:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 11:09 [PATCH v2 00/10] media: microchip-isc: AWB, stream-stop and endpoint-ref fixes Balakrishnan Sambath
2026-06-29 11:09 ` [PATCH v2 01/10] media: microchip-isc: fix awb_mutex and lock lifecycle Balakrishnan Sambath
2026-06-29 11:09 ` [PATCH v2 02/10] media: microchip-isc: take a reference on the parsed endpoints Balakrishnan Sambath
2026-06-29 11:09 ` [PATCH v2 03/10] media: microchip-isc: synchronize the IRQ before disabling clocks on stop Balakrishnan Sambath
2026-06-29 11:09 ` [PATCH v2 04/10] media: microchip-isc: disable histogram and flush AWB work on teardown Balakrishnan Sambath
2026-06-29 11:09 ` [PATCH v2 05/10] media: microchip-isc: do not touch WB registers when not streaming Balakrishnan Sambath
2026-06-29 11:09 ` [PATCH v2 06/10] media: microchip-isc: store the unshifted PFE_CFG0 BPS value Balakrishnan Sambath
2026-07-17 5:32 ` Eugen Hristev [this message]
2026-06-29 11:09 ` [PATCH v2 07/10] media: microchip-isc: fix ISC_PFG_CFG0_BPS macro name typo Balakrishnan Sambath
2026-07-17 5:31 ` Eugen Hristev
2026-06-29 11:09 ` [PATCH v2 08/10] media: microchip-isc: fix PM runtime leak in AWB work handler Balakrishnan Sambath
2026-06-29 11:09 ` [PATCH v2 09/10] media: microchip-isc: fix SBGGR10 Bayer pattern Balakrishnan Sambath
2026-06-29 11:09 ` [PATCH v2 10/10] media: microchip-isc: fix WB offset and gain register field masking Balakrishnan Sambath
2026-07-17 5:29 ` Eugen Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f4fdfc1-c5b9-41ee-a588-48d4d44e0105@kernel.org \
--to=ehristev@kernel.org \
--cc=balakrishnan.s@microchip.com \
--cc=hverkuil@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome