From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9684633B96B for ; Fri, 31 Jul 2026 05:53:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785477186; cv=none; b=BLiC91sNgCWzYdpba2uLcXRXNgznJHnXAqF8QkXJMs9/d+7pTZLGx9zGiENmR8ulgjBYt40bJ1ZrcbqC6tvtdEGx1CmXXoCbwymxli7+H5VcY+zFNnZu1eAtxLNWJ5/jqiH6bZ0Hg1t6KGu8TQ7MpO13pXAEPhJ0ZNN6VIHu4z0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785477186; c=relaxed/simple; bh=vpy6xdGN7rrdChF2u6c8T/K7jhlzFRZYBy+D+Mbc5Vw=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=Tw+l2sEmLdfv41W0LDiPbus9k8VJ4I3HKkhnLUJpARtDkhMjZ+2yTLk1KzM30dCEMnOgraEc3rU6k6vhX3X5Vh4iwU6jrxLRPvgJ+pBaL9w+xR3vZac/fUnizXuEwsKWz+ZvYcJaWs6bHgRRvCuSXbFuuYogw0RtGAoWdmK1Mi8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nXMVvYAl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RYrlFdi3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nXMVvYAl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RYrlFdi3" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66V5HPWl3235695 for ; Fri, 31 Jul 2026 05:53:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QdEo3sXlneRb8+FCJZTqiVYriegj6muf8pmwtU37L7Q=; b=nXMVvYAli9wMqo0V 5t0qCMLEBYn2BxkfPupUleVPBOHl9vfCxbUZ/WHtTzjexUEfDA9UZttYjVbzaoYe P6FnXJ15dT9XmCOZz0zZmmzUBsdKhn74AAybgodWW6VVdkAMwQ2xq0VuSJWmKe3y ttH81t7nc7OfXuap2h2pGBE5R5HTsRFGcgdsR4YAa0gkdTxVm4UuPxyfmUwNae1P 2j63U/jSIFjiW5hFV4ig/SyK1HuYE+VYLWdga2SIb2cl+2v+nh8R8WbEVnKpv+mL UYttA5vd/boYhr9kmbyOEJANxrKV/5DUoNTCfHZku6KnkuvFaYBq8TqOlZjeKVpj T+ZvCQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frne503pg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 05:53:04 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cce14a21faso7458145ad.0 for ; Thu, 30 Jul 2026 22:53:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785477184; x=1786081984; darn=vger.kernel.org; h=content-transfer-encoding:content-language:content-type:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject:from:to:cc:subject:date:message-id:reply-to:content-type; bh=QdEo3sXlneRb8+FCJZTqiVYriegj6muf8pmwtU37L7Q=; b=RYrlFdi3obDQGfEjljIeHMy4ZO4tJ8oZX6s2ufrFgI2xKs0juresuCazAfTP/ZyC3M 4ZmeWMFzKzzk6NAtPWex9rKCL74Wll8hI641/OU+KpbFfmbwWER/rbWgdenzbB0oSRNE //RE7+9fELendgX5MRHeprOdNowGqpO6DbgVFxkDnaKJTFYpkbK8R2YbMnK0R+4QYP1n HTd0HnprSJm1h7noS7aR9t8Eae9KRcl0nVgLDVz6sjmebay7wgl6pm19urg9bchvqntU N+/9SROzzYFZOQCz7kxlv5NDAhlA8o4gxGxYDIYANn6YYAdoQt9uIL3l8jsjY1PH8W9x VA8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785477184; x=1786081984; h=content-transfer-encoding:content-language:content-type:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QdEo3sXlneRb8+FCJZTqiVYriegj6muf8pmwtU37L7Q=; b=GO2VVlryFtgPhdlCAlQGZbUmwmdnAdNIQS5+P9+En6LxkZ5LOdRa9rrDI1VGucuTNM 8tmuhU8vUoYB2Oh9stORof6me/yaeRn2t/kdzHM3dpiMx7lnUqBOYVwKKTCYFRTLqN/4 hZ2FYunDf0K8Du+d1zTKDiAj28yP6iTob4qtMAmTXgRsrvZJIh8mjmCxWzpFPsMz5rRN nayXdeTtP5U6C+nh+gPeQ/1M1W6V+ZhiJb8VUJIarbWqcH9OIfKk8Yt/vD00kNvxrGX8 UcfSLCpufvPCo2wIjtnqbG6RJEM8D6nYzeADoN94BWwBDnSwpOUNmNEoWg7Kht8rdPb2 H6GA== X-Forwarded-Encrypted: i=1; AHgh+RqfCQEakJb61w66l5SOiekzAeBK6Z3F/5R/muC+kHXmlQZk5YMgcn1IgWXUVCEJlMqgLw3xR6PYlw5WsoQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxh1EinSP3UfXCcZUF2BGKvYUWfduZlLviPNJ/N66blODkS2zw/ o8cP9davlN2cEWC8xX6+NO47dLlS2xKfrolxyC3swJb1SYV1Y+LsEHL72D8ZjHaGmAg6DucBDgQ ahvMD5aE6xEBhMZfVspge5T2I2kuUBROgnIRd3MlXE/esJg4P/7o8XfHS6eI2wKsnchQ= X-Gm-Gg: AR+sD12+DxqOvusMgWudIxROW8tOwJlKRlmFnzNuCaNILA9lhIU+0PxNOINbEOlW6tx 4oiEScVCzlPvG69M8nazAqO7iBieh8FFeuEI7A255EhVD2j4UbBkMsrkprCXpLJKRABsQlxfPno jpcyLcN9eRsz8qSBK2GvVxbxy+AXubcaQGKim4u4wUdeS8hxRA/b4DPMs1crQWDIsgmbHkaOTdZ 2d8wA2a/qTJ8BSD/cS67V1+l2amU40oh8jm3/oWmCWJYkDd5xwg1y/dxaYZT7YlFRJEhNFtD9pz aOutoVlyAuVX/9ZyJUI2D76mA9SUT7WrQzMzsdwXocF8QumhDWn/YiraUUC4uRGYTc1YroVC0FX b8hI5bL2Z5tCDa81jX+b1nWBjNIA= X-Received: by 2002:a17:902:e5c4:b0:2ce:b43e:44da with SMTP id d9443c01a7336-2d0483abc4fmr4124695ad.17.1785477184098; Thu, 30 Jul 2026 22:53:04 -0700 (PDT) X-Received: by 2002:a17:902:e5c4:b0:2ce:b43e:44da with SMTP id d9443c01a7336-2d0483abc4fmr4124465ad.17.1785477183634; Thu, 30 Jul 2026 22:53:03 -0700 (PDT) Received: from [10.218.4.105] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d04b15c176sm491125ad.77.2026.07.30.22.52.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 22:53:03 -0700 (PDT) Subject: Re: [PATCH v5 1/4] mmc: Allow host driver to control the re-programming of Crypto keys To: Eric Biggers Cc: ulf.hansson@linaro.org, adrian.hunter@intel.com, quic_dmukhopa@quicinc.com, quic_rampraka@quicinc.com, quic_nitirawa@quicinc.com, quic_sachgupt@quicinc.com, quic_bhaskarv@quicinc.com, quic_gaurkash@quicinc.com, quic_sartgarg@quicinc.com, ram.gupta@oss.qualcomm.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260730140822.1976635-1-neeraj.soni@oss.qualcomm.com> <20260730140822.1976635-2-neeraj.soni@oss.qualcomm.com> <20260730190346.GB3139@sol> From: Neeraj Soni Message-ID: <2f502fd1-1f24-213f-11f4-ffec024c9b02@oss.qualcomm.com> Date: Fri, 31 Jul 2026 11:22:57 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20260730190346.GB3139@sol> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=ftzsol4f c=1 sm=1 tr=0 ts=6a6c3840 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=hEwqdWZ_t5p12PLCf_IA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDAzOCBTYWx0ZWRfX3Iq/JZMVgigN kAfjcSW/GZettxw6yz+LioAPV11rB13zTQ+SkIDVxLvrgRmSqcKz9ofMjqbCithoQD/u1XzVoAE EbcuMJW6JiKhZLIPF1OyFmMYcNxSu3M= X-Proofpoint-ORIG-GUID: KX4HfW_n_RqZ_Sh39ZDVKPeSkcPvMV7u X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDAzOCBTYWx0ZWRfX7m7UGVzqSlWJ Gz3kEMgVjCtPs17gftYWtEwQwrXInNFs0RNpvAQBg9sGUo5sUD69diXjtgUErW5pHOIWLoZTGCE Me7PsKA0ZYcnj89/43ZawRA+kzjZkTJd2MilP24p/W7+0kiTqu0scEg2/aO2HLXEZGfRREzXpLp 3r5wFR9391dNJyQxnC+Q2U/iWWMnXYa6/pSzzRLdnv84wXD0gNyIcGB5MoSyEWEni3kxvCmXCks gs4u5hCXgTG5neBzC7csxoaqI0HYf9J4WILQ1LtqtruR6zifQ4F/FVJh9dMtvP2y9MAGZwb2a+i 9AszICkTP6jOfxrsiihhD3VvyE8O9D5sTEHra/v6cAAWk7wzhifgsLrweQQk9Qy2XOGWOrR7ZkK QIAwgGzifd3laObgZ1/K+Gd16TtH7NLgy6/s1tVOVb/0xRN1oAkoxhxv/69epVeiTDJxSiPI7Uf h8iVMX36/ZIIinKzIWw== X-Proofpoint-GUID: KX4HfW_n_RqZ_Sh39ZDVKPeSkcPvMV7u X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_02,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 suspectscore=0 bulkscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310038 On 7/31/2026 12:33 AM, Eric Biggers wrote: > On Thu, Jul 30, 2026 at 07:38:19PM +0530, Neeraj Soni wrote: >> diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h >> index ba84f02c2a10..83d92fb64417 100644 >> --- a/include/linux/mmc/host.h >> +++ b/include/linux/mmc/host.h >> @@ -457,12 +457,9 @@ struct mmc_host { >> #define MMC_CAP2_CQE_DCMD (1 << 24) /* CQE can issue a direct command */ >> #define MMC_CAP2_AVOID_3_3V (1 << 25) /* Host must negotiate down from 3.3V */ >> #define MMC_CAP2_MERGE_CAPABLE (1 << 26) /* Host can merge a segment over the segment size */ >> -#ifdef CONFIG_MMC_CRYPTO >> #define MMC_CAP2_CRYPTO (1 << 27) /* Host supports inline encryption */ >> -#else >> -#define MMC_CAP2_CRYPTO 0 >> -#endif > > I'm still a bit confused why this unrelated change is included. If > you'd like to make this unrelated change, it should be a separate patch, > and the mtk-sd patch would need to be before it (not after). > This was included as part of clean up suggested by Konrad for MMC_CAP2_CRYPTO_NO_REPROG here https://lore.kernel.org/linux-mmc/a569a2c3-2fb2-4a40-8d54-898e7c36f4b3@oss.qualcomm.com/ but i understand that this is unrelated to this patch series. I will revert this in v6. > - Eric > Regards, Neeraj