mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jürgen Groß" <jgross@suse.com>
To: Lukas Bulwahn <lbulwahn@redhat.com>,
	Jiqian Chen <Jiqian.Chen@amd.com>, Huang Rui <ray.huang@amd.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	xen-devel@lists.xenproject.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lukas Bulwahn <lukas.bulwahn@redhat.com>
Subject: Re: [PATCH] xen: Fix config option reference in XEN_PRIVCMD definition
Date: Mon, 30 Sep 2024 12:47:05 +0200	[thread overview]
Message-ID: <2f589a3d-91c9-4ebb-9206-97dd418fba47@suse.com> (raw)
In-Reply-To: <20240930090650.429813-1-lukas.bulwahn@redhat.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 815 bytes --]

On 30.09.24 11:06, Lukas Bulwahn wrote:
> From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> 
> Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev")
> adds a weak reverse dependency to the config XEN_PRIVCMD definition,
> referring to CONFIG_XEN_PCIDEV_BACKEND. In Kconfig files, one refers to
> config options without the CONFIG prefix, though. So in its current form,
> this does not create the reverse dependency as intended, but is an
> attribute with no effect.
> 
> Refer to the intended config option XEN_PCIDEV_BACKEND in the XEN_PRIVCMD
> definition.
> 
> Fixes: 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>

Reviewed-by: Juergen Gross <jgross@suse.com>

Thanks for the fix!


Juergen


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

      reply	other threads:[~2024-09-30 10:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30  9:06 Lukas Bulwahn
2024-09-30 10:47 ` Jürgen Groß [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f589a3d-91c9-4ebb-9206-97dd418fba47@suse.com \
    --to=jgross@suse.com \
    --cc=Jiqian.Chen@amd.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lbulwahn@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@redhat.com \
    --cc=oleksandr_tyshchenko@epam.com \
    --cc=ray.huang@amd.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®