mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Janne Grunau <j@jannau.net>, Hector Martin <marcan@marcan.st>,
	Sven Peter <sven@svenpeter.dev>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Mark Kettenis <kettenis@openbsd.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>
Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/17] dt-bindings: interrupt-controller: apple,aic2: Add apple,t8112-aic compatible
Date: Mon, 13 Feb 2023 12:12:25 +0100	[thread overview]
Message-ID: <2f5a63ba-f4de-da89-7621-3fe1d79cdc94@linaro.org> (raw)
In-Reply-To: <20230202-asahi-t8112-dt-v1-5-cb5442d1c229@jannau.net>

On 12/02/2023 16:41, Janne Grunau wrote:
> The Apple M2 SoC uses AICv2 and is compatible with the existing driver.
> Add its per-SoC compatible.
> Since multi-die versions of the M2 are not expected decrease
> '#interrupt-cells' to 3 for apple,t8112-aic. This is seamlessly handled
> inside the driver.
> 
> Signed-off-by: Janne Grunau <j@jannau.net>
> 
> ---
> This trivial dt-bindings update should be merged through the asahi-soc
> tree to ensure validation of the Apple M2 (t8112) devicetrees in this
> series.
> ---
>  .../bindings/interrupt-controller/apple,aic2.yaml  | 23 +++++++++++++++++++---
>  1 file changed, 20 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> index 06948c0e36a5..120e23ff668c 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> @@ -31,19 +31,22 @@ description: |
>  properties:
>    compatible:
>      items:
> -      - const: apple,t6000-aic
> +      - enum:
> +          - apple,t8112-aic
> +          - apple,t6000-aic
>        - const: apple,aic2
>  
>    interrupt-controller: true
>  
>    '#interrupt-cells':
> -    const: 4
> +    minimum: 3
> +    maximum: 4
>      description: |
>        The 1st cell contains the interrupt type:
>          - 0: Hardware IRQ
>          - 1: FIQ
>  
> -      The 2nd cell contains the die ID.
> +      The 2nd cell contains the die ID (optional).
>  
>        The next cell contains the interrupt number.
>          - HW IRQs: interrupt number
> @@ -98,6 +101,20 @@ properties:
>            - apple,fiq-index
>            - cpus
>  
> +if:

Put it under allOf. After "required:", just like example-schema asks for.

> +  properties:
> +    compatible:
> +      contains:
> +        const: apple,t8112-aic
> +then:
> +  properties:
> +    '#interrupt-cells':
> +      maximum: 3

Shouldn't this be:
const: 3

> +else:
> +  properties:
> +    '#interrupt-cells':
> +      minimum: 4

const: 4


Best regards,
Krzysztof


  parent reply	other threads:[~2023-02-13 11:13 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-12 15:41 [PATCH 00/17] Device trees for Apple M2 (t8112) based devices Janne Grunau
2023-02-12 15:41 ` [PATCH 01/17] dt-bindings: power: apple,pmgr-pwrstate: Add t8112 compatible Janne Grunau
2023-02-13 11:09   ` Krzysztof Kozlowski
2023-02-14  2:24     ` Hector Martin
2023-02-14  7:50       ` Krzysztof Kozlowski
2023-02-14  8:43         ` Hector Martin
2023-02-14  9:39           ` Krzysztof Kozlowski
2023-02-14 10:13             ` Hector Martin
2023-02-14  8:46   ` Janne Grunau
2023-02-12 15:41 ` [PATCH 02/17] dt-bindings: arm: apple: apple,pmgr: Add t8112-pmgr compatible Janne Grunau
2023-02-13 11:10   ` Krzysztof Kozlowski
2023-02-13 11:57     ` Janne Grunau
2023-02-13 12:10       ` Krzysztof Kozlowski
2023-02-14  2:35         ` Hector Martin
2023-02-13 12:15       ` Krzysztof Kozlowski
2023-02-12 15:41 ` [PATCH 03/17] dt-bindings: watchdog: apple,wdt: Add t8112-wdt compatible Janne Grunau
2023-02-13 11:11   ` Krzysztof Kozlowski
2023-02-12 15:41 ` [PATCH 04/17] dt-bindings: arm: cpus: Add apple,avalanche & blizzard compatibles Janne Grunau
2023-02-13 11:11   ` Krzysztof Kozlowski
2023-02-12 15:41 ` [PATCH 05/17] dt-bindings: interrupt-controller: apple,aic2: Add apple,t8112-aic compatible Janne Grunau
2023-02-12 17:12   ` Marc Zyngier
2023-02-13 11:12   ` Krzysztof Kozlowski [this message]
2023-02-13 12:33     ` Janne Grunau
2023-02-12 15:41 ` [PATCH 06/17] dt-bindings: arm-pmu: Add PMU compatible strings for Apple M2 cores Janne Grunau
2023-02-13 11:13   ` Krzysztof Kozlowski
2023-02-12 15:41 ` [PATCH 07/17] dt-bindings: iommu: apple,sart: Add apple,t8112-sart compatible string Janne Grunau
2023-02-13 11:13   ` Krzysztof Kozlowski
2023-02-13 13:23     ` Janne Grunau
2023-02-12 15:41 ` [PATCH 08/17] dt-bindings: mailbox: apple,mailbox: Add t8112 compatibles Janne Grunau
2023-02-12 15:41 ` [PATCH 09/17] dt-bindings: nvme: apple: Add apple,t8112-nvme-ans2 compatible string Janne Grunau
2023-02-12 15:41 ` [PATCH 10/17] dt-bindings: pci: apple,pcie: Add t8112 support Janne Grunau
2023-02-12 15:41 ` [PATCH 11/17] dt-bindings: pinctrl: apple,pinctrl: Add apple,t8112-pinctrl compatible Janne Grunau
2023-02-13 10:14   ` Linus Walleij
2023-02-12 15:41 ` [PATCH 12/17] dt-bindings: i2c: apple,i2c: Add apple,t8112-i2c compatible Janne Grunau
2023-02-12 16:20   ` Wolfram Sang
2023-02-12 15:41 ` [PATCH 13/17] dt-bindings: clock: apple,nco: Add t8112-nco compatible Janne Grunau
2023-02-18  2:06   ` Stephen Boyd
2023-02-12 15:41 ` [PATCH 14/17] dt-bindings: sound: apple,mca: Add t8112-mca compatible Janne Grunau
2023-02-13 12:37   ` Mark Brown
2023-02-13 13:41   ` Krzysztof Kozlowski
2023-02-16 16:00   ` Mark Brown
2023-02-16 16:26     ` Janne Grunau
2023-02-12 15:41 ` [PATCH 15/17] dt-bindings: dma: apple,admac: Add t8112-admac compatible Janne Grunau
2023-02-13  5:25   ` Vinod Koul
2023-02-12 15:41 ` [PATCH 16/17] dt-bindings: arm: apple: Add t8112 j413/j473/j493 compatibles Janne Grunau
2023-02-13 11:15   ` Krzysztof Kozlowski
2023-02-13 13:42     ` Janne Grunau
2023-02-14  9:43   ` Krzysztof Kozlowski
2023-02-12 15:41 ` [PATCH 17/17] arm64: dts: apple: t8112: Initial t8112 (M2) device trees Janne Grunau
2023-02-13 11:22   ` Krzysztof Kozlowski
2023-02-13 14:01     ` Janne Grunau
2023-02-13 14:36       ` Krzysztof Kozlowski
2023-02-13 15:08         ` Janne Grunau
2023-02-13 15:43           ` Krzysztof Kozlowski
2023-02-12 16:46 ` [PATCH 00/17] Device trees for Apple M2 (t8112) based devices Martin Povišer
2023-02-21 13:47 ` (subset) " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f5a63ba-f4de-da89-7621-3fe1d79cdc94@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alyssa@rosenzweig.io \
    --cc=asahi@lists.linux.dev \
    --cc=devicetree@vger.kernel.org \
    --cc=j@jannau.net \
    --cc=kettenis@openbsd.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=maz@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sven@svenpeter.dev \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®