From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A996187876 for ; Fri, 31 Jan 2025 21:31:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738359084; cv=none; b=D86AgLZCaqjXOvyLqwsZbwqLtOtEifC/qYCPZo5aM4y6++WnL7Th2k5Nh4iT+lCDuKrFlNM3ok+UIvPz1xyh16QgJ5qMU7maI/oi485uN71PuoGy2r5F5V93ruYBNvbXpX3BHs+glcNkI+vdTN7EbkKV5VUFu7xIkc3qm0SJiuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738359084; c=relaxed/simple; bh=ftu7pmvGV2qr+jK4JxkhWrw+cRjCunxZf5kwDUQrlbc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HoUD0AxhJZkI1DOAGN28mxYun5q0ftsa5xp0X+zuLyQqoivpRZgjd4ZfAyltrfTOckdsMCJb488VYbvCLAxZEC0woUEZiNc6SO7nRARKJ02Xget8NM0Yvogah260AwZ4lPIumo5Fy6OV9NeTFI9jDc7WVP/OvT0gaGm5P9Fu6oU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=sZjwYpSj; arc=none smtp.client-ip=209.85.167.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="sZjwYpSj" Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-3eb972dd8e5so1305207b6e.2 for ; Fri, 31 Jan 2025 13:31:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738359081; x=1738963881; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jDvnP9HNi8abDAufTXVzuVdU4XUJ2r6pu6gJGv0aC7A=; b=sZjwYpSj624x16hqUYRvl0jZxfCo+u3ddY+Jp6rOrkw8hilEtnKKaJGtYakV4g4Ma6 jSKYcVBB1dNMUYAnE9o4JXUGSdbLh+hWNTAnaWEGlRDHxBHdSJpyjAfCYj3d4vJT89gS lxypHg3HkRll+qtM4E7fUmoCYg0+8YFoA7ZVAZR8LvPvrMYrsUX80wHhdZXIz8HP2rw/ oPxAwlOE1nVpSALCPbW4wJc7bGAK8lPSVnhAQLpvNX5WH8BE8/LsQIvK/BiZeJX0azys K2UV7N06Fn7faUutooPJu/QGzfYScbWke0nXOXdFZy8l6bU7tuZM0Ela7AUZCU9mtahk r6sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738359081; x=1738963881; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jDvnP9HNi8abDAufTXVzuVdU4XUJ2r6pu6gJGv0aC7A=; b=r+FFaUG3AnnEuJLVVMgrk3FaI0U9eF3Ywui1zMqeWiVT/WlhNbVP7L8j1DX/4A+K+B oy8ZmwVQ0NmBUXy4X1VlrJvCredwFoMr00V0BseKEwoRgDZGyoh4XAD3cDJ6IEYD09Cr ENRv2CpkyqpNg35oCq6EQCqCbTbTE6L+LO4xnhxG+gIsQW4A17st6VL8ew4VuJPHhqTO oWso66a2/F27wjs5DOeP6YfTBRl1bPgAUVq07kUHOoQFdRjoTgKk+G2IEWaXnyJamF87 nCTGO3DQ80dxIQ+TCjMQEbp4wKiKrVU3QgA01/C7GEBqzV0vvWKi6OcgMk4ciq4spNy+ G3zQ== X-Forwarded-Encrypted: i=1; AJvYcCXpJ1YPqE2tdLAE09xd0E3CdKV1EbEjJqfAKX32PWofKyznQzlbM0KIE3gqv0X0u0ICd/gi01IC7SVDk1g=@vger.kernel.org X-Gm-Message-State: AOJu0YyImQSrTtiN8jADGb/Hpk82JL0fz8zv4pZBj4SZdLyDR67rxMs1 tCRYKai2BE/d7s2q0KEMZVJboYerU1/wI9z2tcbsgn2dxR6eDgZzhMCT9ZVLz/Z2ytem5htq2JM B X-Gm-Gg: ASbGncuESUeUTkWn2DnCg6TNruGxpRlI91X5nDmsvo+Ju1zBYY1dT3Qy8YjCpOsmVtA mzc0Su+XKAmh84XUjR15AmyegRLlXjV0WQ/aXyNnuIfRf/f+XrgAW1x62nov562dUx/+/WK5JXQ SNp3FBbCmyxcpXx5y8KZYvYcwv+EZrJshEunywB5+lk6eVOOY2Xb5ceyMIh9FfAiI+Fa1HWd8Al voBC93c7S+5NSMKztKbJrHyQMD1O0OFbbtdH7owrQ5tu9EBdnu3zapxZEVhpidkXYsDcQNnRed+ V7JyBIypKspGbouboPb+x3UnEOxnHLb0R6ww9CDQpzvZ1MkXBT0Q X-Google-Smtp-Source: AGHT+IHD853czjvUWSx2EKQmtEracV4UoohrB2SBmjKc282qQiCd0uVnsaL5aEELB96obJY4/Zxf8A== X-Received: by 2002:a05:6808:2214:b0:3eb:3bcc:a9e7 with SMTP id 5614622812f47-3f323b74ce1mr9851115b6e.34.1738359081365; Fri, 31 Jan 2025 13:31:21 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5fc104e29b7sm1073975eaf.17.2025.01.31.13.31.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jan 2025 13:31:20 -0800 (PST) Message-ID: <2f604280-f4dd-494f-9f54-83e8f613b64f@baylibre.com> Date: Fri, 31 Jan 2025 15:31:18 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/10] iio: adc: ad7606: change r/w_register signature To: Angelo Dureghello , Michael Hennerich , Lars-Peter Clausen , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandru Ardelean Cc: Jonathan Cameron , linux-fbdev@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Guillaume Stols References: <20250129-wip-bl-ad7606_add_backend_sw_mode-v3-0-c3aec77c0ab7@baylibre.com> <20250129-wip-bl-ad7606_add_backend_sw_mode-v3-8-c3aec77c0ab7@baylibre.com> From: David Lechner Content-Language: en-US In-Reply-To: <20250129-wip-bl-ad7606_add_backend_sw_mode-v3-8-c3aec77c0ab7@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/29/25 5:03 AM, Angelo Dureghello wrote: > From: Guillaume Stols > > The register read/write with IIO backend will require to claim the > direct mode, and doing so requires passing the corresponding iio_dev > structure. > So we need to modify the function signature to pass the iio_dev > structure. > > Signed-off-by: Guillaume Stols > --- I don't think calling iio_device_claim_direct_mode() inside there reg_read/write functions is the right place to do that. It should be done at a higher level (in case we need to combine multiple reads/writes in an atomic operation). So I think we should drop this patch.