mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Elder <elder@linaro.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, evgreen@chromium.org,
	subashab@codeaurora.org, cpratapa@codeaurora.org,
	bjorn.andersson@linaro.org, sujitka@chromium.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net 0/5] net: ipa: minor bug fixes
Date: Thu, 29 Oct 2020 11:50:52 -0500	[thread overview]
Message-ID: <2f62dbe1-a1b3-a5f9-8cba-82cd8061ff9b@linaro.org> (raw)
In-Reply-To: <20201029091137.1ea13ecb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On 10/29/20 11:11 AM, Jakub Kicinski wrote:
> On Wed, 28 Oct 2020 14:41:43 -0500 Alex Elder wrote:
>> This series fixes several bugs.  They are minor, in that the code
>> currently works on supported platforms even without these patches
>> applied, but they're bugs nevertheless and should be fixed.
> 
> By which you mean "it seems to work just fine most of the time" or "the
> current code does not exercise this paths/functionally these bugs don't
> matter for current platforms".

The latter, although for patch 3 I'm not 100% sure.

Case by case:
Patch 1:
   It works.  I inquired what the consequence of passing this
   wrong buffer pointer was, and for the way we are using IPA
   it seems it's fine--the memory pointer we were assigning is
   not used, so it's OK.  But we're assigning the wrong pointer.
Patch 2:
   It works.  Even though the bit field is 1 bit wide (not two)
   we never actually write a value greater than 1, so we don't
   cause a problem.  But the definition is incorrect.
Patch 3:
   It works, but on the SDM845 we should be assigning the endpoints
   to use resource group 1 (they are 0 by default).  The way we
   currently use this upstream we don't have other endpoints
   competing for resources, so I think this is fine.  SC7180 we
   will assign endpoints to resource group 0, which is the default.
Patch 4:
   It works.  This is like patch 2; we define the number of these
   things incorrectly, but the way we currently use them we never
   exceed the limit in a broken way.
Patch 5:
   It works.  The maximum number of supported groups is even,
   and if a (smaller) odd number are used the remainder are
   programmed with 0, which is appropriate for undefined
   fields.

If you have any concerns about back-porting these fixes I
think I'm comfortable posting them for net-next instead.
I debated that before sending them out.  Please request that
if it's what you think would be best.

					-Alex

  reply	other threads:[~2020-10-29 16:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 19:41 Alex Elder
2020-10-28 19:41 ` [PATCH v2 net 1/5] net: ipa: assign proper packet context base Alex Elder
2020-10-28 19:41 ` [PATCH v2 net 2/5] net: ipa: fix resource group field mask definition Alex Elder
2020-10-28 19:41 ` [PATCH v2 net 3/5] net: ipa: assign endpoint to a resource group Alex Elder
2020-10-28 19:41 ` [PATCH v2 net 4/5] net: ipa: distinguish between resource group types Alex Elder
2020-10-28 19:41 ` [PATCH v2 net 5/5] net: ipa: avoid going past end of resource group array Alex Elder
2020-10-28 20:37   ` Willem de Bruijn
2020-10-29 16:11 ` [PATCH v2 net 0/5] net: ipa: minor bug fixes Jakub Kicinski
2020-10-29 16:50   ` Alex Elder [this message]
2020-10-31  0:23     ` Jakub Kicinski
2020-10-31 12:57       ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f62dbe1-a1b3-a5f9-8cba-82cd8061ff9b@linaro.org \
    --to=elder@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=cpratapa@codeaurora.org \
    --cc=davem@davemloft.net \
    --cc=evgreen@chromium.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=subashab@codeaurora.org \
    --cc=sujitka@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®