From: <Parthiban.Veerasooran@microchip.com>
To: <kuba@kernel.org>
Cc: <piergiorgio.beruto@gmail.com>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <andrew@lunn.ch>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<Horatiu.Vultur@microchip.com>, <Woojung.Huh@microchip.com>,
<Nicolas.Ferre@microchip.com>,
<Thorsten.Kummermehr@microchip.com>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net v2] ethtool: plca: fix plca enable data type while parsing the value
Date: Fri, 8 Sep 2023 04:35:38 +0000 [thread overview]
Message-ID: <2f6a8641-7151-368a-7529-721209c8af49@microchip.com> (raw)
In-Reply-To: <20230907204450.6b9e63df@kernel.org>
Hi Jakub,
On 08/09/23 9:14 am, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Fri, 8 Sep 2023 19:33:46 +0530 Parthiban Veerasooran wrote:
>> The ETHTOOL_A_PLCA_ENABLED data type is u8. But while parsing the
>> value from the attribute, nla_get_u32() is used in the plca_update_sint()
>> function instead of nla_get_u8(). So plca_cfg.enabled variable is updated
>> with some garbage value instead of 0 or 1 and always enables plca even
>> though plca is disabled through ethtool application. This bug has been
>> fixed by parsing the values based on the attributes type in the policy.
>>
>> Fixes: 8580e16c28f3 ("net/ethtool: add netlink interface for the PLCA RS")
>> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
>
> One second look you need to fix the date on your system and resend.
> The patch came to us with a date 24h in the future it will confuse
> patchwork.
Sorry, by mistake the date has been set one day ahead. I will correct it
and resend the patch now.
Best Regards,
Parthiban V
>
next prev parent reply other threads:[~2023-09-08 4:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 14:03 Parthiban Veerasooran
2023-09-07 17:11 ` Jakub Kicinski
2023-09-08 3:44 ` Jakub Kicinski
2023-09-08 4:35 ` Parthiban.Veerasooran [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-09-08 4:45 Parthiban Veerasooran
2023-09-12 12:07 ` Andrew Lunn
2023-10-03 14:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f6a8641-7151-368a-7529-721209c8af49@microchip.com \
--to=parthiban.veerasooran@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Thorsten.Kummermehr@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®