From: Paulo Alcantara <pc@manguebit.com>
To: Scott Mayhew <smayhew@redhat.com>,
Steve French <sfrench@samba.org>,
Ronnie Sahlberg <lsahlber@redhat.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>
Cc: Steve French <stfrench@microsoft.com>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, Scott Mayhew <smayhew@redhat.com>
Subject: Re: [PATCH] smb: client: fix null auth
Date: Tue, 15 Aug 2023 15:40:31 -0300 [thread overview]
Message-ID: <2f7522c01a45f9052f423869040258ba.pc@manguebit.com> (raw)
In-Reply-To: <20230815-fix-cifs-null-auth-v1-1-3cb785216d97@redhat.com>
Scott Mayhew <smayhew@redhat.com> writes:
> Commit abdb1742a312 removed code that clears ctx->username when
> sec=none, so attempting to mount with '-o sec=none' now fails with
> -EACCES. Fix it by adding that logic to the parsing of the 'sec'
> option, as well as checking if the mount is using null auth before
> setting the username when parsing the 'user' option.
>
> Fixes: abdb1742a312 ("cifs: get rid of mount options string parsing")
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> ---
> fs/smb/client/fs_context.c | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
next prev parent reply other threads:[~2023-08-15 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 17:49 Scott Mayhew
2023-08-15 18:40 ` Paulo Alcantara [this message]
2023-08-16 5:28 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f7522c01a45f9052f423869040258ba.pc@manguebit.com \
--to=pc@manguebit.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=smayhew@redhat.com \
--cc=sprasad@microsoft.com \
--cc=stfrench@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®