From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794515762; b=Lpsq0RV7hs5JoLkeDVLO7ZHvBT/1HZBqkjRT8FqL4nG5J5sbBDip2YsEQG19rHaaCUvz +XMXEuvxvXLM7xeyqtSJNZSi3lmVDk+hVhljQn1/ZCXpP+eZkAhe32rqu9TUpROR/d4h6 ICWPqvophRIPK7Ye4k6HzS1KMmxighaOQeBP6VojWmCf7E+QgN48nMw2db49EELW/7/uL m+iOP8jV/7uo2OCNvZrvlM+fvxoFUTjjwiJcw4IB16R+Nqc21j+SyZ/5D3N+9QH+D0ttl ixLtUgdRRdYJFUUKAl8nGrL6OZ0bv8yKZ89vwpoaMQrLin4c+iGG5WlEH14M/hISkJg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794515762; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:Received:Date:From:To:cc:Subject: In-Reply-To:Message-ID:References:MIME-Version:Content-Type: X-Scanned-By; bh=eZWosmTB2z09pzY3l2Lg25u9IuMg+1eDSXiFcCZwwKE=; b=dBLkgouPOgPh35nlvJxEO2nTx2WAKMFSdYT6LzrtQm6b6ee+PGo4JWUK5I2JGzf2TB+1 ZKZhPM6vg8JJzzg8BI7ukbCy+OdiX6QGsPqHQIUkTMK2VWwsMYnz8AePf5SRnOm6bVijR lpEiF6dj9rjWaBFRCZqSHpA3hh0lSnrCev8h5/a1LYO3h4dLDKHTsFMGDTqrXkl3GQ4Fv UzIUQH/GA999JbLIYBnL0HPpt/B568XondAw14bgmFzZoKcDD0dasKN27rhXOdlaQgqOY glxyEiK476KAmygtbR2fZMfodwwuzHMSoPCnKywdSV/TnyyPTTR3qIVrXPejF9LPANg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IXCfIhqr; arc=none smtp.remote-ip=170.10.129.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC1BD606A327 for ; Thu, 12 Nov 2026 20:36:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org EC1BD606A327 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IXCfIhqr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794515760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eZWosmTB2z09pzY3l2Lg25u9IuMg+1eDSXiFcCZwwKE=; b=IXCfIhqrxfS1aHkHB+j3MrdJ3TNV3WNdkbMx5OUsUql4iLERHQFbl05vCd8wkFXsr7PCsv bQkqv8haTHzK1sHuKWmdbBHgOTxP5k7jHkzHYUs7XrfqkM7MZP+vaiTShxSi73bG7x79D4 qwPDGF3I3xFdKM5dnIPyPFAtd+kQ1Ys= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-325-2-SFs9fUMcGyqhnckK5WRg-1; Thu, 12 Nov 2026 15:35:57 -0500 X-MC-Unique: 2-SFs9fUMcGyqhnckK5WRg-1 X-Mimecast-MFC-AGG-ID: 2-SFs9fUMcGyqhnckK5WRg_1794515756 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 344011956059; Thu, 12 Nov 2026 20:35:56 +0000 (UTC) Received: from mpatocka-thinkpadx1carbongen12.rmtcz.csb (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2416118004F5; Thu, 12 Nov 2026 20:35:52 +0000 (UTC) Date: Thu, 12 Nov 2026 21:35:50 +0100 (CET) From: Mikulas Patocka To: Li Youhong cc: agk@redhat.com, snitzer@kernel.org, bmarzins@redhat.com, yukuai@fygo.io, dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Li Youhong , stable@vger.kernel.org Subject: Re: [PATCH] dm-raid: fix use-after-free in raid_dtr() In-Reply-To: <20261112091206.1656622-1-dayou5941@163.com> Message-ID: <2f7691db-0f26-bc0a-886e-2f97c2805bde@redhat.com> References: <20261112091206.1656622-1-dayou5941@163.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 OK. I applied the patch, thanks. Mikulas On Thu, 12 Nov 2026, Li Youhong wrote: > From: Li Youhong > > raid_dtr() currently flushes event_work only if work_pending() is true. > This is insufficient because once a worker has dequeued the work, the > PENDING bit is cleared while do_table_event() is still running. In that > window raid_set_free() can free the raid_set, leading to a > use-after-free when do_table_event() accesses rs->ti->table. > > Flush event_work whenever it has been initialized, so raid_set is not > freed while the event handler is still running. The .func guard skips the > flush for mddev instances where INIT_WORK has not run yet. > > Fixes: db29d79b34d9 ("dm-raid: delay flushing event_work() after reconfig_mutex is released") > Cc: stable@vger.kernel.org > Signed-off-by: Li Youhong > --- > v2: > - Fix incorrect Fixes tag; the work_pending() check in raid_dtr() was > introduced by db29d79b34d9, not a17d1bca5aba. > - v1: https://lore.kernel.org/all/20261112075741.1449168-1-dayou5941@163.com/ > > drivers/md/dm-raid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c > index ac019a0f5a92..c1f546e8c65d 100644 > --- a/drivers/md/dm-raid.c > +++ b/drivers/md/dm-raid.c > @@ -3340,7 +3340,7 @@ static void raid_dtr(struct dm_target *ti) > rs->md.dm_gendisk = NULL; > mddev_unlock(&rs->md); > > - if (work_pending(&rs->md.event_work)) > + if (rs->md.event_work.func) > flush_work(&rs->md.event_work); > raid_set_free(rs); > } > > -- > 2.25.1 >