From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763101AbcISMHE (ORCPT ); Mon, 19 Sep 2016 08:07:04 -0400 Received: from mail-db5eur01on0103.outbound.protection.outlook.com ([104.47.2.103]:20736 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755792AbcISMGy (ORCPT ); Mon, 19 Sep 2016 08:06:54 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dsafonov@virtuozzo.com; Subject: Re: [PATCH] x86/vdso: Add ARCH_MAP_VDSO_X32 if CONFIG_X86_X32_ABI. To: Vinson Lee , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , , Andy Lutomirski , Borislav Petkov , Dmitry Vyukov , Brian Gerst References: <1474073513-6656-1-git-send-email-vlee@freedesktop.org> CC: From: Dmitry Safonov Message-ID: <2f791b53-1216-7b96-11a6-66dcb8961605@virtuozzo.com> Date: Mon, 19 Sep 2016 14:33:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474073513-6656-1-git-send-email-vlee@freedesktop.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: VI1PR07CA0049.eurprd07.prod.outlook.com (10.164.94.145) To DB6PR0801MB1733.eurprd08.prod.outlook.com (10.169.226.148) X-MS-Office365-Filtering-Correlation-Id: 1035e4e3-dc6b-4fe7-f403-08d3e08107ac X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1733;2:NHld0aEW2DyEG+rtVMJY1HQUZQcNuohBNs16v023vLY4zz70kuNUw7nLdxLrG9dLirHSStU6CMpGG0V9vaVdZd1fpeJp/2b6ksSvtyuDWil/1wXsZUg8rdhIVVlOylx6jfbwuq7+3uYG4AhA3+0IoqKmrSs0DJbsCKoBY/YfkumK8ZBV8axtkT8BtwbrnbY4;3:+QxygXAkw1tnYpZE8CphvATSYOqB4ubFk7j9aREeBzhnkXtHJNs+Ydz8PAi5FIXWLvMQYy+PD0ylA3/PJlZ6AENv5zag9Lq9c4S4/6gy3vVrAGlC/VpEK3NtInML6A76;25:FZjDYlbnwTOUeZ6B7zW9G86nFPOe8x73c0iD2jC+ba/JmYApw0KwjxP5iKR6we54KkC0A6jT+ROoh/hnheEsrozdhmvLcOQ12AUbGzd0pTYdwvT95cgo9P3+PXd+LfkYEOQk6zisczbfgzPZKqzt91T53G3xaZLFgfwwcMegMVF78+4TnX7UMs0f4BAV6U6m6LgZEv767OHBUYsC4Cgs23IMeUzoxbBzfueY/Gdfx2AGsVUK2zXkz+SWv4z3SZUO+lKw2jrJBkSBMc90uQxM6iZge0CO61Uvg6m/MrfmgA2LB/LVaBIbwvQP4CqtKkI89e4bhIwyIaHk8gaD22Y/+HjJ9Vhy/jTK9pMfxWBBewjQH1vITcWjmn/mDZsgq/Y5OICCzyW4ev9Zy4N8WDFOr8M+tx1q9Jm5iuAiN+9pKnc= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB1733; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1733;31:yFdcsq0EM5B8Yg6uNq6zzdkBKKPK+WhEG4qHiZ0mZcgYxZkAdZ+do46f7T5M/L9HKgCndn+HFZq6eSRgw6WCK+kvupOVJpktEhZZp7wBT6XGVPP3f+GqfawORPjdR4Uu9ZitWgVTAvbMeWEU85mTu2jEWkLg6+J86Q/5YcylHdLhHTfnzPjGy64qFKqgkbVxmlRQTGOOac/psCHvrnCYiFDKIldkFO/O2qv28hkWlIw=;4:NRwBLkHTgrlv0rqdtUGum/1qV8CCc3aNAwokiSe8kh3Ye7IvQRVH0Ze1yj5Mb/o2CVBgWTyhqPSCkxouJMLkXO0nPZ37NwwN0o0C/v0+jp8K1/QrMQ8SSqRMT5Wf8U6AXbeDujlgYYhersR7l2g64ZJF5IyyJgaKCBeh+eKvVHykk21A4WyJm6BMQiZFqiWjLaVGtJyQ4Ug6dvhG+ByTJL2DtfayMwinoEDAX4OTiH9+6m8z27WwHsjF+Qac9rg1r9uYP1B/3ibSiL7icmHTkOdRONzLF7DVHN6Vz2kFv9JVVtdZvEjPosG9+HtE7gytVudvXtX3XJT4kPYyxjzpbqH7ESRlNN2WLRmGfnthiZEWEYsMsL4UvxRXYAN5vS/tBQ6d5pBxuRRxHgavGOVe/xYw0Z80YsQ6xvkldZih6Tk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6042046)(6043046);SRVR:DB6PR0801MB1733;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB1733; X-Forefront-PRVS: 0070A8666B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(189002)(377454003)(199003)(24454002)(92566002)(81156014)(81166006)(19580405001)(19580395003)(8676002)(31686004)(42186005)(105586002)(106356001)(31696002)(68736007)(5660300001)(65826007)(7736002)(7846002)(305945005)(7416002)(36756003)(6116002)(3846002)(586003)(230700001)(33646002)(2906002)(4326007)(77096005)(97736004)(5001770100001)(189998001)(4001350100001)(23746002)(2950100001)(65806001)(65956001)(66066001)(47776003)(101416001)(86362001)(50466002)(50986999)(83506001)(64126003)(76176999)(54356999)(15760500001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0801MB1733;H:[10.30.26.154];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB6PR0801MB1733;23:baWSwNADpDJOAt5cQoDOK8t9L9sJk7xNuba?= =?Windows-1252?Q?HBVWMMnZzoPgLDreGGvnRnoaS2ajdMmS9aOCMo7xF20+ZjDPMQnbjrVC?= =?Windows-1252?Q?Z1eY+gqcEWWugbGmOJblAGmsE0X2PoB3Zn2wgTcOMAKmb+Cryke+0vRJ?= =?Windows-1252?Q?1qnjaC1tf/Ug8V7JupHFFJv50gT2tWOuKMaCP9iIx20mqta70B704oh5?= =?Windows-1252?Q?6CHnIbJ2yV1c+JRU1o24QGlhVS11gmPocp9A/z6HLjZpYzo4f/vobxfq?= =?Windows-1252?Q?+8wUvk8kuzblUAR7FDu+R27O46YeBw6DqHW9e7yGgipssDfTl301XfUh?= =?Windows-1252?Q?uQ36IJl2rz4EdLgO7s0+6MG1KEbcP7d8Vmy3V4UBBG8F7rfldgXWrW1C?= =?Windows-1252?Q?7NlbAR3EgV8JyGp1/NilnuAJ5xw8uXGOHT2UhnkMo9C2AJgUeAIWNVM+?= =?Windows-1252?Q?q0/YpOEqKM6cmjZsGR2RGprulFg6oHtS2KtD83oNAoga+fkARFp/cbCu?= =?Windows-1252?Q?G6lfgKQg7pbcx5W9T7A6IEslMwSL1LVd4zfXAcPTly8+m08b2rq53yIb?= =?Windows-1252?Q?t86uhdi9sS1p9H3+xKcRYp92Wj9jWXUVEOK8zt2F4nsxlICSn7W2Ks3f?= =?Windows-1252?Q?0FsYzVdf98tWcC1n9KZwl0hQq4dDXlTfp+jdqqHwThwb+ZUhzosLYzkl?= =?Windows-1252?Q?o1AVeuqPjn9Dg2ITy6GNupX8hptt29drK027+BBU3PtcCt7rntyQy8ay?= =?Windows-1252?Q?Lght7R3zLgfU24LTeVS8d0MGJkDsNbjSdYfbaoTHAZ8sdqKGWBke+zB0?= =?Windows-1252?Q?LbKhFRcXrs/SL1Rkz+TBCPEyz4NziitGeH/To5Je0NTtyZYHnsFM9JQh?= =?Windows-1252?Q?O2VVPr1oYexAFucE6yB5p8re3AGKxpYgo7B0Nti2KA/qcRJ3DFtuG1lL?= =?Windows-1252?Q?agl7gNajNi6P6F6EkTbN5CFqalwkn3qbg5gKAFZ7ltCjNJijFBT0W48x?= =?Windows-1252?Q?qIcSNCVghNH12Xd+nVlMpZP7nd+sQFPATl3qHF3//bZEyAlpKO30/hUm?= =?Windows-1252?Q?QvNawtAmHZC4f0bAQPBigf2vWduwrdqIHzgfaw/ltCVyaMhmJo/+HMVo?= =?Windows-1252?Q?ex1ZBkxNySt0pFKQN90m/dWSGlXKNQU1B5vb/0k5COct+vYv9o238nzT?= =?Windows-1252?Q?Yrf3Zyq+430pfQLGJBUmQijW+LxUvavX4XGL3QNjlIgq3S72VT3UWUct?= =?Windows-1252?Q?rV8ByHi9OjISHEr7bHlQY4tMEmGMxRcj88W57T9KHnbSGPzocGQoO+On?= =?Windows-1252?Q?YMmRdBCPJbYg7jyAPGSn4FkfeZ6fdNhSOD0lPpBbd/pih4GvmSb5Tdut?= =?Windows-1252?Q?Hky0nDQzxX0zHkOAD4i/Nz2qoIN+4IGjaYdTdpQFZe+A2up4HMPUvyFb?= =?Windows-1252?Q?OJ2mswQaMoKZ4IbB2eEzXwLEMPgORWQJn5SkpRWacNA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1733;6:kRWiRPOFhLO1/E+k087v1MCs2s3jNN1jPv08WOMbzZSwJV8taNPQ252JqRB+LBlDqdUyF/Hgcabbyd6Y9Qtk7RN4WhA/gP8Gw+Cj6d7421SZ5Ml8OJk4GOoClrVGzZ8tFcR/Lu2kAl5H2L448acKRS4cAWHgcjoNuJVbF/HQ9PRKlS6HtHUlmf7xzKcY1vWnfiKhRbYtPa1tGAjK785gVx39WcRFb1FhTWO2CLEq8i3nGP8SiR0V4O9ggdP4MXxZovlheZydaXEnRCPHtpWZiPCdITwF3yD7lPN9nl1Gb7KepDFVyHNyAGuEiOP7Axci;5:IDd+/KVNOAz95eF2NRh+NovWGNWZ6cMen1moNeOEyrFAT+dKd/+pMZM45pb2MCPsOoul7HGGPgxyD81SrONvi6tMsnIcQPI3ktc6FDCb6xu72auPxGNxVfXZC0q73QZeSPxnDnD+fX5l7Mu9lw515Q==;24:KUjnQ175Li6f0qwDjFz59B2qKTTX7U8DaQHj4ZCtGlY29LFhhRnOxbDbxmmA9otrG4neLauDTzwweIRVIlz+KOOA7t141DqKFJKeHN4rNks=;7:SdFpcBx+Yhcfu8sIjflIfomCzzBQyVR1MSHa5iiIr03QUPgbzZPY/KqiFFH8k1mWnKXwrxJWIEyI+QtrYWkrkfg2QmcBfJC4UCz/SSlu6BFJmFyKhufOCBdBa8tf922/2zPS+g+lSJV6TApfNrLPZEKX8ry7cjVwZLzC+0LNwWk+282qGjYpNaD/HcW3p5xeVY9ImCNrDS5Zd1mxi7WJJQ30578PmN+rV10qn1Oa+1E4vd4wVrNCW77uK+MjtQUwJfq/IIvSKlU3dA+CJbCHl/p4WNjCjujRyYrK4fUmMgUBPYQcWSubUrZ/IlDv40ia SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1733;20:LyIKCQcCAQwjnTmjscTtKB6PpX4kZzjTzGOoswWC76kplxyHNtKcMXbfdcemyizIxOkRST3TjWWDhy5oy5rPVjacAdm2QhBq3XU4lF2L0qmTcqLTACPq8ASg9J61uhc2jG0doZua87rIF9lyyIh6VrWKpYnncgbKV+6Y/MAmXFY= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2016 11:35:15.9958 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1733 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/17/2016 03:51 AM, Vinson Lee wrote: > vdso_image_x32 is generated if CONFIG_X86_X32_ABI. > > This patch fixes this build error on CentOS 6.8 with gcc 4.4. > > LD init/built-in.o > arch/x86/built-in.o: In function `do_arch_prctl': > (.text+0x27466): undefined reference to `vdso_image_x32' > arch/x86/built-in.o: In function `do_arch_prctl': > (.text+0x27477): undefined reference to `vdso_image_x32' > > Fixes: 2eefd8789698 ("x86/arch_prctl/vdso: Add ARCH_MAP_VDSO_*") > Signed-off-by: Vinson Lee Thanks! Reviewed-by: Dmitry Safonov Ifdeffery in arch/x86/include/asm/vdso.h dazzled my eyes. -- Dmitry