From: Andrew Lunn <andrew@lunn.ch>
To: Elad Nachman <enachman@marvell.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com, pali@kernel.org,
mrkiko.rs@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, cyuval@marvell.com
Subject: Re: [PATCH v3 1/3] arm64: dts: cn913x: add device trees for COM Express boards
Date: Thu, 26 Oct 2023 19:32:00 +0200 [thread overview]
Message-ID: <2f7ab700-cd87-42f2-870d-950a4c75b17d@lunn.ch> (raw)
In-Reply-To: <20231026084735.3595944-2-enachman@marvell.com>
> +#include "cn9131-db-comexpress.dtsi"
> +
> +/ {
> + model = "Marvell Armada AC5X RD COM EXPRESS type 7 carrier board";
> + compatible = "marvell,ac5x_rd_carrier", "marvell,cn9131", "marvell,cn9130",
> + "marvell,armada-ap807-quad", "marvell,armada-ap807";
This is really a question to the DT Maintainers. This is a carrier
board for a standardised Com express type 7 board. In theory, you
should be able to plug any Com Express module into it, not just
Marvells. So should the compatible list just have a compatible for the
carrier itself? Not the module which would normally be mounted in it?
Should the carrier have a .dtsi file describing it? And then we have a
.dts file which combines the module .dtsi and the carrier .dtsi?
Sorry i did not ask this earlier, i was thinking more about SolidRuns
systems, which tend to have custom SOMs and customs carriers, so you
can only really mount one particular SOM into one particular
carrier. But that is not true here.
Andrew
next prev parent reply other threads:[~2023-10-26 17:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 8:47 [PATCH v3 0/3] " Elad Nachman
2023-10-26 8:47 ` [PATCH v3 1/3] " Elad Nachman
2023-10-26 17:32 ` Andrew Lunn [this message]
2023-10-27 11:12 ` Krzysztof Kozlowski
2023-10-26 8:47 ` [PATCH v3 2/3] dt-bindings: arm64: dts: add dt-bindings for ac5x rd carrier Elad Nachman
2023-10-26 14:08 ` Conor Dooley
2023-10-26 17:44 ` Andrew Lunn
2023-10-27 11:09 ` Krzysztof Kozlowski
2023-10-27 11:15 ` Krzysztof Kozlowski
2023-10-26 8:47 ` [PATCH v3 3/3] MAINTAINERS: add ac5 to list of maintained Marvell dts files Elad Nachman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f7ab700-cd87-42f2-870d-950a4c75b17d@lunn.ch \
--to=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=cyuval@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=enachman@marvell.com \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mrkiko.rs@gmail.com \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®