From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934684AbdAKAeU (ORCPT ); Tue, 10 Jan 2017 19:34:20 -0500 Received: from ale.deltatee.com ([207.54.116.67]:48847 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932375AbdAKAeP (ORCPT ); Tue, 10 Jan 2017 19:34:15 -0500 To: Xiangliang Yu , Jon Mason , Dave Jiang , Allen Hubbe , Joe Perches References: <1484094731-15965-1-git-send-email-logang@deltatee.com> Cc: Greg Kroah-Hartman , linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org From: Logan Gunthorpe Message-ID: <2f7c2161-5e5b-13b7-4970-4c9c25f0e0c9@deltatee.com> Date: Tue, 10 Jan 2017 17:34:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.1 MIME-Version: 1.0 In-Reply-To: <1484094731-15965-1-git-send-email-logang@deltatee.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.111 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com, gregkh@linuxfoundation.org, joe@perches.com, Allen.Hubbe@emc.com, dave.jiang@intel.com, jdmason@kudzu.us, Xiangliang.Yu@amd.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH 0/2] Style fixes: open code obfuscating macros X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry, sorry. I resent the wrong set :( Logan On 10/01/17 05:32 PM, Logan Gunthorpe wrote: > Hi, > > I had copied some poor code style from the NTB drivers into an unrelated > driver. Upon review of my new code, I learned it was not a good idea > to sweep dirty things under the rug^W macro. See [1], where Gregg k-h > suggested I fix the problem at the source. > > Thus, please merge the following two patches to improve the style of > the NTB drivers. > > Thanks, > > Logan > > [1] http://www.spinics.net/lists/linux-pci/msg56904.html > > > Logan Gunthorpe (2): > ntb_hw_amd: Style fixes: open code macros that just obfuscate code > ntb_hw_intel: Style fixes: open code macros that just obfuscate code > > drivers/ntb/hw/amd/ntb_hw_amd.c | 59 ++++++++------- > drivers/ntb/hw/amd/ntb_hw_amd.h | 3 - > drivers/ntb/hw/intel/ntb_hw_intel.c | 145 ++++++++++++++++++------------------ > drivers/ntb/hw/intel/ntb_hw_intel.h | 3 - > 4 files changed, 104 insertions(+), 106 deletions(-) > > -- > 2.1.4 >