From: Krzysztof Kozlowski <krzk@kernel.org>
To: Josh Law <objecting@objecting.org>,
akpm@linux-foundation.org, pmladek@suse.com, rostedt@goodmis.org
Cc: andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk,
senozhatsky@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] lib/vsprintf: always advance args in bstr_printf() pointer path
Date: Tue, 31 Mar 2026 09:26:46 +0200 [thread overview]
Message-ID: <2f824be3-7b30-41c6-b517-de1086624171@kernel.org> (raw)
In-Reply-To: <20260330193440.74268-2-objecting@objecting.org>
On 30/03/2026 21:34, Josh Law wrote:
> When the output buffer is full (str >= end), bstr_printf() skips
> advancing the args pointer past the pre-rendered pointer string in
> bin_buf. This causes all subsequent format specifiers to read from
> the wrong position, corrupting the rest of the output.
>
> Always compute the string length and advance args regardless of
> whether there is space to copy into the output buffer.
>
> Signed-off-by: Josh Law <objecting@objecting.org>
NAK
Questionably origin (multiple identities used), questionable content.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-31 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 19:34 [PATCH v2 0/2] lib/vsprintf: pointer handling fixes for bstr_printf() and vbin_printf() Josh Law
2026-03-30 19:34 ` [PATCH v2 1/2] lib/vsprintf: always advance args in bstr_printf() pointer path Josh Law
2026-03-31 7:26 ` Krzysztof Kozlowski [this message]
2026-03-31 14:47 ` Steven Rostedt
2026-04-02 3:47 ` Kuan-Wei Chiu
2026-04-02 8:03 ` Josh Law
2026-04-02 13:34 ` Steven Rostedt
2026-03-30 19:34 ` [PATCH v2 2/2] lib/vsprintf: fix OOB write in vbin_printf() when size is zero Josh Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f824be3-7b30-41c6-b517-de1086624171@kernel.org \
--to=krzk@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=objecting@objecting.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome