From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753974AbdLHPjc (ORCPT ); Fri, 8 Dec 2017 10:39:32 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:27824 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754305AbdLHPj0 (ORCPT ); Fri, 8 Dec 2017 10:39:26 -0500 Subject: Re: [PATCH v1 1/6] ARM: davinci: clean up map_io functions To: David Lechner , CC: Kevin Hilman , References: <1512182054-17410-1-git-send-email-david@lechnology.com> <1512182054-17410-2-git-send-email-david@lechnology.com> From: Sekhar Nori Message-ID: <2f847539-0425-5d26-a48c-537ed32940ca@ti.com> Date: Fri, 8 Dec 2017 21:08:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1512182054-17410-2-git-send-email-david@lechnology.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 02 December 2017 08:04 AM, David Lechner wrote: > static int dm355leopard_mmc_get_cd(int module) > { > if (!gpio_is_valid(leopard_mmc_gpio)) > @@ -269,7 +264,7 @@ static __init void dm355_leopard_init(void) > > MACHINE_START(DM355_LEOPARD, "DaVinci DM355 leopard") > .atag_offset = 0x100, > - .map_io = dm355_leopard_map_io, > + .map_io = dm355_map_io, > .init_irq = davinci_irq_init, > .init_time = davinci_timer_init, > .init_machine = dm355_leopard_init, It seems like spaces were used in original code for indentation. Can you please introduce a patch to fix that first since you are now touching this part of the code? Thanks, Sekhar