From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Cc: Ezequiel Garcia <ezequiel@collabora.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: Re: [PATCH 0/3] HDR10 static metadata
Date: Mon, 09 Nov 2020 14:53:55 -0500 [thread overview]
Message-ID: <2f907743dbb77f4c2f871675070065dd372514be.camel@collabora.com> (raw)
In-Reply-To: <20201109173153.23720-1-stanimir.varbanov@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]
Le lundi 09 novembre 2020 à 19:31 +0200, Stanimir Varbanov a écrit :
> Hello,
>
> This patchset adds two HDR10 HEVC v4l2 controls for Content Light Level
> and Mastering display colour volume plus implenmentation in Venus encoder
> driver.
>
> Comments are welcome!
It is not a formal review, but I did walked through the new API and
everything looks fine to me. One question though, are you aware that
the H.264/AVC equivalent is identical ? What is you plan for that ?
>
> regards,
> Stan
>
> Stanimir Varbanov (3):
> v4l: Add HDR10 HEVC static metadata controls
> docs: media: Document CLL and Mastering display
> venus: venc: Add support for CLL and Mastering display controls
>
> .../media/v4l/ext-ctrls-codec.rst | 61 +++++++++++++++++++
> drivers/media/platform/qcom/venus/core.h | 3 +
> drivers/media/platform/qcom/venus/hfi_cmds.c | 8 +++
> .../media/platform/qcom/venus/hfi_helper.h | 20 ++++++
> drivers/media/platform/qcom/venus/venc.c | 29 +++++++++
> .../media/platform/qcom/venus/venc_ctrls.c | 16 ++++-
> drivers/media/v4l2-core/v4l2-ctrls.c | 61 +++++++++++++++++++
> include/media/hevc-ctrls.h | 41 +++++++++++++
> include/media/v4l2-ctrls.h | 2 +
> 9 files changed, 240 insertions(+), 1 deletion(-)
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2020-11-09 19:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 17:31 Stanimir Varbanov
2020-11-09 17:31 ` [PATCH 1/3] v4l: Add HDR10 HEVC static metadata controls Stanimir Varbanov
2020-11-10 9:43 ` Hans Verkuil
2020-11-10 10:13 ` Stanimir Varbanov
2020-11-09 17:31 ` [PATCH 2/3] docs: media: Document CLL and Mastering display Stanimir Varbanov
2020-11-10 9:50 ` Hans Verkuil
2020-11-10 10:28 ` Stanimir Varbanov
2020-11-09 17:31 ` [PATCH 3/3] venus: venc: Add support for CLL and Mastering display controls Stanimir Varbanov
2020-11-09 19:53 ` Nicolas Dufresne [this message]
2020-11-09 23:44 ` [PATCH 0/3] HDR10 static metadata Stanimir Varbanov
2020-11-10 9:38 ` Hans Verkuil
2020-11-10 9:41 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f907743dbb77f4c2f871675070065dd372514be.camel@collabora.com \
--to=nicolas.dufresne@collabora.com \
--cc=ezequiel@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®