From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013018.outbound.protection.outlook.com [40.93.196.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04A7B2D46B3 for ; Mon, 13 Jul 2026 20:06:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.18 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783973172; cv=fail; b=dlKlxm/cH5w2NL2c7VzPqVqoZdPOw9ZiQLL7iQVk9lKPTJJYineap2eCS8pdtjDZrimZLPhhNcn25Xz+MCfWGBihQ21+DytBxT8ScQqos1ZIsGEKyzo7qEL0gLvStx3XQfhgl7aIJKymi3bgLriR4yaYsVtH/4Tx07FGypMix6A= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783973172; c=relaxed/simple; bh=/zCAS/hOVYiNYPEK3O8iZY4KXTlLZmegR0YXE+X/inM=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=AccHVAaC2VmIhQlERglgDxBPj5GYc8tHrDp4TQgXeezihXZnXHGkzmlmD5bbPeitcsQ3QoO5Q9/ZjCSaf3caIO2vI4i7Z+CfHheiPH+TCZ3BhL/ELYKgOknD7blwdlKQ8BLjTgT2tecGdtVKRFNJzz/+pDYJaBWww/zA6b22CFE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ecDW9i3s; arc=fail smtp.client-ip=40.93.196.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ecDW9i3s" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RtK7ZmQIP2qQ3w21I3oDcXztJj+UlRRDMtGviF+ZSkp8euq70MwV75juUNkS/V8gmS1DS942Dtyp8Nnf16S1Uvodd7lG7mk48Vd0KIfpne+UKCuiGanYZ0/wJ69PkswAwJls7vBOclAqSthrh6OnxXuEUEfv1p8X/VnW6QQiYqd/F6Fp+t8jQt1Gcrv2ir+I3SmmCIO/VD8Jho3v83Ehg5ZcWTgWcANeGDej5K59H53KSqX3zPsdZcT7owSaXT638jWBVgTPx6OCvf7+gsfP9PU70QvPL7yTxqeuUjRLAqipIs2LrGsjd+zi+ZHzNLw6YtQiqXTHUsgYonerFFLyTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CvtFaoklJHZcO7xD9NbgTPWTQmEla24kl7d1kBmeS/0=; b=QWAieqy6L0p8834O5MGtwe3pLRG7311U/p9JHXCxQ+vn9SAzN59cRlwnBQ+7rnqDZ3geraqeP2O2qNiR7+Lootw+CZ9wvomNUJtzBMc/SzLC9fnjPgfBtn01yrmA8EkQ7a2E8vE3j8OurwAd4wSzoDF8Xv6jjPWZt7RPrjNljgbgVqBaPFK4igMjACpoe6u/0/zpLfTwuKwFld+RcxeWpbH6822gRjHVTww/CMSrOx6oZ8ZN3fqbyymRCwppmy7ggDgd/bcKvTY7APQZN9HAo1Xi3eHYdTStsfsRB4XGRl4VuUODxnPxUUErRDYlfmiipQWZUehKZBR5z7OxfwIAcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CvtFaoklJHZcO7xD9NbgTPWTQmEla24kl7d1kBmeS/0=; b=ecDW9i3sSn5WbI+kYF/uQd5Lf898GHmar+kYLcSuM40uV8Fmj/txEaCwjYj0RxwwGOrxXl0QWK6gDU3j3zZVVHsjScznd4B0AqChVq28bIBa73Jp0HtU4lJhZHED5++T7Ns3vTBtN/1C7Zu+coeVA3mOOPKZenM3gMYeyHSEr/Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ0PR12MB7007.namprd12.prod.outlook.com (2603:10b6:a03:486::8) by SN7PR12MB7348.namprd12.prod.outlook.com (2603:10b6:806:29b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 20:06:03 +0000 Received: from SJ0PR12MB7007.namprd12.prod.outlook.com ([fe80::6f95:c4a2:894d:9e8a]) by SJ0PR12MB7007.namprd12.prod.outlook.com ([fe80::6f95:c4a2:894d:9e8a%5]) with mapi id 15.21.0181.019; Mon, 13 Jul 2026 20:06:02 +0000 Message-ID: <2fa23cb1-b4c9-459b-a0dc-31960313a243@amd.com> Date: Mon, 13 Jul 2026 16:05:51 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] drm: Guard DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE To: Maarten Lankhorst , Robert Mader , "Borah, Chaitanya Kumar" , dri-devel@lists.freedesktop.org Cc: Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Daniel Stone , Uma Shankar , Louis Chauvet , Melissa Wen , Simon Ser , Pekka Paalanen , Leandro Ribeiro References: <20260703073230.19982-1-robert.mader@collabora.com> <6d8806b8-fc71-4699-82c4-7189a0ea2284@intel.com> <7d58b289-eabe-4d68-9080-c7202b0f60a0@intel.com> <361dfc91-94e8-4289-9b3e-5280803d9257@collabora.com> Content-Language: en-US From: Harry Wentland In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YT4PR01CA0375.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:fd::10) To SJ0PR12MB7007.namprd12.prod.outlook.com (2603:10b6:a03:486::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR12MB7007:EE_|SN7PR12MB7348:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e6cf495-b3ff-4b51-e556-08dee11a2a24 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|23010399003|22082099003|18002099003|4143699003|11063799006|56012099006|6133799003; X-Microsoft-Antispam-Message-Info: KDmTXZrKpxJM1/ZgYCmTXOsdv8NYeCZfqvy8VMfQSxAG31Cls8vCL9D6o2im/bujVZ5xL/TzdNWCxrBjeRJ45hTK1M3u81DG9v//2DSCqC+NcdURNxrkAxkJhtGLZdZoV2/2fR1bEdwg2mWuiskr3VeLAXpSFvr1T4Bt7OTdwYStHgKOrnOES6FR43XGtnW29yOEyviQKCYBpZXsKS/IF+SH6xsUhKKbZCoGdb96Ec1F8TR9Ojs3aohh6bPpRIXY/araXEAK2opohMHkODBebNJDIuSGKfUzGYuNVe+QoJsbpGA6n6Fh5TQqm08JxapKpWgARWjYTPmq/CIjkk2woXFEhKV40QRH99ot5c98yPidxg07QJwAzj2UranrVx/mP2t552y6jTyCOUAKpsqQPgQgh6DMhkFzgyIq7TGLxy6fIA05bmIQEUCEidNO24LAKs0/ngSuHar+/rkWuXOHdJ4j7zWR0NtJxAA5y36/rhc0rO3T3OirhVOq76yb8Tbl3q5Lwns1WkKVckRAKRW4lEh0qX5pGskJnohKpmyyfV24IjUnK7zQn0PtmiG5RwFZa9Er8DHrQq0Gs1kg3P0Qnc7y4xFegUsbkplYGolUs7fx+jYB0c1oNOqFRyTFdEybPfhRItMwc9JJM+c2xxv+pGP3Q6qBZV/A6Woj+qNztlg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR12MB7007.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(23010399003)(22082099003)(18002099003)(4143699003)(11063799006)(56012099006)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWVPeFhESlR5N0x2MEc3ZHorNWYzL0RzOFZDL0pLVjZqTFI2Z0IrKzlqNGxU?= =?utf-8?B?V2RHbkFaRWh3bEdPbGYrMVJrRHBJeFB1YWZHSElZUEdJempNRGJWdkJOZ3Zw?= =?utf-8?B?N3JlbXJpenJ2eDNnR3YrZUQ4MXlZV0hjNmxFZldybzdSd3BqMFdValEySEVp?= =?utf-8?B?aFh2dDJmQyt3K3p1OEVXY1lFN3htTFB2UEVRQjBXSGNaVUI1TUl6Kzk5VnJ1?= =?utf-8?B?UFFTN2k3QjFsS2lGOVNrOEhSSW54aER0SXNvQllWMXdyL3FSVUN3UjJtQ1Jz?= =?utf-8?B?ZFIyUE1OOVN3VVFSbHR1ZEE1MndqTnZuQmk4ZFNKdVRWV1dHbnZlSjIzeFdh?= =?utf-8?B?ajhDSkdlSXMycGlWQXZ5RXEvbHpRMUpZbEhsc1NWV0dtR0QvN3NzMi9IbWdl?= =?utf-8?B?a2RraWZRN0V2UXdrV0FCN2JxejFFajhTSXVxc3lXWk1NZ3ZMeUszL0ZsVWhl?= =?utf-8?B?NTVvNTRENm40TkowT1JxUzhDNjVsNUVidmY3cmFFMkJPdjlEMWpGWW10c0wy?= =?utf-8?B?WFBpSEtWa0xIS1lIOGt0aWNXWGpLa2hrMGRndVRQK3hxSlUxazBPS3FZa210?= =?utf-8?B?TGU3bHNOaDByTDFOblVDSlVidmtHaFNCR2o5UUc1bVhZSVd1TU5qNkRVYzNi?= =?utf-8?B?dEt0dy9vRCtDRkkvTFozZEpTM0dYaUlKdFczMEljamxjN2daUDJZOGJuTlZV?= =?utf-8?B?OE44bm5FcUs5ditReXhlT2wrMG1LVCs2ZUQ5S2VBZHAxT2pXSHJtTllNc3R0?= =?utf-8?B?NXVrODdDZTZkcDVZeFN4UXcyRHlRRmgrTmF6clhXY3dnd1h3VDdFSmE3NTUr?= =?utf-8?B?dWsvUjFhNm02UUVRV0F3S3F5SDZlZDRES1I4b0RPVDlwc0ZyUUt4bUJtSW5a?= =?utf-8?B?bWlFY0FYVXUwYThRVXZBbWgwOElwSXR4OGhDbHFHc1ZUVzI4RXNyajh5ejI0?= =?utf-8?B?aVZsWjZWaFd1TUE3TGJLaHFxNDZER1YycWEvOHRaKzI0YitZM2ZZYVlHTTN4?= =?utf-8?B?czlOSEVESHo0T1JJNzd1Y215M0QxaytmR3MvSkJOVDdNdVpreHNhQ3BrMVpz?= =?utf-8?B?Yy82SkNYZzEwTUw3VDRDaExvbjZtQUFieGNwNFZ2bVJvYzZaOUZFdjBjb0dq?= =?utf-8?B?UmcrS285QkVZeUwxK0FET3dZN2toQ1E0RnJjaG52dFgrRDJ1NG13dXErRUs2?= =?utf-8?B?RWNaM2k4WnV4dFp4Skl4K1VCaTI2aFVFaGQ2QjFmN1REdW9kTms4MFRRU1JV?= =?utf-8?B?K1FDVC9aQU0vNUFVVHk5blgreGliUlp2QXkrQmZacklZSXltVE1tV3Y5R29r?= =?utf-8?B?c3Ywd3BQVHFTUGFFeHNMR1lOUTUyWVVxb2ZNZmtySm1iL2pNNkd4eHJ6d2dr?= =?utf-8?B?TzEvV3JTcnJqb0RPbFRGMVB2dDNka2orMlFaSVdsZXJYdWpUdEpRZW1mQ1pI?= =?utf-8?B?QXdYdDhvZkJVZnlCM3c4TnduYnMvZEpVd0dFVVhXYmZkS0NUOWZheGErNnFo?= =?utf-8?B?dDhOUFR4Y1BmS0tGUGJqV2h1TkZySXVjSENnS3lZZW0zem5zOGlxVkl5QWor?= =?utf-8?B?d25id1lSVmRoMklrdU02K3diQ2cyaHV0Zzc2OU9mbzRQTnFCZXI5YzdxMTRH?= =?utf-8?B?Tnc3b1J0VThyN3MrdlZlSGJmYVg3aXZvc3dFNVA4Zk5hRHA3WFU5YmxUZTI5?= =?utf-8?B?bUdXQUgzZng5bkVqZDdFcHVwZ0ZrVEhZaTd5WlVCMndzNy9iYTNEN0pWZnA0?= =?utf-8?B?b0ExcFNqOXBxL0laa2Y2OFVIOGFZZ21MOEJyczhkL3NjNFJHUXd1eFNJMm9o?= =?utf-8?B?ck1iRXNDYXBNTDVmeVdUaUU1V2tWdzdTeGNaZ3UrSWs5M0oyRHBvb1FuaXlS?= =?utf-8?B?ZzgxVTZlNWRqVlV5Ym1EcTFzSHRMYVlJeW9kaDZEQkxEZUkrNmNHOU9IYXds?= =?utf-8?B?UTJYenJ6R056b011MElFVnRHcDQ2YTIwd2ZlUkR3bzNlWjJJQmRINjNvSm02?= =?utf-8?B?c0VGZXIwM1JOZGhjdU1rcnNwQllXdmlBNnhRQWJ6YW04WGxzTmpUVkZQQ29E?= =?utf-8?B?ZmdQLy9zeVA0K0Q1VnZmSTNsdWk2Ujl6bjE5TUNHMWJhWXQ4OTc5UGJSTjBW?= =?utf-8?B?bHF4ZkppWDFnT3ZGQ1pBaW9PVFhnMWZzdGovSWJMRTRFRG5GTi9ZZktEc1JY?= =?utf-8?B?Nm9WZDE3S1VOZmw2NEVRa1E3S0NNT2sxUmtyUmJGQmNLTlpnU2RUSnNXTHRU?= =?utf-8?B?TXpsTEdyT0dpSzhLZ2FnV1FoN2kzSmQvLzZKSDBYMktsNUFUTkhtSGdTcmZT?= =?utf-8?B?eXVnRWVwbm1XT0drNUR3dmVVbklrS0VTSS85M0NRcmFFR2xlZUZzQT09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e6cf495-b3ff-4b51-e556-08dee11a2a24 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR12MB7007.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 20:06:02.7241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9nc4baFflIsc6WL7TPzSn12O0oNcEwqKEboL3sO+bhJWlBfc+YiNynQG3X0uGUiIcLK/cruUyLiToT3Ttkb7XA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7348 On 2026-07-09 07:49, Maarten Lankhorst wrote: > Hey, > > On 7/9/26 13:14, Robert Mader wrote: >> Hi, >> >> On 09.07.26 12:02, Maarten Lankhorst wrote: >>> Hey, >>> >>> On 7/9/26 08:44, Borah, Chaitanya Kumar wrote: >>>> >>>> On 7/7/2026 6:31 PM, Maarten Lankhorst wrote: >>>>> Hey, >>>>> >>>>> On 7/7/26 10:03, Borah, Chaitanya Kumar wrote: >>>>>> On 7/3/2026 1:02 PM, Robert Mader wrote: >>>>>>> The client cap is currently advertised unconditionally, even for drivers >>>>>>> that do not support plane color pipelines. If clients supporting the later, >>>>>> s/later/latter >>>>>> >>>>>>> like Wayland compositors or tools like drm_info, enable the client cap on >>>>>>> such drivers they will be left without both color pipeline and the legacy >>>>>>> properties COLOR_ENCODING and COLOR_RANGE, effectively breaking YUV->RGB >>>>>>> conversion support. >>>>>>> >>>>>>> Prevent that by only marking the cap supported if there are actually planes >>>>>>> with color pipelines. >>>>>>> >>>>>>> Note: while the color pipeline replacement for the legacy properties is >>>>>>> still under review (1), we can assume that it will work as a drop-in >>>>>>> replacement. >>>>>> This change will but a driver can also choose to export colorops like programmable CTM_3x4 to achieve the same. >>>>>> >>>>>> We should also perhaps document this somewhere that if a driver supports LEGACY properties, it is imperative to implement some version of it with the color pipeline line property. >>>>> Would this be doable inside drm core? Implement the color pipeline properties, get the fixed pipeline for free? >>>> Right now, the Bypass(default) pipeline is automatically created when we call drm_plane_create_color_pipeline_property(), we could come up with a similar helper that could also create a pipeline that replaces the legacy properties. >>>> >>>> But this can't replace the existing helper entirely because some HW (though unlikely) might not support YUV buffers. >>> No need to do this for free, but a cheaper way for drivers to implement legacy >>> properties by only implementing the pipeline would be nice, similar to how >>> atomic also implements legacy modesetting and universal planes. >> >> I really like this idea - should we take it to the corresponding series, https://lore.kernel.org/dri-devel/20260623164812.81110-1-harry.wentland@amd.com/ so the initial implementations for AMD and VKMS directly do so? > > That would be great! > If I understand you correctly you suggest to map legacy COLOR_RANGE and COLOR_ENCODING to the new FIXED_MATRIX colorop in a generic way, instead of having drivers advertise them separately. Do I have that right? It's probably a good idea. It should be easy to make that change after merging the Fixed Matrix series with YUV support. Harry > Kind regards, > ~Maarten Lankhorst