From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758268AbcIOJF2 (ORCPT ); Thu, 15 Sep 2016 05:05:28 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:60018 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751070AbcIOJFY (ORCPT ); Thu, 15 Sep 2016 05:05:24 -0400 X-AuditID: cbfec7ef-f79e76d000005b57-38-57da64506c9d Subject: Re: [PATCH] ARM: s3c24xx: Add dma_slave_map for s3c2440 devices To: Sam Van Den Berge Cc: vinod.koul@intel.com, dmaengine@vger.kernel.org, k.kozlowski@samsung.com, kgene@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Sylwester Nawrocki Message-id: <2fa402bf-0e3f-0495-41ca-7a3c89eaa2e1@samsung.com> Date: Thu, 15 Sep 2016 11:05:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <1473877775-7537-1-git-send-email-sam.van.den.berge@telenet.be> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJKsWRmVeSWpSXmKPExsWy7djPc7oBKbfCDY40mlisnvqX1eL1C0OL /sevmS02Pb7GanF51xw2ixnn9zFZrF6xntniZd9+FgcOj8V7XjJ5bFrVyeaxeUm9R9+WVYwe O39cZ/P4vEkugC2KyyYlNSezLLVI3y6BK+PW0W1MBfNYKnpW/GRpYNzG3MXIwSEhYCLx5Z9+ FyMnkCkmceHeerYuRi4OIYFljBJrV31igXA+M0psWfiFEaLKROLlrzaEqvY1P5ggnOeMEj3n DrKCjBUW8JCYtZsPpEEEqOHk8eWMIDXMAqcZJY5tf8MGkmATMJToPdoHNpVXwE7iyJR/7CA2 i4CqxN0d7Uwgc0QFIiR2302FKBGU+DH5HguIzSngI3HswD6wVmYBA4kZUw4zQdjyEpvXvGUG 2SUhsI1d4vO7vywQb8pKbDrADPGAi8TER9+hnhGWeHV8CzuELSPR2XGQCaK3n1HixJpmRghn BqPEnfYJTBBV1hKHj19khdjGJzFp23RoOPJKdLQJQZR4SBxY8BdqmaPEzrPzWCEBNJ9R4tbT 5YwTGOVnIXloFpInZiF5YgEj8ypGkdTS4tz01GJDveLE3OLSvHS95PzcTYzABHP63/H3Oxif NoccYhTgYFTi4W3wuxkuxJpYVlyZe4hRgoNZSYRXNelWuBBvSmJlVWpRfnxRaU5q8SFGaQ4W JXHevQuuhAsJpCeWpGanphakFsFkmTg4pRoY+2eZT5SKslz7oH5aj5vXhdzMNWmr3l/70XhB apXtiiuVjxtCdx0Xzi97yOuwrSDy47L9rLMXynMIR92wz4jcExt3OdNvZ3x6ubJDRlzecfG9 1wSsXr4/+nhDxKN1DQ1HRF5P+B4le/Hn38dz99ue0uWrbRAS/V/wXtP20KH12z54ueauP3u0 QYmlOCPRUIu5qDgRAH/TObAsAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsVy+t/xa7rKKbfCDRov81usnvqX1eL1C0OL /sevmS02Pb7GanF51xw2ixnn9zFZrF6xntniZd9+FgcOj8V7XjJ5bFrVyeaxeUm9R9+WVYwe O39cZ/P4vEkugC3KzSYjNTEltUghNS85PyUzL91WKTTETddCSSEvMTfVVilC1zckSEmhLDGn FMgzMkADDs4B7sFK+nYJbhm3jm5jKpjHUtGz4idLA+M25i5GTg4JAROJl7/a2CBsMYkL99aD 2UICSxglJs2P6WLkArKfM0rceH+ctYuRg0NYwENi1m4+kBoRoN6Tx5czQtQsZJT4fvoeM4jD LHCSUaKj5yULSBWbgKFE79E+RhCbV8BO4siUf+wgNouAqsTdHe1MILaoQITErVUfoWoEJX5M vgfWyyngI3HswD5GkMXMAnoS9y9qgYSZBeQlNq95yzyBUWAWko5ZCFWzkFQtYGRexSiSWlqc m55bbKhXnJhbXJqXrpecn7uJERhp24793LyD8dLG4EOMAhyMSjy8DX43w4VYE8uKK3MPMUpw MCuJ8Kom3QoX4k1JrKxKLcqPLyrNSS0+xGgK9MJEZinR5HxgEsgriTc0MTS3NDQytrAwNzJS Euct+XAlXEggPbEkNTs1tSC1CKaPiYNTqoGx5DBr3o/bam/3MjSt81v+spKjK+mq8fLG/cfS 81JdZxtqL1vCapyZI5h0fn0Lx4SHdYvr2os53aR81HkuxBpsOy4g8v3U/corD7O4uPXXasRZ xr730Tr4vFr3lqxo+0tBhoQpr47M8Epg5zrPGVfokyIbnXdj8S67gF1/d9z23HXz6NOq8EVK LMUZiYZazEXFiQAApRYOygIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160915090519eucas1p14cf1a1906633f81495f76a494263ac70 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160914183040eucas1p22a61e6b39333cfe1aa9a6b63e74a1bcf X-RootMTR: 20160914183040eucas1p22a61e6b39333cfe1aa9a6b63e74a1bcf References: <1473877775-7537-1-git-send-email-sam.van.den.berge@telenet.be> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/14/2016 08:29 PM, Sam Van Den Berge wrote: > +static const struct dma_slave_map s3c2440_dma_slave_map[] = { ... > + { "3c2440-sdi", "rx", (void *)DMACH_SDI }, > + { "3c2440-sdi", "tx", (void *)DMACH_SDI }, The device names seem misspelled here, and looking at what drivers/mmc/host/s3cmci.c driver does we need just a single common entry for rx and tx { "s3c2440-sdi", "rx-tx", (void *)DMACH_SDI }, With this fixed feel free to add Reviewed-by: Sylwester Nawrocki -- Thanks, Sylwester