From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Ondrej Zary <linux@zary.sk>
Cc: Christoph Hellwig <hch@lst.de>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] pata_parport: fix memory leaks
Date: Thu, 16 Mar 2023 16:53:08 +0900 [thread overview]
Message-ID: <2fa6c8ec-c25f-5338-ac78-eee422935ab8@opensource.wdc.com> (raw)
In-Reply-To: <20230314225805.9124-1-linux@zary.sk>
On 3/15/23 07:58, Ondrej Zary wrote:
> When ida_alloc() fails, "pi" is not freed although the misleading
> comment says otherwise.
> Move the ida_alloc() call up so we really don't have to free "pi" in
> case of ida_alloc() failure.
>
> Also move ida_free() call from pi_remove_one() to
> pata_parport_dev_release(). It was dereferencing already freed dev
> pointer.
>
> Testing revealed leak even in non-failure case which was tracked down
> to missing put_device() call after bus_find_device_by_name(). As a
> result, pata_parport_dev_release() was never called.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://lore.kernel.org/r/202303111822.IHNchbkp-lkp@intel.com/
> Signed-off-by: Ondrej Zary <linux@zary.sk>
Applied to for-6.3-fixes. Thanks !
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2023-03-16 7:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 12:36 drivers/ata/pata_parport/pata_parport.c:446 pi_init_one() warn: possible memory leak of 'pi' Dan Carpenter
2023-03-11 18:51 ` [PATCH] pata_parport: fix possible memory leak Ondrej Zary
2023-03-11 20:19 ` Sergei Shtylyov
2023-03-11 20:23 ` Sergey Shtylyov
2023-03-11 21:11 ` Ondrej Zary
2023-03-11 21:39 ` Ondrej Zary
2023-03-11 21:44 ` [PATCH v2] " Ondrej Zary
2023-03-12 0:56 ` Damien Le Moal
2023-03-12 21:24 ` Ondrej Zary
2023-03-12 23:17 ` Damien Le Moal
2023-03-13 7:53 ` Ondrej Zary
2023-03-14 22:58 ` [PATCH v3] pata_parport: fix memory leaks Ondrej Zary
2023-03-16 7:53 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fa6c8ec-c25f-5338-ac78-eee422935ab8@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@zary.sk \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome