From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77EBBC43334 for ; Fri, 15 Jul 2022 08:09:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232153AbiGOIJK (ORCPT ); Fri, 15 Jul 2022 04:09:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232132AbiGOIJI (ORCPT ); Fri, 15 Jul 2022 04:09:08 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CE0B1C10A; Fri, 15 Jul 2022 01:09:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1657872547; x=1689408547; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=QiWXCDd+tr7X4ZNAanKz+iHUgbLxFw3inBwRa85x5wI=; b=cNN+S0PS98HU7iEK6wxhWxYmrvRF2jxeuHoDYOhoVEJBRPIyQq3wD69o k8i39zjeM+gCDq8hhXIkwKAmz97+tSPwFul5b8nlj4Zj5sa7Z06YFZ2wW bav0XC59Epf9ttigj+DFLA2sMHg7RjTUb9z7uxb2mV26jvZ7vuu5EGT7d o=; Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-01.qualcomm.com with ESMTP; 15 Jul 2022 01:09:07 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg03-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2022 01:09:06 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 15 Jul 2022 01:09:06 -0700 Received: from [10.50.55.40] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 15 Jul 2022 01:09:01 -0700 Message-ID: <2faae901-0539-2467-5984-fa476a94968c@quicinc.com> Date: Fri, 15 Jul 2022 13:38:58 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2] arm64: dts: qcom: sc8280xp: fix apps_smmu irq Content-Language: en-US From: Sai Prakash Ranjan To: Parikshit Pareek , Andy Gross , Bjorn Andersson CC: Rajendra Nayak , Prasanna Kumar , , "Manivannan Sadhasivam" , Johan Hovold , Dmitry Baryshkov , "Linux Kernel Mailing List" References: <20220712140009.20765-1-quic_ppareek@quicinc.com> <27007c45-1dbb-2c35-b1a8-eb2b2a6c9512@quicinc.com> In-Reply-To: <27007c45-1dbb-2c35-b1a8-eb2b2a6c9512@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/14/2022 12:47 PM, Sai Prakash Ranjan wrote: > Hi Parikshit, > > On 7/12/2022 7:30 PM, Parikshit Pareek wrote: >> Wrong values have been introduced for interrupts property. Fix those >> ones, and correct the mapping of context banks to irq number. >> >> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") >> Signed-off-by: Parikshit Pareek >> --- >>   arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >> index 7945cbb57bb4..1276a833251e 100644 >> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >> @@ -1580,7 +1580,6 @@ >>                        , >>                        , >>                        , >> -                     , >>                        , >>                        , >>                        , >> @@ -1591,6 +1590,7 @@ >>                        , >>                        , >>                        , >> +                     , >>                        , >>                        , >>                        , > > Cross checking with the IP doc, 696 is not the only one missing, couple of other interrupts are also missing, below is the list. > > Interrupt 689 and 706 are not present in the IP doc, remove it. > Interrupts 696, 697, 716, 913 are missing, I see this patch adds 696, add 697 as well. > Interrupt 890 is not a context interrupt, remove it. > > Checking offline with Parikshit, looks like adding all these entries results in interrupt selftest failures. So for now, we can just have the original patch merged till these failures are debugged further with internal teams. Thanks, Sai