From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752593AbdEHSfZ (ORCPT ); Mon, 8 May 2017 14:35:25 -0400 Received: from mail-qt0-f178.google.com ([209.85.216.178]:34135 "EHLO mail-qt0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751191AbdEHSfX (ORCPT ); Mon, 8 May 2017 14:35:23 -0400 Subject: Re: [PATCH] drm/vc4: Enable selection in Kconfig on any BCM platform. To: Florian Fainelli , Eric Anholt , dri-devel@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, Ray Jui , Scott Branden , Jon Mason References: <20170508181825.19854-1-eric@anholt.net> <30064246-3ad9-da6b-8035-804fe56d6efe@gmail.com> Cc: linux-kernel@vger.kernel.org, mircea.carausu@broadcom.com From: Scott Branden Message-ID: <2fade4f5-7758-44a5-ba4d-01d54ee7a9fc@broadcom.com> Date: Mon, 8 May 2017 11:35:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <30064246-3ad9-da6b-8035-804fe56d6efe@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17-05-08 11:30 AM, Florian Fainelli wrote: > On 05/08/2017 11:18 AM, Eric Anholt wrote: >> With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" >> to let the module get built on a cygnus-only kernel. However, I >> anticipate having a port for Kona soon, so just present the module on >> all of BCM. > > This seems reasonable, but by replacing ARCH_BCM2835 which is common to > ARM/Linux and ARM64/Linux, you are no longer allowing an ARM64 systems > to benefit from this driver unless COMPILE_TEST is also selected, right? > > This could be: > > depends on COMPILE_TEST > depends on ARCH_BCM # 32-bit ARM > depends on ARCH_BCM2835 || ARCH_BCM_IPROC # 64-bit ARM There are no 64-bit IPROC variants that use this. > > or maybe down to just: > > depends on COMPILE_TEST > > and let DRM, COMMON_CLK and SND drive the bulk of the dependencies? > >> >> Signed-off-by: Eric Anholt >> --- >> >> I would be sending this through drm-misc-next, assuming BCM >> maintainers like it. >> >> drivers/gpu/drm/vc4/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig >> index 973b4203c0b2..f136813abf56 100644 >> --- a/drivers/gpu/drm/vc4/Kconfig >> +++ b/drivers/gpu/drm/vc4/Kconfig >> @@ -1,6 +1,6 @@ >> config DRM_VC4 >> tristate "Broadcom VC4 Graphics" >> - depends on ARCH_BCM2835 || COMPILE_TEST >> + depends on ARCH_BCM || COMPILE_TEST >> depends on DRM >> depends on SND && SND_SOC >> depends on COMMON_CLK >> > >