From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C31E138FA6 for ; Wed, 31 Jul 2024 18:13:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722449595; cv=none; b=exWogRoc7rMrK0tgFwKdHHou0IGjKCA68nALFFInm5RnW/oRAgpAJteiIHhV3cqL8jWgB9uFjVKqmYFzHzH6ABbLssIRipMbnJG8Z9WhIFA3xqaNTZuTuI2y2i9jPdbnBWk3iJ8Bb9t9FpCA2yvTWA1ehPC7dr5DDnWPMqRwFtQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722449595; c=relaxed/simple; bh=uQwOrxQmn4UWuOdYTz/ZFVXWCNeQRZ3Mc8Mz/PrYA1E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e5GhvW91Z/dJBh6wNxtwNFRBL0h3e6vb6o+eDUnAMtIMRCVOlNCPHYCA/mX1tBeGTOZ1f968/UJFV8U19Smyqh4hjzsloCoWQpAkFPKZHaeB1ZNhMa2LGVfJJkxHynKpnlC6BGlaZKWo+Of+BE7p80LT5n63NnFcU4oUGK+rJi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LKJgh6Vq; arc=none smtp.client-ip=209.85.166.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LKJgh6Vq" Received: by mail-io1-f50.google.com with SMTP id ca18e2360f4ac-812796ac793so31140039f.3 for ; Wed, 31 Jul 2024 11:13:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722449593; x=1723054393; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9U9Aeo88raKDsbH9TG7H5YN1vzWt4rRDmAinflLvkZ4=; b=LKJgh6Vq8t2oIct4QSI7B7b0sjNqG9lQ5K41NH0USiieBt2LcX/oFy40qw5t8CAue0 UkxRL1HxzeDpMxBWDm5WTV3lhaDAQDscwLKKY7gVPTEC25kpyxAwzGQuF24QT8C7kdzQ Y1c1l/rzJS6a9Y4l7J0QBqAzN9rnPOOFtxMhQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722449593; x=1723054393; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9U9Aeo88raKDsbH9TG7H5YN1vzWt4rRDmAinflLvkZ4=; b=ivH2G+ndsY1HIeNejmvpcHByzlZm/hh+xK45jCxXwPquKEKbPF8hPox2m9A/B2YXuS I8kVL2QOnRpbjqFWmoM/kypt0kLuxaVG1G16Wnr8DkMR2LGz5rQTrkkQSpjsj/k0PsWP UKQAPs5E+JqICJJki21cNDDFOHifKwa6TgnL0wSUp2wWi9ZsXOZeEtAhQGhgU2Whymze gyvSJCvps8hx30SzkenVvQ6dlYDNKea64OiwL8EsabXDiUCp53mDCockMQwVB2R7sFPw Y2AcEfnhg6Gc+8Asih83npMce+amjLUbJaQLlG1FqRUO8Zro+i3og7Wyshy4dmLBIjcI 8aAQ== X-Forwarded-Encrypted: i=1; AJvYcCUg90OESsiWgf18Sag9nMYuIYdUZnsbnKJZblQDjeyh9p2ApziQw3Cl1q7uGnCVXYfgf5g8zOhLot7y7iw=@vger.kernel.org X-Gm-Message-State: AOJu0YwVTVbWen9mkkRAyI1ed+JjzOKcaCb962EoDae80Fj+qYOJAwNc oTeC22yJ+DhV3D+y2305dKZlOdaiHEkyuC8QA4YFK7JI4Q1sHDIB5ezEIDeyeXY= X-Google-Smtp-Source: AGHT+IEHDc/6KXUE+4h4v4FSTmQPsunt90tpxasZpI82+oz/OgCHb5Aq6q70sUiWXESPFmm2+pk1Tw== X-Received: by 2002:a6b:ea0d:0:b0:81f:8f3a:5689 with SMTP id ca18e2360f4ac-81fcc13167emr9584739f.0.1722449592803; Wed, 31 Jul 2024 11:13:12 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-81f88597d83sm390466939f.6.2024.07.31.11.13.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 11:13:12 -0700 (PDT) Message-ID: <2fb7e346-f49c-4a4a-812b-2b6d3c0edd25@linuxfoundation.org> Date: Wed, 31 Jul 2024 12:13:11 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests: lib: remove strscpy test To: Muhammad Usama Anjum , Kees Cook Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan , Shuah Khan References: <20240725121212.808206-1-usama.anjum@collabora.com> <9d5c0793-e90a-4549-92b1-41ad06b85de6@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/31/24 02:32, Muhammad Usama Anjum wrote: > On 7/31/24 3:37 AM, Shuah Khan wrote: >> On 7/25/24 06:11, Muhammad Usama Anjum wrote: >>> The strscpy test loads test_strscpy module for testing. But test_strscpy >>> was converted to Kunit (see fixes). Hence remove strscpy. >>> >>> Fixes: 41eefc46a3a4 ("string: Convert strscpy() self-test to KUnit") >>> Signed-off-by: Muhammad Usama Anjum >>> --- >>> Changes since v1: >>> - Remove from Makefile and config file as well >>> --- >> >> As mentioned in other threads on this conversion to kunit and removal >> of kselfttest - NACK on this patch. >> >> Please don't send me any more of these conversion and removal patches. > This patch is removing a dead kselftest as its corresponding test module > was moved years ago (in 2022). This test has been failing since then. It > seems like misunderstanding that I'm removing something. > Thank you for the clarification Applied linux-kselftest for Linux 6.12-rc1 thanks, -- Shuah