From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98D9E361DB6; Thu, 20 Nov 2025 15:18:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763651914; cv=none; b=QwIQ78HIBSzPtbGqovOC1JrfNvZoYWUuRhYVEYj0aL1BaZnKLKUin5IKsoNxW+4wEtQ7XYux2RrD0vwMeQlw/M98C5ntmtd+3uDoZvtSKOYB4yMpFtjTp36U/e7Tn/0e5SriHcMLB6GVUcOgQ32y+/nYMValV5xIbGmSVXuRqLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763651914; c=relaxed/simple; bh=KiKmLPo0LId2AqBx7SKloWwEHaffPU4qyU54oEDKIa8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Nm7cGJb/4TaEJT8QBRfgLe46/MmJihkeiE/Set+5wEzMcU5k8qnBL3P23rS6oxN/XI+zZ8YxuWorge0HmC3ROLTGjYjOqkrvYGJmd8nNRaA2hUmKOT1riSy4GZgkfI6Wgnqq1byrE9Rb171u4I0UID1/+6d2Z6hfg6kJf4ien5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=l9S42diO; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="l9S42diO" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 5E0DF1A1C4A; Thu, 20 Nov 2025 15:18:24 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 2C8EC6068C; Thu, 20 Nov 2025 15:18:24 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 1371810371C4F; Thu, 20 Nov 2025 16:18:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1763651902; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=W+w9uzAPuUadr/2vcu3RjzEbTIq1CSq9medNjoIyd0c=; b=l9S42diO51gPGUNuhEnHQSnWSxeL7UtQyzWf+pSUkD1kHEiJLJ2pxLkp7FW9teyxIjXeM7 GjWKcU9mPtqPUARnLTB3ODK0eZk1VkcUWYggdmpPLYWEwWavemElCdfRIimMfNBGkrc44R GfJd21OqCv3vIdx3ElchM3qWyG5kH3MY8B17grroqx8eE6LefdKu7NWY2NY9qgsXmOufzK SPI/OvH7FwMVdEIafwEKK2MLS+gq44ozi4hBBVG84S8XT/UIoO2PlY0dPj4Mx0IwzrYzDc aCTBmsdZC7uM6gAaoQzZlnJlVWbMcQ7lEVSNmdFhnJRosCsGAmk0OA+xXUyoPw== Message-ID: <2fbd40ed-40e6-4ba2-b914-1f6d2d26dc85@bootlin.com> Date: Thu, 20 Nov 2025 16:18:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v17 03/15] net: phy: Introduce PHY ports representation To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?Q?K=C3=B6ry_Maincent?= , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Oleksij Rempel , =?UTF-8?Q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Antoine Tenart , devicetree@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , Rob Herring , Romain Gantois , Daniel Golle , Dimitri Fedrau References: <20251119195920.442860-1-maxime.chevallier@bootlin.com> <20251119195920.442860-4-maxime.chevallier@bootlin.com> <20251119195400.1bf0cc68@kernel.org> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <20251119195400.1bf0cc68@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 20/11/2025 04:54, Jakub Kicinski wrote: > On Wed, 19 Nov 2025 20:59:04 +0100 Maxime Chevallier wrote: >> diff --git a/net/ethtool/common.c b/net/ethtool/common.c >> index 2f4b70f104e8..8216e4ada58e 100644 >> --- a/net/ethtool/common.c >> +++ b/net/ethtool/common.c >> @@ -460,6 +460,21 @@ const struct link_mode_info link_mode_params[] = { >> static_assert(ARRAY_SIZE(link_mode_params) == __ETHTOOL_LINK_MODE_MASK_NBITS); >> EXPORT_SYMBOL_GPL(link_mode_params); >> >> +const char ethtool_link_medium_names[][ETH_GSTRING_LEN] = { >> + [ETHTOOL_LINK_MEDIUM_BASET] = "BaseT", >> + [ETHTOOL_LINK_MEDIUM_BASEK] = "BaseK", >> + [ETHTOOL_LINK_MEDIUM_BASES] = "BaseS", >> + [ETHTOOL_LINK_MEDIUM_BASEC] = "BaseC", >> + [ETHTOOL_LINK_MEDIUM_BASEL] = "BaseL", >> + [ETHTOOL_LINK_MEDIUM_BASED] = "BaseD", >> + [ETHTOOL_LINK_MEDIUM_BASEE] = "BaseE", >> + [ETHTOOL_LINK_MEDIUM_BASEF] = "BaseF", >> + [ETHTOOL_LINK_MEDIUM_BASEV] = "BaseV", >> + [ETHTOOL_LINK_MEDIUM_BASEMLD] = "BaseMLD", >> + [ETHTOOL_LINK_MEDIUM_NONE] = "None", >> +}; >> +static_assert(ARRAY_SIZE(ethtool_link_medium_names) == __ETHTOOL_LINK_MEDIUM_LAST); > > Thanks for reshuffling things, this one needs a static tho: > > net/ethtool/common.c:463:12: warning: symbol 'ethtool_link_medium_names' was not declared. Should it be static? Ok I figured that I didn't have sparse installed locally, so the local NIPA build "build_allmodconfig_warn" didn't go through. That's fixed now, hopefully even less bugs next time ! Maxime