mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Abhishek Chauhan <quic_abchauha@quicinc.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Andrew Halaney <ahalaney@redhat.com>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	Martin KaFai Lau <martin.lau@kernel.org>,
	Martin KaFai Lau <martin.lau@linux.dev>
Cc: kernel@quicinc.com
Subject: Re: [PATCH net-next v2] net: Modify mono_delivery_time with clockid_delivery_time
Date: Thu, 29 Feb 2024 10:30:39 +0100	[thread overview]
Message-ID: <2fc6a4f7ea0308626cfd06d95564486d187b16e0.camel@redhat.com> (raw)
In-Reply-To: <20240228011219.1119105-1-quic_abchauha@quicinc.com>

On Tue, 2024-02-27 at 17:12 -0800, Abhishek Chauhan wrote:
> Bridge driver today has no support to forward the userspace timestamp
> packets and ends up resetting the timestamp. ETF qdisc checks the
> packet coming from userspace and encounters to be 0 thereby dropping
> time sensitive packets. These changes will allow userspace timestamps
> packets to be forwarded from the bridge to NIC drivers.
> 
> Existing functionality of mono_delivery_time is not altered here
> instead just extended with userspace tstamp support for bridge
> forwarding path.
> 
> Signed-off-by: Abhishek Chauhan <quic_abchauha@quicinc.com>

Since this is touching a quite sensitive code path, I think v3 would
deserve some paired self-tests.

Thanks!

Paolo


  parent reply	other threads:[~2024-02-29  9:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28  1:12 Abhishek Chauhan
2024-02-28 15:53 ` Willem de Bruijn
2024-02-28 20:03   ` Abhishek Chauhan (ABC)
2024-02-28 20:14     ` Willem de Bruijn
2024-02-28 21:53       ` Abhishek Chauhan (ABC)
2024-02-29  0:09         ` Willem de Bruijn
2024-02-29  0:13           ` Abhishek Chauhan (ABC)
2024-02-29  3:06   ` Martin KaFai Lau
2024-02-29 14:44     ` Willem de Bruijn
2024-02-29 23:00       ` Abhishek Chauhan (ABC)
2024-02-29  9:30 ` Paolo Abeni [this message]
2024-02-29 23:15   ` Abhishek Chauhan (ABC)
2024-02-29 14:40 ` Andrew Halaney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2fc6a4f7ea0308626cfd06d95564486d187b16e0.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=ahalaney@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kernel@quicinc.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=quic_abchauha@quicinc.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®