From: "Chen Cheng" <chencheng@fnnas.com>
To: "Abd-Alrhman Masalkhi" <abd.masalkhi@gmail.com>,
"Chen Cheng" <chenchneg33@gmail.com>,
<linux-raid@vger.kernel.org>, <yukuai@fygo.io>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] md: protect read mddev->recovery in md_sync_action()
Date: Sat, 11 Jul 2026 18:56:10 +0800 [thread overview]
Message-ID: <2fcb6a64-25d7-4759-af6e-701a78f57e72@fnnas.com> (raw)
In-Reply-To: <m2y0g0z0ll.fsf@gmail.com>
在 2026/6/27 19:25, Abd-Alrhman Masalkhi 写道:
>
> Hi Chen,
>
> On Sat, Jun 27, 2026 at 18:52 +0800, Chen Cheng wrote:
>> 在 2026/6/27 18:46, Abd-Alrhman Masalkhi 写道:
>>> On Sat, Jun 27, 2026 at 18:29 +0800, Chen Cheng wrote:
>>>> From: Chen Cheng <chencheng@fnnas.com>
>>>>
>>>> md_sync_action() read mddev->recovery in lockless path, use READ_ONCE()
>>>> instead of u64 plain read.
>>>>
>>> unisgned long is not always u64...
>>> I can not see what it fixes, is this just to silence KCSAN? If so,
>>> please say so in the commit message.
>>
>> I need to find KCSAN report , I lost this one, but I think it's easy to
>> find locklessly path to call md_sync_action(), so. READ_ONCE is need.
>>
> Thanks. Adding the KCSAN report would be helpful.
>
hi Abd-Alrhman
Uh... a apologize for my mislead . it's truelly report by review-bot ,
and after double check , I think it wouldn't be reproduce in my x86-64
machine , because 8B in x64-arch load is atomic +align..
thanks,
cheng.
>>>
>>>> Fixes: e792a4c2156a3 ("md: add new helpers for sync_action")
>>>>
>>>> Signed-off-by: Chen Cheng <chencheng@fnnas.com>
>>>> ---
>>>> drivers/md/md.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/md/md.c b/drivers/md/md.c
>>>> index c5c50640b684..f4415c1a79d9 100644
>>>> --- a/drivers/md/md.c
>>>> +++ b/drivers/md/md.c
>>>> @@ -5074,11 +5074,11 @@ static enum sync_action md_get_active_sync_action(struct mddev *mddev)
>>>> return is_recover ? ACTION_RECOVER : ACTION_IDLE;
>>>> }
>>>>
>>>> enum sync_action md_sync_action(struct mddev *mddev)
>>>> {
>>>> - unsigned long recovery = mddev->recovery;
>>>> + unsigned long recovery = READ_ONCE(mddev->recovery);
>>>> enum sync_action active_action;
>>>>
>>>> /*
>>>> * frozen has the highest priority, means running sync_thread will be
>>>> * stopped immediately, and no new sync_thread can start.
>>>> --
>>>> 2.54.0
>>>>
>>>
>>
>
prev parent reply other threads:[~2026-07-11 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-27 10:29 Chen Cheng
2026-06-27 10:46 ` Abd-Alrhman Masalkhi
2026-06-27 10:52 ` Chen Cheng
2026-06-27 11:25 ` Abd-Alrhman Masalkhi
2026-07-11 10:56 ` Chen Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fcb6a64-25d7-4759-af6e-701a78f57e72@fnnas.com \
--to=chencheng@fnnas.com \
--cc=abd.masalkhi@gmail.com \
--cc=chenchneg33@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=yukuai@fygo.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®