Re: [PATCH net-next v4 3/4] net: renesas: rswitch: add offloading for L2 switching

[ALOK TIWARI <alok.a.tiwari@oracle.com>]

On 8/28/2025 3:53 PM, Michael Dege wrote:
> +static int rswitch_get_port_parent_id(struct net_device *ndev,
> +				      struct netdev_phys_item_id *ppid)
> +{
> +	struct rswitch_device *rdev = netdev_priv(ndev);
> +	const char *name;
> +
> +	name = dev_name(&rdev->priv->pdev->dev);
> +	ppid->id_len = min_t(size_t, strlen(name), sizeof(ppid->id_len));
> +	memcpy(ppid->id, name, ppid->id_len);

Please recheck here sizeof(ppid->id_len) or sizeof(ppid->id)
it currently uses sizeof(ppid->id_len), which is just 1 byte,
so id_len will always be limited to 1.

> +
> +	return 0;
> +}
> +


Thanks,
Alok