From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752073AbdJDM23 (ORCPT ); Wed, 4 Oct 2017 08:28:29 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:20221 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751947AbdJDM20 (ORCPT ); Wed, 4 Oct 2017 08:28:26 -0400 Subject: Re: [PATCH v9 06/12] mm: zero struct pages during initialization To: Michal Hocko Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com, heiko.carstens@de.ibm.com, davem@davemloft.net, willy@infradead.org, ard.biesheuvel@linaro.org, mark.rutland@arm.com, will.deacon@arm.com, catalin.marinas@arm.com, sam@ravnborg.org, mgorman@techsingularity.net, steven.sistare@oracle.com, daniel.m.jordan@oracle.com, bob.picco@oracle.com References: <20170920201714.19817-1-pasha.tatashin@oracle.com> <20170920201714.19817-7-pasha.tatashin@oracle.com> <20171003130857.vohli6lnqj4tdmhl@dhcp22.suse.cz> <73ea1215-7aa2-39e1-b820-30f58119183e@oracle.com> <20171004084554.fhxpmywtovs5umnm@dhcp22.suse.cz> From: Pasha Tatashin Message-ID: <2fd7b718-c254-612b-e100-a457094e7c38@oracle.com> Date: Wed, 4 Oct 2017 08:26:57 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171004084554.fhxpmywtovs5umnm@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/04/2017 04:45 AM, Michal Hocko wrote: > On Tue 03-10-17 11:22:35, Pasha Tatashin wrote: >> >> >> On 10/03/2017 09:08 AM, Michal Hocko wrote: >>> On Wed 20-09-17 16:17:08, Pavel Tatashin wrote: >>>> Add struct page zeroing as a part of initialization of other fields in >>>> __init_single_page(). >>>> >>>> This single thread performance collected on: Intel(R) Xeon(R) CPU E7-8895 >>>> v3 @ 2.60GHz with 1T of memory (268400646 pages in 8 nodes): >>>> >>>> BASE FIX >>>> sparse_init 11.244671836s 0.007199623s >>>> zone_sizes_init 4.879775891s 8.355182299s >>>> -------------------------- >>>> Total 16.124447727s 8.362381922s >>> >>> Hmm, this is confusing. This assumes that sparse_init doesn't zero pages >>> anymore, right? So these number depend on the last patch in the series? >> >> Correct, without the last patch sparse_init time won't change. > > THen this is just misleading. > OK, I will re-arrange patches the way you suggested earlier. Pasha