From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74F99142E9F for ; Fri, 24 Jan 2025 06:00:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737698425; cv=none; b=biIERUR0/Ul3j3WxjcS+QuF+I7AxTGeA5WeGm6jkPWtp9nou649lzU6I2P/zqtFABs4carervKU2yOEIN+RCpGu9TE5lOgbqM1+97f9A0LIocMcSsnnx4d+J26+1Cf8EbIYc9cUZJQAURajWBTLdbliTFVdpEtOzDxMgEKOmM9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737698425; c=relaxed/simple; bh=8ca1G7RaXl6BYCsVSGgE0j3ftQBbBeZrH3QercmY6iQ=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=k2Bmny3Pj5NPMYoRA82KFddnkCOfpn4rjuLvPt6r3Hdw8n4AvXeDLAqtpN5h+qPPPXRtR1IJZ7MKX1E8FWlhXSbdY/W1dxK0qbngu4nY5Kdv2mjuyvPKE74Ryz8QbcSToKsCsv8aUwuVZMM64B0IbtnG5yhbXvd8NqcfePEDLeQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=meFLRnHK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="meFLRnHK" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50NNvvCS025795 for ; Fri, 24 Jan 2025 06:00:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 48WLvrmGgq8l5irtiIVlpxzaJVXPZ+RlqW2L6jPOFuM=; b=meFLRnHKT5vtOFkA Ar3Sav+HG2/0PS8xAIG07cOtmouwEYVrBxVf/0h7UHglk+DkA4sGuCVFuRhnqDC4 Jq86RINgIPrrfHVDX/XqosmrMeBBCZMOgWi63EVOc8meNayNo8nOk8Z7F/6+JdTb HjDQY1TkTkQU4kRhv3lxzddrJ3BfkXovFmLjrxalG8EH2eYac/4eucGrS5B/bspz GisSdGzyAdMzUjXi66K/DTrV210S12g/t2PkNPbBjdP/Sc+6m1XzG6qejjbqbnlL ff7SeyLM2EPPieH/Tz1UPgtTiWMWTsAK1GUijczN8GN9oBYcyXTIIyUzs9atE5p9 QY2qIw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44bywc0kyb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 24 Jan 2025 06:00:22 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2162f80040aso31195015ad.1 for ; Thu, 23 Jan 2025 22:00:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737698421; x=1738303221; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=48WLvrmGgq8l5irtiIVlpxzaJVXPZ+RlqW2L6jPOFuM=; b=sXoZtnCDvXib5irhLSPo/avnPX0OH67JskF6hb3D6GJrObLTiIlFZCNEkdvqxl4Fut ysZZquuMTC6aNhmpk/dYRhVbxiN4xbnPVLLVQ/QTm+z2JE9pXVxjOjj7SWkM66/m0AlF g2i/Zig6rKV1DrZtTNevs7sz2U1DLUVJWaV3+RQvZZXw6poKzdFW3Qi495HssTcwX1Jk caW33LXDDFqCKzB4E/+S8hZTbCZMwTAyY0CJ1fpZaK3qKWtGBRLBvPPtwvyU0F9cGcrg q1Wru9o9KQK5wxEtF4F/QAwBJq4/GFJwxRkYfdHGB3bl9i0XnT95yFyYx5aNG2+X11gG sSTg== X-Forwarded-Encrypted: i=1; AJvYcCUr14v2fqmQc6gaqyMqCVXcs/mgvD8gylJOByRX7Cedbgq1pUmFYIun3x+DJ+SPC/jTdGi4P9CILYXbuAA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx11DMHbXANClfdTPRR7a5Lpc6CG920sLGgj/PPZSfiAwjhGNj4 ecDt5ySca464wLUhKlaL2koqqchjm0R38LzQmjSaSBex6K/cV2dJVmFlLwaGCZwfDsgxkiEv2v6 acVeB4QqbT4DRqLo+Zg7xLOtf/2gyDMefpNoC1dRGMk23Qvl6C/slhpPE3bm1YkM= X-Gm-Gg: ASbGncv6Er8SP+f6AaA3bBxFT4KaMG6lDvCFd31gT/g/yL/y64usSa2XUDC4YnAssS7 TV+yXfwPzVbqubxujz8EkNJBM+D3EVuTYzGJe5XsZWsJfGspfy6Xba0ilAMheWheyZ6WNiDgNJl DUH0fN7r4U8zg8fXk/nWk62vXPYlwtg9BhdiuCfZp5XLyxTaBAFelnNKE7gLvMjEfailSmUUlm0 CpcnMyG7Av7DNdoB0RYcKtAqBpyKRyW4PVC42mdbxBFOlgGOCj57DiFoj8SBTHaaXvS//OYd9z4 veZrLKaIOsM= X-Received: by 2002:a17:902:e743:b0:215:a039:738 with SMTP id d9443c01a7336-21c352de481mr468312645ad.5.1737698420700; Thu, 23 Jan 2025 22:00:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEY2M8ll7VI/M66jt4+0uoyEviD0sV6PuwerOhF56aY9l+1ofmanLjzThwLUGQXXTPjMhbOjg== X-Received: by 2002:a17:902:e743:b0:215:a039:738 with SMTP id d9443c01a7336-21c352de481mr468312165ad.5.1737698420336; Thu, 23 Jan 2025 22:00:20 -0800 (PST) Received: from [10.64.68.153] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da414ed3bsm8435955ad.193.2025.01.23.22.00.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2025 22:00:19 -0800 (PST) Message-ID: <2fd825ac-ea58-4acd-a27b-b104868bcc20@oss.qualcomm.com> Date: Fri, 24 Jan 2025 14:00:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] firmware: xilinx: Update the zynqmp_pm_load_pdi() API To: Nava kishore Manne , michal.simek@amd.com, ronak.jain@amd.com, gregkh@linuxfoundation.org, jay.buddhabhatti@amd.com, praveen.teja.kundanala@amd.com, siva.durga.prasad.paladugu@amd.com, u.kleine-koenig@baylibre.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250123103522.1258499-1-nava.kishore.manne@amd.com> <20250123103522.1258499-2-nava.kishore.manne@amd.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20250123103522.1258499-2-nava.kishore.manne@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: GW2GBU3ABBRNbasgzAuoEfHpTvUH6v48 X-Proofpoint-GUID: GW2GBU3ABBRNbasgzAuoEfHpTvUH6v48 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-24_02,2025-01-23_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 malwarescore=0 mlxscore=0 bulkscore=0 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=848 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501240041 On 1/23/2025 6:35 PM, Nava kishore Manne wrote: > Update the zynqmp_pm_load_pdi() API to handle the firmware > error’s properly. > > Signed-off-by: Nava kishore Manne > --- > drivers/firmware/xilinx/zynqmp.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c > index 720fa8b5d8e9..ea04a6ac402d 100644 > --- a/drivers/firmware/xilinx/zynqmp.c > +++ b/drivers/firmware/xilinx/zynqmp.c > @@ -1483,8 +1483,16 @@ EXPORT_SYMBOL_GPL(zynqmp_pm_set_requirement); > */ > int zynqmp_pm_load_pdi(const u32 src, const u64 address) > { > - return zynqmp_pm_invoke_fn(PM_LOAD_PDI, NULL, 3, src, lower_32_bits(address), > - upper_32_bits(address)); > + u32 ret_payload[PAYLOAD_ARG_CNT]; > + int ret; > + > + ret = zynqmp_pm_invoke_fn(PM_LOAD_PDI, ret_payload, 3, src, > + lower_32_bits(address), > + upper_32_bits(address)); > + if (ret_payload[0]) > + return ret_payload[0]; Looks a little bit hacking. As the ret_payload is u32, return as int, it has possibility to overflow? > + > + return ret; > } > EXPORT_SYMBOL_GPL(zynqmp_pm_load_pdi); > Thanks, Jie