From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8568A248F57 for ; Mon, 17 Nov 2025 02:36:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763347012; cv=none; b=IOz5JyihiMfrFzEQJreq6R+Qvo9CHL6A5VKRbh5UbFExLKzZRG+9KzhcLHsFtNa59NmOpSl9gBpEbHINGDI5jINreH5YzqLKyhUPeXUzgibTVf29i6wiEGAhOKikQ6/eIz0QHbHWwxz5hMSoglgkctVoEpJMA9mop6VihLIbk2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763347012; c=relaxed/simple; bh=tw6Ajn/FDHb+1nEhaIG1ILZ9sF2BneSZ7D4tEaBnBj0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LJfAVAI9+Kp3vVb3atyK3eK7D79wrXMQHjhyQKpedBrKy+E4gGV68vwSPnBLQyJP8Kxye8kS4m2qbVoqVPPn+dY3taDHNXqHcTb4/u/Vq2sM1Nxil1HQHiivwuTebwivZ7lCRM1lADT+LmtuLvcqOs46qg2+tsoznTXRJlVWIfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YuSLJsFd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TFgvzOQU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YuSLJsFd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TFgvzOQU" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AH0tMpX2688619 for ; Mon, 17 Nov 2025 02:36:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 39pbJS3KgdysbLKFSIpTFsRIixBoour3yJy497186+I=; b=YuSLJsFdOr3BcJNh Gj5MugWKswwVd+rbaw1i6qWOK1Bl3HgyKx7UJC4Y8M3tE/xEwX0o5UqFsawE+xc1 vzFwgTtgDvDYUBd6FChY4pX/Gli7EGaQQlbWgr4RTj7E36Focd+p/d/b4HvXKdrr DbUyIh4hq551V4XfpJonhVmQT/LTX6WdmsIgrRncEC/66enyz7mbvtoH4OjTk5kP pdV5+dVBMaeB10vGXG1vaozmzZ9XBCD/+md0nWwIHhiXqndxmA5TMSlCnxC/KQbz uofUdCsg7rE1GKP5Es17kQW1613Jk2hjbIYFvMPmT0rEsA0ZaRE+SNLXp+C6DpKq yb03Vg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aejkmb38k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Nov 2025 02:36:48 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-297e1cf9aedso99194385ad.2 for ; Sun, 16 Nov 2025 18:36:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763347007; x=1763951807; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=39pbJS3KgdysbLKFSIpTFsRIixBoour3yJy497186+I=; b=TFgvzOQUACrP9CY1YEi+R+s4/p9lU112DnKoJ7f8BNlsVpn8Uk2jVqvVeKzAgfmWU0 hsyRRSzmvgDzNdr7nXsT03Qs/2SMwH96DSlot99VbyreFLZ2GLYuIkSzoBG6jsu5GVbX r+eVdNbaYtUosepaFG3MPhZXKmpWnRE196WUdhuhdPwTKV47ZGasBo13ykgV4QCl6lud zeYj8f8tQvtnCOZrra+Pcdmjh+EXUDFDrZGKfQ1vpWNVZqA8rQu/JX1eVIQ6VujEO670 cr2OfFr82MMeU7ZCxwa8UWb9WZxOzAzFxvVniabtAkKvzHiPzlFv+b04TNA4FVSs2m/p A/Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763347007; x=1763951807; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=39pbJS3KgdysbLKFSIpTFsRIixBoour3yJy497186+I=; b=nQ40eZ6KpD4loi9nBsnVDZjEExA5MLhhCiT+6FRliofGd5DUDsorT4Kgw/Pcqs9AkT mnuklv1kVUM8fmeYQpIn7V6lwINEjX76OkMFfYXZomZrpnse+Q+UT9F63RE1weLbccxr AO8A6CGZgtk5OAKFudef7aJtnf7EWWrMdJ1mAESXC41HOEeSVbAkWp73yVDu8UFLuDll E6pbsc7RHXu4/c9Ys9kuV/3EM/kxemv90XjTeklQ4TMb5mJlWQpouel1NOUsZphApR71 GLY4glJWbG3IlKCJS/l1xu/etE/9iij+KaNm1lzI2Eds+xNvUp8u90+xqVFjm00cY4QW yg+Q== X-Forwarded-Encrypted: i=1; AJvYcCWYBUpdQSD/olvF1WB6ts9XeMa4FuNZoNDDyni2XwCoowi6Nm/6COwBF50mB/4CI0WW9NbUJc2XWv4fWtw=@vger.kernel.org X-Gm-Message-State: AOJu0YyATeqPs0IBXC3BrwVzZVII8ESzArD1log0m+Sj/bXkt2TH0jRF 8Sirc3ViV7dW+3JZ/Gh+qWdlnvTiHagV7kzZ/tvKqr8BkNMUBAzt7XC01riDPGZsSkqBg01Pfum HND3S/QMaDV9tiVrJg8hbcSYmTTIZ9CQ2apP86GnRZ+cPk8QJskjX4l/g3tpovXexMvI= X-Gm-Gg: ASbGncvYDMNdn6Z4V75/rxDiyU5/x5CUqbVhItE7CUotfkX3wEiEQSR0lv1tsY/C8+d 5gOWGJLFGxprPFvDz3lOifhul5PbRTUb1iFPwJM1TATwDwZDJlmeQh3Xv7cIkhI2CjUsG/LFHY+ n39HoALe30vi5Bw6x1u3I8uJIzZjZZdiEq8filVBFnVADTHJ9WNGwsEKVvz33Z0X1DvkIjvnpjX xcDYwsDSlwhRH03zbb8UNop5DILvBilYk3kpuGKYECDc6fJ0Uv4MmDHHyPx/sLE80ZF+sSEbKfM JPVdAnzbRwLAdFX2n3vOu8usKeolG4NHPX+g7HKlBs2iX97ODC+BeyomCjuzodvhrlIWQ/nP9Wo CGaJ8O9ZJ+n2uOcM3zIkEBBp4MgcMhvf+u4BHZgHcqBZrgBq1mjldIOCdVm1D8Pe7K1lyC2c+ X-Received: by 2002:a17:902:ec83:b0:297:fec4:1557 with SMTP id d9443c01a7336-2986a7598abmr116773815ad.60.1763347007432; Sun, 16 Nov 2025 18:36:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IF8W+0BgPJEYbjw4FrKmofDfdMKM3fYG9H5M16t+BNUAdPhrbs9j8JpXvNtQsZA+wy9bjNFIg== X-Received: by 2002:a17:902:ec83:b0:297:fec4:1557 with SMTP id d9443c01a7336-2986a7598abmr116773605ad.60.1763347006931; Sun, 16 Nov 2025 18:36:46 -0800 (PST) Received: from [10.133.33.104] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c2bf11asm121402975ad.90.2025.11.16.18.36.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Nov 2025 18:36:46 -0800 (PST) Message-ID: <2fd84ab2-2e3e-4d05-add5-17930a35fedf@oss.qualcomm.com> Date: Mon, 17 Nov 2025 10:36:39 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] wifi: ath: Use static calibration variant table for devicetree platforms To: Manivannan Sadhasivam , Jeff Johnson , Johannes Berg , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, devicetree@vger.kernel.org, ath12k@lists.infradead.org, Miaoqing Pan References: <20251114-ath-variant-tbl-v1-0-a9adfc49e3f3@oss.qualcomm.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20251114-ath-variant-tbl-v1-0-a9adfc49e3f3@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: yA_JGVFRpB4Wsipukjhsw8VHqAINZF8O X-Authority-Analysis: v=2.4 cv=N6ok1m9B c=1 sm=1 tr=0 ts=691a8a40 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=oboMlcojp0BuSSWQvFAA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=HhbK4dLum7pmb74im6QT:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE3MDAyMCBTYWx0ZWRfX/zI9FeLf/kVt hZOxdTUksLC2gG/Keej2EYhh55skcnHoh7RmOBj+D8Vr5K4wA7zgmyPKq4VjOoYl4Up8+9T+6If L4qTDLeWVI4oOlCxtP15gqfVKA7oTDdjiXxfgwfOIyfWgHfwhC4yerOlO8rwJjXUjl++LfzIenQ TOW82SaV6iUI1HXblWGYj8peSztqZmHlY6JTKWoYo2k1uvKjXm4FNsQM8/91L5Z1XpUzimukbAe +oqhsPjlNhT4OoryvQEYUaJMIhiBGCox1fzwsH2WDnl8hDAzEMsqOg7BrurY/Z4bQX3cKeuXyHO rZGeiMEyg1sV8Oj5b4TnkJV31Q8yISBa0dqFlbQUitJsYKGhK+ScnnNBuDEMaeDPd/Lvikuw/cz FNKlpCKzskzhH8F+MvXhxGN62dcjvA== X-Proofpoint-GUID: yA_JGVFRpB4Wsipukjhsw8VHqAINZF8O X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_01,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511170020 On 11/14/2025 6:22 PM, Manivannan Sadhasivam wrote: > Hi, > > This series aims to deprecate the usage of "qcom,*calibration-variant" > devicetree property to select the calibration variant for the WLAN devices. This > is necessary for WLAN devices connected using PCI bus, as hardcoding the device > specific information in PCI devicetree node causes the node to be updated every > time when a new device variant is attached to the PCI slot. This approach is not > scalable and causes bad user experience. I am not very clear about the problem here: is calibration variant device/module specific, or platform specific? If it is module specific, why the lookup is based on the machine 'model' property? While if it is platform specific, why do we need to update devicetree node whenever a new device is attached? > > So to avoid relying on the "qcom,*calibration-variant" property, this series > introduces a new static calibration variant table based lookup. The newly > introduced helper, ath_get_calib_variant() will parse the model name from > devicetree and use it to do the variant lookup during runtime. The > ath_calib_variant_table[] will hold all the model and calibration variant > entries for the supported devices. > > Going forward, new entries will be added to this table to support calibration > variants. > > Signed-off-by: Manivannan Sadhasivam > --- > Manivannan Sadhasivam (2): > wifi: ath: Use static calibration variant table for devicetree platforms > dt-bindings: wireless: ath: Deprecate 'qcom,calibration-variant' property > > .../bindings/net/wireless/qcom,ath10k.yaml | 1 + > .../bindings/net/wireless/qcom,ath11k-pci.yaml | 3 +- > .../bindings/net/wireless/qcom,ath11k.yaml | 1 + > .../bindings/net/wireless/qcom,ath12k-wsi.yaml | 6 +- > .../bindings/net/wireless/qcom,ipq5332-wifi.yaml | 2 +- > drivers/net/wireless/ath/ath.h | 98 ++++++++++++++++++++++ > drivers/net/wireless/ath/ath10k/core.c | 5 ++ > drivers/net/wireless/ath/ath11k/core.c | 7 ++ > 8 files changed, 115 insertions(+), 8 deletions(-) > --- > base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787 > change-id: 20251114-ath-variant-tbl-22865456a527 > > Best regards,