From: Dave Hansen <dave.hansen@intel.com>
To: linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>, Ingo Molnar <mingo@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Ian Campbell <ijc@hellion.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
x86@kernel.org
Subject: Re: [tip: x86/build] x86/boot: Drop CRC-32 checksum and the build tool that generates it
Date: Fri, 11 Apr 2025 12:52:50 -0700 [thread overview]
Message-ID: <2fddc2e9-8c97-48de-bcc3-29645d58f0f1@intel.com> (raw)
In-Reply-To: <364ad671-5e5c-47c1-af22-34a7c481f8e3@intel.com>
On 4/11/25 12:33, Dave Hansen wrote:
...
> The only weird thing I'm doing is booting the kernel with qemu's -kernel
> argument.
I lied. I'm doing other weird things. I have a local script named
"truncate" that's not the same thing as /usr/bin/truncate. Guess what
this patch started doing:
> quiet_cmd_image = BUILD $@
> -silent_redirect_image = >/dev/null
> -cmd_image = $(obj)/tools/build $(obj)/setup.bin $(obj)/vmlinux.bin \
> - $(obj)/zoffset.h $@ $($(quiet)redirect_image)
> + cmd_image = cp $< $@; truncate -s %4K $@; cat $(obj)/vmlinux.bin >>$@
^ right there
I'm an idiot. That was a poorly named script and it cost me a kernel
bisect and poking at the patch for an hour. <sigh>
Sorry for the noise.
next prev parent reply other threads:[~2025-04-11 19:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 16:48 [RFC PATCH resend] " Ard Biesheuvel
2025-03-07 23:11 ` [tip: x86/build] " tip-bot2 for Ard Biesheuvel
2025-04-11 19:33 ` Dave Hansen
2025-04-11 19:52 ` Dave Hansen [this message]
2025-04-12 8:48 ` Ingo Molnar
2025-04-18 7:05 ` Ard Biesheuvel
2025-03-11 16:59 ` [RFC PATCH resend] " Vitaly Kuznetsov
2025-03-11 17:14 ` H. Peter Anvin
2025-03-11 17:25 ` Ard Biesheuvel
2025-03-11 17:29 ` H. Peter Anvin
2025-03-11 17:44 ` Ard Biesheuvel
2025-03-12 1:34 ` H. Peter Anvin
2025-03-12 18:57 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fddc2e9-8c97-48de-bcc3-29645d58f0f1@intel.com \
--to=dave.hansen@intel.com \
--cc=ardb@kernel.org \
--cc=hpa@zytor.com \
--cc=ijc@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome