mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: dave.hansen@linux.intel.com, luto@kernel.org,
	peterz@infradead.org, x86@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mm: fix return value of p[um]dp_set_access_flags
Date: Fri, 20 Sep 2019 09:16:12 -0700	[thread overview]
Message-ID: <2fde036a-f64e-ce58-65bf-a089e7c673aa@intel.com> (raw)
In-Reply-To: <20190920021821.GA8472@richard>

On 9/19/19 7:18 PM, Wei Yang wrote:
> Last but not least, since update_mmu_cache_pmd is empty, even return
> value is not correct, it doesn't break anything.

In other words, this patch has no functional effect and does not provide
a "fix".  What's the point of patching this stuff if it has no effect?

  reply	other threads:[~2019-09-20 16:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19  8:25 Wei Yang
2019-09-19 17:25 ` Dave Hansen
2019-09-20  2:18   ` Wei Yang
2019-09-20 16:16     ` Dave Hansen [this message]
2019-09-23  6:00       ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2fde036a-f64e-ce58-65bf-a089e7c673aa@intel.com \
    --to=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=peterz@infradead.org \
    --cc=richardw.yang@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®