From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Jakub Kicinski <kuba@kernel.org>,
Matt Johnston <matt@codeconstruct.com.au>
Cc: John Wang <wangzq.jn@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: mctp: Consistent peer address handling in ioctl tag allocation
Date: Fri, 02 Aug 2024 08:21:46 +0800 [thread overview]
Message-ID: <2fde081adb2352e613ae33536363f284f1b46f32.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240801085744.1713e8b5@kernel.org>
Hi Jakub and John,
> On Tue, 30 Jul 2024 16:46:35 +0800 John Wang wrote:
> > When executing ioctl to allocate tags, if the peer address is 0,
> > mctp_alloc_local_tag now replaces it with 0xff. However, during tag
> > dropping, this replacement is not performed, potentially causing
> > the key
> > not to be dropped as expected.
> >
> > Signed-off-by: John Wang <wangzhiqiang02@ieisystem.com>
>
> Looks sane. Jeremy? Matt?
All looks good to me!
Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au>
(John had already discussed the change with us, so no surprises on my
side)
> In netdev we try to review patches within 24-48 hours.
> You have willingly boarded this crazy train.. :)
Yeah we bought express tickets to netdev town! I just saw that there
were nipa warnings on patchwork, so was waiting on a v3. If it's okay
as-is, I'm happy for a merge.
Cheers,
Jeremy
next prev parent reply other threads:[~2024-08-02 0:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 8:46 John Wang
2024-08-01 15:57 ` Jakub Kicinski
2024-08-02 0:21 ` Jeremy Kerr [this message]
2024-08-02 1:05 ` Jakub Kicinski
2024-08-02 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fde081adb2352e613ae33536363f284f1b46f32.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wangzq.jn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®