From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F128CC7EE29 for ; Fri, 9 Jun 2023 15:22:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241463AbjFIPWg (ORCPT ); Fri, 9 Jun 2023 11:22:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241269AbjFIPWa (ORCPT ); Fri, 9 Jun 2023 11:22:30 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C0493586 for ; Fri, 9 Jun 2023 08:22:28 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-9786c67ec32so323939966b.1 for ; Fri, 09 Jun 2023 08:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686324147; x=1688916147; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GgdpsFvlSHfvL616lpSzlLkpCKPLET85+hweuPq7lJc=; b=FzyLHKGcr/Xw1q9ffKxueV/CMkIQ9Sh16XHXg/11EsJ+JRZrZplrMeYCYt/aNFUs3X RdPmw7diWOrISV+qzlcK3NoKC95i/SRsMIBtshckxVTJ0Pa4KOVFSkpu/BNhxNnTmGrp alRKlSV192nhtWZ4bqi5NyFGNRovkaWhK7ajlUrPgtYKXYULL0QBtwNpGn1BKpoU0q+k lfz5KqSMv39OjRz6M8rRoeoEU3DhWBc00/qCbus0vPV02PfoEjgJURxLnUCDqJz5gmNI V9HAuk0Zf3E4SV+MY2IKl7tR7OrAqZsFakwO9UUejmT6ygjkv7xuF7XZ1w7vCx2CHA76 k0+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686324147; x=1688916147; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GgdpsFvlSHfvL616lpSzlLkpCKPLET85+hweuPq7lJc=; b=kPrH+wEaZa0yZ26IL2Og8a3WaZhzNPtKmr9PWlL1pRwxKunwMxPCpU4rFdhxaYJii8 qpyrvgTIiU9e/pNJmjz96wSAjpajCJmSsJv+6fxNRGwr0MLifpwJwCSRW5GGLNo8r1DQ CJTIOeNUhzPaz07qmCIe9j6r1SES2WwKOsG7wyv7KmtGz/5931w2JE8ROhES8r9S01+0 5RIGnMnXoceBpKuLMVTHBCmKb7yzSK5azwYV4sJkvGQRK3Ds3i7NB1UbacG9dwnA9Ljt E6JFeBL642ayEWxjtsp5FnzGtehmnawaOsMfeOqicIowZp8/2TqukxpKOzVZNg5WoWA1 fZkA== X-Gm-Message-State: AC+VfDwWGwnyw5BVhMsGgUNpuy1gorgEXvD9b7PmjkLrJBfkO8o0yQSV p1iSx00dKTmFLWbkow7Wu8k0jA== X-Google-Smtp-Source: ACHHUZ7q69XNyD0Ob8QMei1RaexdonLE4GtsIMKFsMTA3rAxns1PVZy9ZARL+DMqns9sNRl+z541mA== X-Received: by 2002:a17:907:25cc:b0:94f:6218:191d with SMTP id ae12-20020a17090725cc00b0094f6218191dmr2079991ejc.32.1686324146722; Fri, 09 Jun 2023 08:22:26 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id v19-20020a170906565300b00969e9fef151sm1421651ejr.97.2023.06.09.08.22.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 08:22:26 -0700 (PDT) Message-ID: <2fe0c7f9-55fc-ae63-3631-8526a0212ccd@linaro.org> Date: Fri, 9 Jun 2023 17:22:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v4 2/9] virt: geniezone: Add GenieZone hypervisor support To: Yi-De Wu , Yingshiuan Pan , Ze-Yu Wang , Jonathan Corbet , Catalin Marinas , Will Deacon , Arnd Bergmann , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-mediatek@lists.infradead.org, Krzysztof Kozlowski , Rob Herring , Conor Dooley , Conor Dooley , Trilok Soni , David Bradil , Jade Shih , Miles Chen , Ivan Tseng , My Chuang , Shawn Hsiao , PeiLun Suei , Liju Chen , Willix Yeh References: <20230609085214.31071-1-yi-de.wu@mediatek.com> <20230609085214.31071-3-yi-de.wu@mediatek.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230609085214.31071-3-yi-de.wu@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2023 10:52, Yi-De Wu wrote: > From: "Yingshiuan Pan" > > GenieZone is MediaTek hypervisor solution, and it is running in EL2 > stand alone as a type-I hypervisor. This patch exports a set of ioctl > interfaces for userspace VMM (e.g., crosvm) to operate guest VMs > lifecycle (creation and destroy) on GenieZone. ... > +static int gzvm_drv_probe(void) > +{ > + int ret; > + > + if (gzvm_arch_probe() != 0) { > + pr_err("Not found available conduit\n"); > + return -ENODEV; > + } > + > + ret = misc_register(&gzvm_dev); > + if (ret) > + return ret; > + gzvm_debug_dev = &gzvm_dev; > + > + return 0; > +} > + > +static int gzvm_drv_remove(void) > +{ > + destroy_all_vm(); > + misc_deregister(&gzvm_dev); > + return 0; > +} > + > +static int gzvm_dev_init(void) > +{ > + return gzvm_drv_probe(); So for every system and architecture you want to: probe, run some SMC and then print error that it is not othe system you wanted. I don't think this is what we want. You basically pollute all of other users just to have your hypervisor guest additions... Best regards, Krzysztof