From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 752C9E7E631 for ; Tue, 26 Sep 2023 13:12:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234812AbjIZNMY (ORCPT ); Tue, 26 Sep 2023 09:12:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234800AbjIZNMV (ORCPT ); Tue, 26 Sep 2023 09:12:21 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7C7E8FC; Tue, 26 Sep 2023 06:12:14 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 40AEC1FB; Tue, 26 Sep 2023 06:12:52 -0700 (PDT) Received: from [10.1.197.1] (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BC9EF3F5A1; Tue, 26 Sep 2023 06:12:11 -0700 (PDT) Message-ID: <2fe54425-70b5-95e8-1e9e-337424827adb@arm.com> Date: Tue, 26 Sep 2023 14:12:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v9 00/13] Add support to configure TPDM DSB subunit Content-Language: en-US To: Tao Zhang , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski Cc: Jinlong Mao , Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org, andersson@kernel.org References: <1694670204-11515-1-git-send-email-quic_taozha@quicinc.com> From: Suzuki K Poulose In-Reply-To: <1694670204-11515-1-git-send-email-quic_taozha@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/09/2023 06:43, Tao Zhang wrote: > Introduction of TPDM DSB subunit > DSB subunit is responsible for creating a dataset element, and is also > optionally responsible for packing it to fit multiple elements on a > single ATB transfer if possible in the configuration. The TPDM Core > Datapath requests timestamps be stored by the TPDA and then delivering > ATB sized data (depending on ATB width and element size, this could > be smaller or larger than a dataset element) to the ATB Mast FSM. > > The DSB subunit must be configured prior to enablement. This series > adds support for TPDM to configure the configure DSB subunit. > > Once this series patches are applied properly, the new tpdm nodes for > should be observed at the tpdm path /sys/bus/coresight/devices/tpdm* > which supports DSB subunit. > e.g. > root@qemuarm64:/sys/devices/platform/soc@0/6c08000.tpdm/tpdm1# ls -l > drwxr-xr-x 2 root root 0 Jan 1 00:00 connections > drwxr-xr-x 2 root root 0 Jan 1 00:00 dsb_edge > -rw-r--r-- 1 root root 4096 Jan 1 00:00 dsb_mode > drwxr-xr-x 2 root root 0 Jan 1 00:00 dsb_msr > drwxr-xr-x 2 root root 0 Jan 1 00:00 dsb_patt > -rw-r--r-- 1 root root 4096 Jan 1 00:00 dsb_patt_ts > -rw-r--r-- 1 root root 4096 Jan 1 00:00 dsb_patt_type > drwxr-xr-x 2 root root 0 Jan 1 00:00 dsb_trig_patt > -rw-r--r-- 1 root root 4096 Jan 1 00:00 dsb_trig_ts > -rw-r--r-- 1 root root 4096 Jan 1 00:00 dsb_trig_type > -rw-r--r-- 1 root root 4096 Jan 1 00:02 enable_source > --w------- 1 root root 4096 Jan 1 00:00 integration_test > drwxr-xr-x 2 root root 0 Jan 1 00:00 power > --w------- 1 root root 4096 Jan 1 00:02 reset_dataset > lrwxrwxrwx 1 root root 0 Apr 5 2021 subsystem -> ../../../../../bus/coresight > -rw-r--r-- 1 root root 4096 Apr 5 2021 uevent > -r--r--r-- 1 root root 4096 Jan 1 00:00 waiting_for_supplier > > We can use the commands are similar to the below to configure the > TPDMs which support DSB subunit. Enable coresight sink first. > echo 1 > /sys/bus/coresight/devices/tmc_etf0/enable_sink > echo 1 > /sys/bus/coresight/devices/tpdm1/reset_dataset > echo 0x3 > /sys/bus/coresight/devices/tpdm1/dsb_edge/ctrl_idx > echo 0x1 > /sys/bus/coresight/devices/tpdm1/dsb_edge/ctrl_mask > echo 0x0 > /sys/bus/coresight/devices/tpdm1/dsb_edge/ctrl_val > echo 1 > /sys/bus/coresight/devices/tpdm1/dsb_patt/enable_ts > echo 1 > /sys/bus/coresight/devices/tpdm1/dsb_patt/set_type > echo 0 > /sys/bus/coresight/devices/tpdm1/dsb_trig_ts > echo 0xFFFFFFFF > /sys/bus/coresight/devices/tpdm1/dsb_patt/tpmr5 > echo 0xFFFFFFFF > /sys/bus/coresight/devices/tpdm1/dsb_trig_patt/xpr2 > echo 1 > /sys/bus/coresight/devices/tpdm1/enable_source > I have reviewed this set, except for the last patch, rest looks fine. If you could resend the series with the comments addressed, we could queue this. Suzuki