From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758678AbcG0Vbz (ORCPT ); Wed, 27 Jul 2016 17:31:55 -0400 Received: from mail-db5eur01on0061.outbound.protection.outlook.com ([104.47.2.61]:63467 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757929AbcG0Vbv (ORCPT ); Wed, 27 Jul 2016 17:31:51 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=cmetcalf@mellanox.com; Subject: Re: clocksource_watchdog causing scheduling of timers every second (was [v13] support "task_isolation" mode) To: Christoph Lameter References: <1468529299-27929-1-git-send-email-cmetcalf@mellanox.com> <7a3f66f7-5011-7d59-2e0e-f57e4e42e6b6@mellanox.com> CC: Gilad Ben Yossef , Steven Rostedt , Ingo Molnar , Peter Zijlstra , Andrew Morton , "Rik van Riel" , Tejun Heo , Frederic Weisbecker , Thomas Gleixner , "Paul E. McKenney" , Viresh Kumar , Catalin Marinas , "Will Deacon" , Andy Lutomirski , "Daniel Lezcano" , , , From: Chris Metcalf Message-ID: <2fefa17d-37c6-9669-724e-9ee0d841e7b2@mellanox.com> Date: Wed, 27 Jul 2016 15:58:14 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: CY1PR1201CA0025.namprd12.prod.outlook.com (10.169.17.163) To HE1PR05MB1689.eurprd05.prod.outlook.com (10.169.119.155) X-MS-Office365-Filtering-Correlation-Id: eabfab1a-eda3-4223-bbba-08d3b658635f X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1689;2:xjz9JMkPdnRrSM6CT8A0CQSgkZc3IUp2G85jFJO9bAjZe5o7/dWIyqCsdjWHi+cQAriQAwLikaGnnfn+6OJJ0HXjFtJhGjgNWlYNvUh3ujeQHDgQq3FIijapYtez/IGWZ43HHtsTGcmkhBZpFdt7R7HHMZGH3kD+NnEJqKLhCP/CDhQuGFFSAlqnkpbeO+Rm;3:4O4tPW0rAYYSo2x9TJ+MngBMEpcEy5W/pKJLIuT37jw2pH6yNeTtY9xOlMi5cgXDhnO/nj1oq1FVLKGgs+4DyZYxYs2Jme7qcQgSB30+TCLoo39tF+qHrcMq7Q6/s8I2;25:yKlpD/hV37VD6zjoAYGvfmpSBB1YLwLp/KkMZm+9d0TnLYW0ieN47C53IwXouS5X6q+evOCcXEIUpuIjO4LiiUUNEsVMLB4MZStvN5LUCDepQ/z0vhlDKxGE+3MvNUUao3jT4Qv16x+/ht6EDyw7ascuIeq1ST9WZMTVufLVykOerzlZP3L1Z/t0zGwFdXKR0XvIeWZl9fACUHtgKUSqP/QxPW9d/lsJVMuf+l8SEhTU5rswSMEkZ/XhgUbibyicaTGDgrHGqGJ0l1OBNc+ualCPnJ7NYD8+FuFmF5YuNA6p1K6gJnSiydl6mqRUK6AAAMa3OTh2MUHbJxGACEGmZOH4f2I/w0Vla1l1KcYRlfBbP7Jr5rHFip8jDSqU6auxVzzn8QSZwk5u7ClIyQg7jxaNbsdxp+i2uNEv1rnc+B8=;31:XLzhufZMw+IWV9Go7s7x7PAsflYOqVFj3kn+NXSDXsFsMXGoD9EbKdrAUcufCnKRyFRNUFAfhPMgAfYVK96GNlK9wOkwhn7dtjlxcs7isoa8ZSmr2jZYlO2zSA4QXSgXVDz4KpFbEmxITB7xClRBE0MnnSyGDlBqep3WQPoL82f70xBmtXBrXR2muqdZBB9Dv6JWql0uNWnRV6OnLhDAIw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1689; X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1689;20:+ry+x213e2bbIPb3gh7Dvf+qhzFFX+3v8X96uairOWuYIOKPkZNy3lQPYKNmHkksrmyM1cG4Wdb3nGnh+irA/Znj6znGQPzRur9rvRZDxP+z76SPpxe0RcFOX0XXfHdDDbYnSbbC3iKWTCkTLItgav9jVLpMTH/9784iRqqCWKD5i+AiDejoHutmcR6cDYAMSQLX+x2tsUnoSGiNjRoqWjfV8jH1INaO/cTybbpccjzhwmzMylLXKWBmC5EqG3mF/1t6b1Pn/qTsDDjzu9VHorIaeIQa0BcvG10aw+p6EKHP0XlMe0Mhi6XurT1mUM5w421QrIYAe9pfngpVWZ3o4GTvBipp/fDGcWZUxUv2OwWQrQa8ueCdA+j8dBmSnm7UqxPs4lInvXpKLlAY2/7WDWzTyugqASjRIbV5WMqE7mmmXiGQTlsV2bo6XR+xcoikWxDrlB1G/mci+tnzfjPTD6wxCT1XAu9+UM8+/o1YUXA1CsYbO9CZhRWmF8twu1kh X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(209352067349851)(171992500451332); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:HE1PR05MB1689;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1689; X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1689;4:RBaq6Duw7ByvYxp/MniXW/XCNKBgcrJGjfNmbNKj8FvYnuQ5uY7gxjQJpRCNotXpQTC8EuuCY30ZIi9HrG/GZAhjUtWT9POsPEXjm+01sMp0W/DU51ywscUCN3hPmbbXfAnRhMSO9UGc5h7RaIHIpDM6aKv0hUSuWW/43Id6dSDbPLeVrsnQMvUcQQbtt2plrUrdDHRfyQuSyecnuzMOGTCjj7EkhHBELZaD24hGi93Qt4zgfuscz71yzakBeOJ/30yyclN4yQE8Ul1bgX4huLYw7kci8TuhrTNFfFSV8iqLQcC6q/QXcLHGISzgEX/bVaCvmd0YOpoFossErwsjjqIbe6iCxuKriEYhQ8U7/lW00k/c1+4jc9Mtva2wI+qvSd9KaH5eSZKof+7lsQHPGe8w4zuF/t2NlL3G32/0HWKVD6c4Nmh2kLMp06zgF/o6N5364eplQUpVsfeJCshtIw== X-Forefront-PRVS: 0016DEFF96 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(189002)(377454003)(199003)(24454002)(64126003)(33646002)(8676002)(97736004)(105586002)(50466002)(230700001)(19580395003)(31686004)(76176999)(42186005)(2906002)(4326007)(86362001)(92566002)(101416001)(4001350100001)(81166006)(68736007)(47776003)(81156014)(54356999)(36756003)(93886004)(50986999)(106356001)(6116002)(7846002)(586003)(3846002)(15975445007)(83506001)(110136002)(189998001)(77096005)(65806001)(23746002)(66066001)(65956001)(31696002)(7736002)(305945005)(2950100001)(65826006)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR05MB1689;H:[10.15.7.181];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;HE1PR05MB1689;23:852UkGfsOkSO4vsd1FMFTPUvdp6GFX5vRrddT?= =?Windows-1252?Q?qwvFmyC/23DBupEBaCzZ92GXusyRUXhaqwLHg/l+kakq0OWaL7uMCr9p?= =?Windows-1252?Q?CVbFm9WFUokYkidfQkWaprPsO9PECfqS8KaGeiN5n19b2O4HRMIDS6wo?= =?Windows-1252?Q?pklW16mUi/Gbm7egnmZejESZMPxQqiVXXe+Z9WaxtF2OVO9ogpdMu7sN?= =?Windows-1252?Q?7oXTDPHMmAB66iBtddvFilDaXWj1VP03OESpFBNYvJ/8XoAonALzpyNy?= =?Windows-1252?Q?oWPyA/45LIqc4KkDV9JnbXEqCZPkLOqnZidOzBuK6b1f1I4CVglgTPt0?= =?Windows-1252?Q?nxo5OFvFJaQ4UZHQuhYG9Iaq6unxP7JVCHb1RZi4rj+ggDLhAES6wyUX?= =?Windows-1252?Q?Q8L9VvG/2XIUawbNQFgaJ2641Ehy1y5+85oby4P9TolArlCU31Towre0?= =?Windows-1252?Q?BrXEOFj9oeK+RiLrsPQOpoGAdsjY/mY78CryERffdy2/EuYg20XRnWqw?= =?Windows-1252?Q?x8h4waY5Rf87xI1OzqUCgPFwKMVKyW/fzh4rYb5MOvUCfLjo6iNHqm3i?= =?Windows-1252?Q?yHUKw2qEJ3eIgAwYorU0L36KwonUYU36um28DyTZkAIiyB2g/efhRXrD?= =?Windows-1252?Q?Y11X2pndGsZMvJd9Bl67mL7l6WHmacTD5mYxWAm+s2BVyJWvB8iwIwI0?= =?Windows-1252?Q?k3z2/llvLGPsPwrz1HoOjcilBp7MLo2gtfp3Tyl++4Vjs/xMud57+wRu?= =?Windows-1252?Q?NCha96Xp7/DpOFvErDBpDWy6zkqbWMrHZme/jYbW6mOXpkF/Fubo9fXF?= =?Windows-1252?Q?VzDEGeH2kFIflgNsY35oT9HvT8k/zePyO3Xd9gJBQpqlhiPV0v/9OeMf?= =?Windows-1252?Q?y8XRpb9Wz5ZEsg/SMVJQdedmGA98Ckue43lDZHMqeBuJha+maIhY9q2r?= =?Windows-1252?Q?SHsYMYq30ApIb5MdrQE98+YmcjS1OuncpCaQEW6deDQokaYnl6uwQMpM?= =?Windows-1252?Q?UoVMLPHgSr8S+l/KH2cQf1lBAwkUgC/cwaOIpSoF+iguQ7n/fsQ0aa/9?= =?Windows-1252?Q?dlvu5FCQmAv0pc/5okjNzLGj0bqBlh1O9kJa5fDcGpreJKYE8ihQoD5s?= =?Windows-1252?Q?bsWSaPvlNN4xizu87/g1E11UyWjbAZuIAzibvfPXEFkVpwxLXqUBoyZS?= =?Windows-1252?Q?+jUKZS/2/r0yJHyhY9DHnmpJlPKAUBrm94ibAhfJTETHD1unaFtLV7Wi?= =?Windows-1252?Q?2XA7RgiA9xGy5JvMKwLztfnNz203hj01/ansOxqA3b9JX1jNYlP+GC1Z?= =?Windows-1252?Q?Kse+GB70CfBV/NRTHLOPwqQgNKdCiK7iHPzKqGDw3JkSZLpuEXbR1OFI?= =?Windows-1252?Q?4u7xjnVfYvBOvT2nWO91VbQIKcv+VhacNYWv1LHMOuTP6HPgkrkW3g?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1689;6:ORqg/jEptpUsF0D7RCnSdCVd89HLuXElRDuETPnbmyjChz+wE8ocsAvw3wOvmtsWEfsq8H+TRteWNYPqkK7r6DSDkvqxJWboisZrCz9DzPFwSbG2gxGS6HbxarcVuDkfDwZiSwNwMlCtazDOZ1QxdtxOGevf2PzOzXQqgTUJ3mLI3g+pGUM3DXjM8vtBlHiCae8tW7LZKIJZFSh7ByxS01CLp5YvIi7L49Dup0FfcdKwfXUYaPFtAZpRidA/3m6MQmyqbjtCrrGlidERqVwQcP4EcfImlnTsKfN2M16g07W5vcQN+faZPfVaZGkfx4BB4BT4uYjuOvb4qYm+YYV9sw==;5:+sKYeOyxEGngGWnFvFgEmUFR91bx4o4bdJbJfghDV1X66S1TmlBRBCOPti/S99TlgDSN9uZWiUzY0kXHcM9RkbNpsWOhen2MwK2y/31RTS+HDgWArewPJ/gdy3XEzBHVMulVIeZr+fbk5xNo7ioHcg==;24:+GN2aGpz02Ta3ZJuTEN894iADU8HXuFq7pKKv/XwsaQ6POtzKSqRcOagsqeReYa1YJcsZHbBAnPMYAK35k7zmOMDMuc8vuzxrFJY+lqttWA=;7:YzboOhPRjZ6tmYjfzeb1wwbvXbGwGWu9vHQbC5dDmLcdkV0Qt1tdZjCAHEF3fPh+TVeNCab9A82WeoWqlwL+IegWPbPf86uQ6XWt2z74PTVqcCTajDv1xVBJFE5UBUUFl9L4MZk9px/m6aBtxsDQsLJK2mSKY68Jf9mblStmfrBpg0jt43whShzWqpqpzwtVeSEu80N8SNrzYhUErrzPMgSmWdNIPMgdAqbOtClOubVPEDbNEMlTzLWykpHmmOTK SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2016 19:58:28.2153 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1689 X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1689;23:hNAfu9TxPUPxIDOddpLE2tPm3zM4qpGQKYWw9IAn0eNEh1Qvbi4hROwg4bh6gnptc6vwX6W/E3lcgwk5wQkTpfGNC6G060xf1tFKG2N+ZFQWu92qJsDACKGbDAksfn3thwRihXEx1xfCTtzqkcGeIyPIIZeO4qr+vAYNdO8r5TcfuYCdA+KDGSylGoWpeNZt X-OriginatorOrg: Mellanox.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/27/2016 3:53 PM, Christoph Lameter wrote: > On Wed, 27 Jul 2016, Chris Metcalf wrote: > >> Looks good. Did you omit the equivalent fix in clocksource_start_watchdog() >> on purpose? For now I just took your change, but tweaked it to add the >> equivalent diff with cpumask_first_and() there. > Can the watchdog be started on an isolated cpu at all? I would expect that > the code would start a watchdog only on a housekeeping cpu. The code just starts the watchdog initially on the first online cpu. In principle you could have configured that as an isolated cpu, so without any change to that code, you'd interrupt that cpu. I guess another way to slice it would be to start the watchdog on the current core. But just using the same idiom as in clocksource_watchdog() seems cleanest to me. I added your patch to the series and pushed it up (along with adding your Tested-by to the x86 enablement commit). It's still based on 4.6 so I'll need to rebase it once the merge window closes. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com