From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A3E339AEB for ; Thu, 9 Jan 2025 16:02:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736438560; cv=none; b=m/6hjzwQJhHOy2+c6ZvnqQIQOJV8AgFy4ADlb2lBsdOADEwgQkK0VEeEXIE4PGxIBs3aO5miRM3mS6yc904CRpvHajxs2dYQYqNfb55j2sJmmFE0hysaxFdJsCbw0OD4pnpQdZXqeI4wBkPDgg1a7IGiwEbg+oi1zJqvw0ChirM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736438560; c=relaxed/simple; bh=75H6/0ajZvCmTXVSmpfAEKGoLWsp9W/9/mBv1iVOGf4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QARvdkzHHJSen20Pn12VUatpx6MRhqcTfy5lPPVRJmmeAKcJ2IFUr8NXYU+C0FScRgHSeAuAUNJPU6znp8lhLH0WCFww2lQd2QwDS84d9sCrlJNaUTJDe8Ufcqtvjui/qAucowdSq/z9XmheeZ5F7Gy07LT7x+CHuKv85dXx1fo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OQQhbGUw; arc=none smtp.client-ip=209.85.166.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OQQhbGUw" Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-844ef6275c5so32615939f.0 for ; Thu, 09 Jan 2025 08:02:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1736438558; x=1737043358; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MDjh9QDKm25asxr19ZyL90eABxD3gHuiz1JVJyq7sVU=; b=OQQhbGUwEDBaV8PwUNrlkBvkptkco3fiL4MzJPZfEdnOpj3OvB+OPg/4hJ65z91aZF EmMOQt6GIN1DBv8eKDCUbZjxqdBP7uNeFQ4DB+m9pSYZklKaAel19HumjNJoKkDon4NN O60Ay9p56/bQslnPSKHdWHGSwsfv8b3yHyHkQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736438558; x=1737043358; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MDjh9QDKm25asxr19ZyL90eABxD3gHuiz1JVJyq7sVU=; b=Do+S14UNYsHjJIYhCRATR/8yqV2or9gZe7VWjd1LcyuZwvj0NqGqgMA70374mpKNM4 W44oHPL08fqUH3w0fqqUTILmky8BKof7UdypKb2EjDpGCryWlzq8MKZUlw44IQ07yiQK YYc5YJYdNp2B067hl+50UVBYTY+WhSw/ewWM0m9tKLGf5MOr/mfb480haRj6X7U5mC4Q jnnbFjyoiplj4eS43AyTXY2m/i1MCj8puok1+YbFlQWmNjS3umFRaEPogcbKm9rLvwwi T4itKgt7sC+2xm49r2zKKSxkNXgWajWNTgZ3LjxRP0UTQyzEMyq/R2yEqMzjRJyFo78Z 0gJg== X-Forwarded-Encrypted: i=1; AJvYcCVfFLmo6rtucvkAMibTEHa9/NZkUqVpsGn8jhzW6gq5ukA3En9TuJmfUoG1PAPSIykFT/HSlsiZn64bGB4=@vger.kernel.org X-Gm-Message-State: AOJu0YwZTu4Mm1fZu2KUTpSQgQnc/OYZySgETj9qNqsY5N9UZlO23UWP tCz5EAWxY3eFfwFVIoExMtoQF97SgtrBH1xtk5HxT01/ZVUC9BU5zVwxNCdZDqU= X-Gm-Gg: ASbGncthdjGCHj2GV1lJKMHjrIxZY6P2AHQT7YTbq4w3Kb8VQ0vrh4ykgTXlciBU7qn IWV1Sx3RcZgrCVhTHl30aFLwF5RuX+4FnRYs3yUDWYixnonB9G8n/wMrARbDb0JZ7eKuqSG0GEj IX3BwiE/Vt3cLGkB8iHVozWUFx7S/1DqRxpUKPiQf5p33SwAEV09GAS5lCVmhLDI40J3papthvu luHfs72Te2bR0sNubWiyAj0ZFjJDOJpMAPjAcR/TVP5KSPJ+LWEnvGfob1LBNcWoSfe X-Google-Smtp-Source: AGHT+IFJqIqZ9WchDZrl47kNdp0lcVFTFz3959SNA5TmVUyH/Y+O6Qgy5Sn7l/Fp9bRSzYscS50J0g== X-Received: by 2002:a05:6602:4a05:b0:844:e06e:53c6 with SMTP id ca18e2360f4ac-84ce0166661mr554190839f.11.1736438558084; Thu, 09 Jan 2025 08:02:38 -0800 (PST) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-84d61fa3d8asm38255439f.31.2025.01.09.08.02.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2025 08:02:37 -0800 (PST) Message-ID: <2ff39cff-af3c-4020-81b3-4238efe6c2e3@linuxfoundation.org> Date: Thu, 9 Jan 2025 09:02:36 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] usbip: Fix seqnum sign extension issue in vhci_tx_urb To: xndcn Cc: Valentina Manea , Shuah Khan , Hongren Zheng , Greg Kroah-Hartman , "open list:USB OVER IP DRIVER" , open list , Shuah Khan References: <20241231161539.20192-1-xndchn@gmail.com> <20241231161539.20192-2-xndchn@gmail.com> <5ad65964-dcf7-47d2-8e5f-bf82066e55f4@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/3/25 08:18, xndcn wrote: > Thanks. > >> How did you find the problem? >> Why does it make sense to cast it to u32? > > After running with usbip enough time, I happened to see logs like this: >> [ 293.863125] vhci_hcd vhci_hcd.0: Device attached >> [ 294.081110] usb 1-1: new high-speed USB device number 2 using vhci_hcd >> [ 294.193163] usb 1-1: SetAddress Request (2) to port 0 >> [ 294.204334] vhci_hcd: cannot find a urb of seqnum 2147483648 max seqnum -2147483648 >> [ 294.204850] vhci_hcd: stop threads >> [ 294.204851] vhci_hcd: release socket >> [ 294.204853] vhci_hcd: disconnect device > > Then I notice that on 64bit platform, when > atomic_inc_return(&vhci_hcd->seqnum) returns (2147483647 + 1, or > 0x80000000), > priv->seqnum (which is unsigned long, i.e. u64 on 64bit) will be > extends to 0xffffffff80000000 > So we can fix the issue by cast it to u32. > Can you send me the dmesg without and with your patch? thanks, -- Shuah