From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BC1037C114 for ; Fri, 6 Mar 2026 12:25:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772799951; cv=none; b=R7OoydqrlgOcK1MTbS16WndtAXDP0dCFkIT9PdXYdN5/5JkYoKEehfempY8RS6RJqeGDySxhWN46HEFloNha8mg3XxE5/zCVBs1vPhKo0y8nmXANbsnWsxg6c/pX3dH63KMt/XfRCOG1NFe8BPOmFnFsh3UPTvMub9AnLiTCZFQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772799951; c=relaxed/simple; bh=q1mpQNuvkguIV3yJYO03VFzF6mQ49ojmlZq1IbYRwws=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m96aPnw+IhKHQO8tz8FaS/UrFpjk5ZeUgBcY1Obu4HZxAfyFnINyBv9Bd7KFRB+Dtj3qqMqivStSWvz62Df3IBZO1qqWjzYXe+jDoiyMXTfAAuXcO6E/VZB6xxbjbSw8qt9krRiSlEDGrWa7/DIZS4QMbjiHkpriIuFa59QCX3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eLCnNkmL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fddOS3wE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eLCnNkmL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fddOS3wE" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626BakhI3716469 for ; Fri, 6 Mar 2026 12:25:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NUkRbAo0c0S2TlWvB7t+iwi/GOepW+rNCNuvKtI+MXU=; b=eLCnNkmLsPJYxYtg qdJjU55/C4Mu8i+8CIxARztWS2jZUyolOBZ+nrPYrQFKlh62Im5f1/+YO5gzJER8 jQ9kXAJVS5N00YlYWuzMa9yjLabWlSw4OS6VUjSSbKaWSZ8O/HRSNI50q6waRQkj uBSo0noKVLjeGoe9rPUedr668o0PBV/t/FJ1it0dbYuWvPGqg6oS33rOUJZdJRg4 FjtmB6HGIBk3WSqx+fo5KZSppwIbyp+2t7YJmUXRkNBp3sG6NkAJEwWym8EBiEsX VvswcYq8jUmZ/bpwPTh66Pzig/sCmPA72DVhfEeyTDE+Um/Nd+KBDdVFHK+/DFAl BzSMzA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqv98ghbr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 12:25:48 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ae4cdfc468so56085235ad.2 for ; Fri, 06 Mar 2026 04:25:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772799946; x=1773404746; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NUkRbAo0c0S2TlWvB7t+iwi/GOepW+rNCNuvKtI+MXU=; b=fddOS3wEeZmTc69zuagJBDroXx9CGW1CfAbhxENcpnI1vCkuIbDQNq6GoFvk2EblXf jTZqqKWNrPU/gVkWPRrxXa2mjuT6Sm10zlLe6iXNL3lWcUx3Z853J1/6535Kt9PHmcL4 nQpvSnYrk6RNCm191JEpW3kF+oHY26w+9pYY9xGickFGC82qfPFS2W+6ARxyJUYw8wdi rbvUHcEa/xsImNyVV81rIFrQETbl3CRHMpRLT1+xdvUr4q7r7VNCrH+FuJu77vATv1Qa cu1it421P1efquylEKxadAHwX5GRP+0nzaRubTZw8MvyIk7ezvA/P0aHVxO8jRXBdp3F 8q4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772799946; x=1773404746; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NUkRbAo0c0S2TlWvB7t+iwi/GOepW+rNCNuvKtI+MXU=; b=gPr+olDVlL4u5M3nIuXgwJSvd8QgwGVoy8ha7Q2hHYuGprVMdjJByLQejcb8diK+nY AxW0YaEZWX9mOjunxS2YQsZmkkcsfz33EIIe7h8Agr2fg3F4IEreG1nG5UKnZ9+uJ5To 3YoTA/K/5ibPUdX0EnYCmyjGrfbzrO27d7OgTEFLcBvxk1/X24EaOvjlav5h8dT3qHWh a/ZKSjfMD5N3r1Ti8Wydapg+ciulSGw1DA1u49e46Lr/YLrIGp9ziVmKZKKobIc1iGoQ LM5nrDmqwAFnTLbr0sVMr7QS7KGZeat77JjXWkBSCMF+jO3wMzNxxSe1/g2bzlacNM80 5XQg== X-Forwarded-Encrypted: i=1; AJvYcCXzy4odBdlciciEvKvwF7h3T2IRWjET6FxHuGfrpVGkQUYzy/lFgLaC/x6H2aObNCM9rjKQgId1h2nhwv0=@vger.kernel.org X-Gm-Message-State: AOJu0YyW30FEQjPjJnEYfQuTHp+nRRvi8f2rRdZyFFTyHxB95KK/8rLn Gao1AYl0ZAd1qBbEkFq8eIvuU7ZkRTo1Riw2uWv71lCs4GUloQu+PrPRsFsWEsn3qJ0Ae379aFo rWBr5tGV3DqUPTbWvAUL+K9nMx1cNHDsTDkjnFn+Zpdw2dicZ9zwntbaktIbCx/8p0eo= X-Gm-Gg: ATEYQzy4ZjPJUTiPjqKM/FA16JVQ7IdEunlRpDFeI/glLv9inDV30+zkz/4PIqMXOeL 3UUP9sH1PYjecPYwO/3ixY4czVe8PHzy6/rpHokTCtfvsxQtMoJ9U+1hQ0LFNysjNCh2K39JSXZ 4ro4D4Z5q9u1q+GjK0XcA/iWLtGezwHgg4832Lm8rTTpfM6T/xaiWpwc8uJLxW4wsnKj8eaYriQ XXgBFtwpDzdUia4L4G+5dx5ZThEcNB+WRp7qEVcWvQJPzcXPTJPx/OIeV0nELaGS3Cj8WFTcaf/ dFHuN3VHPbYCSnL107qfSnv14Mu70EWOY1sNnSJ6k34VglJOdhdjm6rhcbyYk3uwxwAwznMdkyD JpoIfnaVgpf5u9LMmL+U6Ns5oO7JdvT7KqXO9axksbCkIXh5885qYaGg4tZWi/sGxxhmjM1GguG 1Q/BLAJBR71Wc= X-Received: by 2002:a17:903:f86:b0:2ae:3f3f:67b8 with SMTP id d9443c01a7336-2ae82382430mr20485275ad.15.1772799945431; Fri, 06 Mar 2026 04:25:45 -0800 (PST) X-Received: by 2002:a17:903:f86:b0:2ae:3f3f:67b8 with SMTP id d9443c01a7336-2ae82382430mr20484965ad.15.1772799944923; Fri, 06 Mar 2026 04:25:44 -0800 (PST) Received: from [10.133.33.226] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f74e4fsm18940945ad.58.2026.03.06.04.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 04:25:44 -0800 (PST) Message-ID: <2ffc06fa-002a-4058-a78f-9ff60da9ed22@oss.qualcomm.com> Date: Fri, 6 Mar 2026 20:25:34 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/11] scsi: ufs: core: Introduce a new ufshcd vops negotiate_pwr_mode() To: Krzysztof Kozlowski , avri.altman@wdc.com, bvanassche@acm.org, beanhuo@micron.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Sai Krishna Potthuri , Ajay Neeli , Peter Griffin , Peter Wang , Chaotian Jing , Stanley Jhu , Manivannan Sadhasivam , Orson Zhai , Baolin Wang , Chunyan Zhang , Matthias Brugger , AngeloGioacchino Del Regno , "Bao D. Nguyen" , Adrian Hunter , Archana Patni , open list , "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "moderated list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." , "open list:ARM/QUALCOMM MAILING LIST" References: <20260304135313.413688-1-can.guo@oss.qualcomm.com> <20260304135313.413688-2-can.guo@oss.qualcomm.com> <8bfda6d7-f802-4b44-858a-f52ac8c051ac@kernel.org> Content-Language: en-US From: Can Guo In-Reply-To: <8bfda6d7-f802-4b44-858a-f52ac8c051ac@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: _OAY5p-XGQyBDpN-e-5iuphvO57lxLZu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDExNyBTYWx0ZWRfX3eADROFB8s5p reYlSaPKUBwCMc+1H9WtCUk4+QxPoeQV2ZvZdFOS0mu99qv0yFFGJLD/yznRZ+PBWszBwJDRe5T E/ySP4NvSg3M6cShk8RqQkK64puLWWaBrNrKLBsJA27cTSrlF9ReFkYSqbfjgQJisPBumbfTtbU KTL7FH+BPzMoRKr921bPK8/4EvFyaiJrZTRrWOhQZk4HNnOiP5CAnVdcTa66FF3ToMJzVeisGt4 Lfo+C+WzTqsl1q+JcGjbfaZB28pSob6t1Lzuhi5/w2QMNP8QhgzFg7AEa1OxTUdUMP0YVaZAblE GDkKcOYHFk9QTvTVRObMRjV3DFI9u5frWtqCQPYYJkhgCYebplw1wKQvd4LFyQTYPgwjlHMY2bX yfglnLVCyj607DVcR+t+OTxRp0h6DDnLLLA6jr8Zsf/B8JBK+BL4JV8WkuMnsI8qT0TV9c7rCmM WDCeobnX3DeX0FXjOPQ== X-Authority-Analysis: v=2.4 cv=LbcxKzfi c=1 sm=1 tr=0 ts=69aac7cc cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=bBPRlu2x3IQPgS2CUtEA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: _OAY5p-XGQyBDpN-e-5iuphvO57lxLZu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_04,2026-03-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060117 On 3/5/2026 8:53 PM, Krzysztof Kozlowski wrote: > On 04/03/2026 14:53, Can Guo wrote: >> { >> int ret; >> >> @@ -4747,6 +4745,22 @@ static int ufshcd_change_power_mode(struct ufs_hba *hba, >> return ret; >> } >> > Missing kerneldoc. Will add in next version. Thanks, Can Guo. > >> +int ufshcd_change_power_mode(struct ufs_hba *hba, >> + struct ufs_pa_layer_attr *pwr_mode) >> +{ >> + int ret; >> + >> + ufshcd_vops_pwr_change_notify(hba, PRE_CHANGE, pwr_mode); >> + >> + ret = ufshcd_dme_change_power_mode(hba, pwr_mode); >> + >> + if (!ret) >> + ufshcd_vops_pwr_change_notify(hba, POST_CHANGE, pwr_mode); >> + >> + return ret; >> +} >> +EXPORT_SYMBOL_GPL(ufshcd_change_power_mode); >> + > > Best regards, > Krzysztof