From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE9DC433F5 for ; Wed, 27 Apr 2022 23:42:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237476AbiD0XqG (ORCPT ); Wed, 27 Apr 2022 19:46:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233033AbiD0XqE (ORCPT ); Wed, 27 Apr 2022 19:46:04 -0400 Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B911849927 for ; Wed, 27 Apr 2022 16:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1651102971; x=1682638971; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=b4PQ+YojFt/Da7JedNLqXswRcZ1DtIMcbUQc3b82khE=; b=J4H1yJftl+l3nNwh+olieyj9MCm68i3O9p8GFeKnCEU3DMO9YsmGEaRN FKpe/NgjVcSNRFSbzRpz7h05N3eCxGU4XCWRWuER3Yzq9Y5NxIJre7q28 h4NVS15cexh7XsLh8DsFE716jL04XCHkP+sgZLxA3817nrcKpfIXFWwPC FlXqgAWOZAVa4xQOi6KUXbfEEpDVUa7Wu9x2pcKe6v0dBJuf9MmuUifjl YIXHYPyydWSrPkUPtg28d/1WsTzLKlixtsq0Xlgo2dRdxxfu/HFRH1AEu W3U/V6J7wKPWUeGB5N55MVv+oUl/JBPjvX9uCBhNehle811Xo+n5GbJEt g==; X-IronPort-AV: E=Sophos;i="5.90,294,1643644800"; d="scan'208";a="197844597" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 28 Apr 2022 07:42:50 +0800 IronPort-SDR: 3I4+pgKecEUm66dNTPKYrP62N2ZSV9rl+2tiZNAWSssxgYLDJp8GaYdZm5dXopc5/ylvzqsIBD H++nfl/QtTy34qG0Fkf0hLblWxCurA5TDHR98BKgdJyXXA0/42WlCPPhtYJyqy2THaskRMDdNF j3lMER6qyfduxdaAbRQibLH3ew15aeu0AqqinPFL2Dl2hQdwlcCouRcHuA5GAtfUzfRGvRyfD4 1fPgWAgtv/xSFRcNekGCpZ8iSqs39Ng0wtlBcVhJn3lzdUyUwNpGYC8MLFCgyaUnEAcHw3wvpW BdASz3qwybzFAHObtq1z+T7d Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Apr 2022 16:13:42 -0700 IronPort-SDR: vFxkppu2dVGI6qcZ8C+ZrmUfR5csnoml5bsFakdhwoOiUfSoPJIXdlysrWhS5YtXo8yQyQ9HZP UarZU3nBwQKUiF+mOe2C5/NNu4aqvhT1f+FmE2KpZTcPevY7Q4EX2ZuaK3FSy5FbRbB0IblXet LqzMHPrciyjZeFk0OBjFIeM7as2FGi9sCEbtaG4Fhb2JVS2hkvkcbAm0zo/grLlVybkt/w5xHJ OaKL4xE/2PzI/lGhTJ0YvqsAwkGnYR4fgoSrGXcyZsaRzD9Sj+6dA8yLwZB9ocBGIp08VeHBpC n7k= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Apr 2022 16:42:50 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Kpb0915mXz1SVp1 for ; Wed, 27 Apr 2022 16:42:49 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1651102968; x=1653694969; bh=b4PQ+YojFt/Da7JedNLqXswRcZ1DtIMcbUQ c3b82khE=; b=aG9U+mpCYTqXLYVrB1nXg30+hvfUJ189J7XQSSmBmeZkvjsxkwu zAaurumWJ7fm9SJv5J2FbjspgmG5JAqDow1JiX6iGFfC9Of0kykaaFX4ZDKBNjn7 c1vaCSsv8uCxbA0qKU1vQr7sjo2GKuQXZlvDLVoxWtDsD0Z1sjM+p8Nwc0CEll4E D6XCio2WwJ24l1FBaPYbvh0rG1180xMBAGWn41A2ZxbXvt8f3tjQGcCajxa+bHT1 FmppUurtfeoO8TjI45cH5MPXNN7fFivo3PY5cobe5YbA6m03HnTor8+NQEiSRl8I 0/HpjutNT+lHDztsGZq4Q/AuoqjjlZcpVwA== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SlYm45St0561 for ; Wed, 27 Apr 2022 16:42:48 -0700 (PDT) Received: from [10.225.163.27] (unknown [10.225.163.27]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Kpb025hPwz1Rvlc; Wed, 27 Apr 2022 16:42:42 -0700 (PDT) Message-ID: <2ffc46c7-945f-ba26-90db-737fccd74fdf@opensource.wdc.com> Date: Thu, 28 Apr 2022 08:42:41 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 16/16] dm-zoned: ensure only power of 2 zone sizes are allowed Content-Language: en-US To: Pankaj Raghav , jaegeuk@kernel.org, axboe@kernel.dk, snitzer@kernel.org, hch@lst.de, mcgrof@kernel.org, naohiro.aota@wdc.com, sagi@grimberg.me, dsterba@suse.com, johannes.thumshirn@wdc.com Cc: linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, clm@fb.com, gost.dev@samsung.com, chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, josef@toxicpanda.com, jonathan.derrick@linux.dev, agk@redhat.com, kbusch@kernel.org, kch@nvidia.com, linux-nvme@lists.infradead.org, dm-devel@redhat.com, bvanassche@acm.org, jiangbo.365@bytedance.com, linux-fsdevel@vger.kernel.org, matias.bjorling@wdc.com, linux-block@vger.kernel.org References: <20220427160255.300418-1-p.raghav@samsung.com> <20220427160255.300418-17-p.raghav@samsung.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220427160255.300418-17-p.raghav@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/28/22 01:02, Pankaj Raghav wrote: > From: Luis Chamberlain > > Today dm-zoned relies on the assumption that you have a zone size > with a power of 2. Even though the block layer today enforces this > requirement, these devices do exist and so provide a stop-gap measure > to ensure these devices cannot be used by mistake > > Signed-off-by: Luis Chamberlain > Signed-off-by: Pankaj Raghav > --- > drivers/md/dm-zone.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/md/dm-zone.c b/drivers/md/dm-zone.c > index 57daa86c19cf..221e0aa0f1a7 100644 > --- a/drivers/md/dm-zone.c > +++ b/drivers/md/dm-zone.c > @@ -231,6 +231,18 @@ static int dm_revalidate_zones(struct mapped_device *md, struct dm_table *t) > struct request_queue *q = md->queue; > unsigned int noio_flag; > int ret; > + struct block_device *bdev = md->disk->part0; > + sector_t zone_sectors; > + char bname[BDEVNAME_SIZE]; > + > + zone_sectors = bdev_zone_sectors(bdev); > + > + if (!is_power_of_2(zone_sectors)) { > + DMWARN("%s: %s only power of two zone size supported\n", > + dm_device_name(md), > + bdevname(bdev, bname)); > + return 1; > + } Why ? See my previous email about still allowing ZC < ZS for non power of 2 zone size drives. dm-zoned can easily support non power of 2 zone size as long as ZC == ZS for all zones. The problem with dm-zoned is ZC < ZS *AND* potentially variable ZC per zone. That cannot be supported easily (still not impossible, but definitely a lot more complex). > > /* > * Check if something changed. If yes, cleanup the current resources -- Damien Le Moal Western Digital Research